From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, "John Daley (johndale)" <johndale@cisco.com>,
Weiguo Li <liwg06@foxmail.com>
Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order
Date: Thu, 3 Feb 2022 11:22:20 +0000 [thread overview]
Message-ID: <3ba5d236-0406-636b-db19-9f8fdeeb2749@intel.com> (raw)
In-Reply-To: <1882543.fIoEIV5pvu@thomas>
On 2/3/2022 11:11 AM, Thomas Monjalon wrote:
> 03/02/2022 11:57, Ferruh Yigit:
>> On 2/2/2022 11:50 AM, Thomas Monjalon wrote:
>>>>> Subject: [PATCH] net/enic: adjust memory check and use in proper order
>>>>>
>>>>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
>>>>>
>>>>> Signed-off-by: Weiguo Li <liwg06@foxmail.com>
>>>>>
>>>>> Reviewed-by: John Daley <johndale@cisco.com>
>>>>>
>>>> Applied to dpdk-next-net/main, thanks.
>>>
>>> Please could we have a little of explanation in the commit log?
>>> The title says "adjust [...] and use in proper order"
>>> but I see only a move of the check.
>>>
>>>
>>
>> Is following good? If so I can update it in next-net.
>>
>> net/enic: fix dereference before null check
>>
>> Move memcpy to 'ah->key' after 'ah' null check
>>
>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
>> Cc: stable@dpdk.org
>
> Looks better to me, thanks.
>
>
Updated in next-net, thanks.
next prev parent reply other threads:[~2022-02-03 11:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 12:00 Weiguo Li
2022-01-26 22:00 ` John Daley (johndale)
2022-01-28 14:47 ` Ferruh Yigit
2022-02-02 11:50 ` Thomas Monjalon
2022-02-03 10:57 ` Ferruh Yigit
2022-02-03 11:11 ` Thomas Monjalon
2022-02-03 11:22 ` Ferruh Yigit [this message]
2022-02-03 8:26 ` Weiguo Li
2022-02-02 12:53 [PATCH] " =?gb18030?B?wO7OrLn6?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba5d236-0406-636b-db19-9f8fdeeb2749@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=johndale@cisco.com \
--cc=liwg06@foxmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).