From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C826A00C2; Thu, 3 Feb 2022 12:22:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B19B40143; Thu, 3 Feb 2022 12:22:31 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B1B2C40140 for ; Thu, 3 Feb 2022 12:22:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643887349; x=1675423349; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=veh1m1C29ScOhuNu3V3MGIZEvSnmlNi4Zh0T+NzlpwI=; b=QI3dsJr7NVZK9QFpMoVpZ0sDfchIZ7YX65u/Mc+2BRU0D/XQGJvO0UjD smMdTFVBZP5+jVIOtVKB760j24yZ0CBJ3eXXYeB1lZT557LLMD2tDtB7U ukJ+dqQQwvhfNhCLqbD7+2XZkiXWlkT2yc/8ghIuFUd71w8h98TvI33zI pfQF4X5ja3Ze4s7DJqsh/2MSE0zBR8oLDhgqlqWatnsijEVUdme+BrKX3 bOJZGUTT7+zWIW3hL1pEt6+C1mVs/zoFYv746hczKFZRBkpPD6Vr9G1aX Lyic8l+UVqPrKsaFuhtAGynE3ittYD+31z1qeLpNbU4gNxCSgcOz63Qae w==; X-IronPort-AV: E=McAfee;i="6200,9189,10246"; a="247890118" X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="247890118" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2022 03:22:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,339,1635231600"; d="scan'208";a="483209119" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 03 Feb 2022 03:22:28 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 3 Feb 2022 03:22:28 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 3 Feb 2022 03:22:28 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 3 Feb 2022 03:22:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8qkoktnOGDP9f/a3nu9H8dmfnSBzhO6urST5YHROvcnVwzxvqMy8ut9mhmy8YEMFESJJFPTrvte7RU8A+jNZofpBMsOsHhPSIX1/kF6KAW7SZ2Am6jT5n2c+VMe3SdWbYQ22foBlAYgoO2wNuAspTWfxy2ZTTvhfpBrf6WYYjeYUFtGG0hT4mgmOJogefsdxSxQ476fpQMODSknpY7E1eLH5539xxLqTvDz1s2CiblOCWPagsXDQaetLvF5+m2PdI5zqmbcT7O0+sKqq7C/Ijqkfppx5O2HB1ZILLg4dRATC8qGHoIJZ8l5tEBVftuH/spdnWUEJoSOgcZIGOzeqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3mTh8vfzNedXX4V/pbFdUz8VjsOIasfcZbNJBxoVstg=; b=bPBmLqLiUaKA56aubixNfoj9qt3hBbAaxsPWDAzi1m+9uItsbk8kUTgYt9/VU4DJR6SjhDIbIdgbYmzsejn67BUcgiGkK9waRyljHaN3CrNubGC0m+fhTTpJjxLTpHdksvDJhwpR005zc0H8sXy4nywZwnrD+udBtNjRUZ5R/NY8L9lPRCx49pCwmFQMB42kfVKLiFst3+mKUXOFlt2oaOn0kBcw53UZ/14p7+AbdmlL85EKQ8YeaBbNCcksqsLRzgDcAvWWlQHpv9NGfrnRf9wun1NCq5K4944lqM6/vV4pMMC6Guv5uUi8i70nQAukFsKPoz2H1JnBn4mLxwqOkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BY5PR11MB4386.namprd11.prod.outlook.com (2603:10b6:a03:1bc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Thu, 3 Feb 2022 11:22:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.012; Thu, 3 Feb 2022 11:22:26 +0000 Message-ID: <3ba5d236-0406-636b-db19-9f8fdeeb2749@intel.com> Date: Thu, 3 Feb 2022 11:22:20 +0000 Subject: Re: [PATCH] net/enic: adjust memory check and use in proper order Content-Language: en-US To: Thomas Monjalon CC: , "John Daley (johndale)" , Weiguo Li References: <2530593.7s5MMGUR32@thomas> <1882543.fIoEIV5pvu@thomas> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1882543.fIoEIV5pvu@thomas> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::18) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37733c19-5303-4f0b-442f-08d9e70774cc X-MS-TrafficTypeDiagnostic: BY5PR11MB4386:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:660; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uxrUs/Gg/EyKPIXzRTVe+dJwD1+YU+q9IVtClz61884jWmvLOoRwMwDtP8FXw0V+TNkSd8W/sYjoCGpyQmaClh4nNxl7LXBphbL9iNZ4/RE4DSjAjaRp9K2vjcL26faqqijo3PP92BQps7jzxmf+dmYqvm/Q9Nd7M1P8dqqvMoPsrQeuPvPpSoDsQHrDqMDN2IktNfMIxZgX7PeVJYlEYRvxW48yEOepTBIW1qv+ycbTDQVYy4ld1theVSOfW43I/47P9L2t8FcuD8FbCL+Fl8p7XY7zg45ES1uvgpiOOgRNwphuR7i3/V/lqBhwFnHFnQ0fYmjob4hGzwbdFcgMSZb95n4Mft/X3s500s+mbncOAXhWOVfA4YQsxYNe6bso8T4Z8F/PBjiX2TJeUAx00lMfLwiMO2xZaIIg06ZBguXrbDJFPtCIJJF0SOHMotmm1AQKJbx6OAH8WomxTDJn7+r2ke2j6AhfMEpsWhXKYMTo9xGhYrL/tgXZ10WjFgIk5CSdxcirD3iEIGclTzKovNMiBqB0evPVE8/Rk6B56IE1gnyaT/RdlV3pbg/3qC1hxJBwvwc/xJBYMFbyLOYvE5Ulptp4utT2UW7Qv0pX3X/puLcEegjbTQ67KI6poKf77UPmPHfJX/9ApaDIiUa2UqHprLHDYFJydaQ94+WOaylSHfEmAVXA5ENw5F2ePIKej6ZZP3y9jwLuPx6hfbkYtvGC/jqVBI6w6TdcjiV5HPCFsHUzgxl3WlPfLXEKvaMZ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(26005)(186003)(2616005)(82960400001)(31696002)(38100700002)(86362001)(66556008)(66476007)(6486002)(4326008)(508600001)(36756003)(6916009)(66946007)(54906003)(31686004)(8936002)(8676002)(316002)(2906002)(4744005)(53546011)(55236004)(5660300002)(6506007)(44832011)(6512007)(6666004)(48020200001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmhGTHJvcnlWZk9qQUFqQjhwaHBQVlc4RTVVWmk5QUk1VWNkd1pqNmE4cEh6?= =?utf-8?B?LzhWZXU5RjBpcGluNmJtZ2duWW5VY3BXc3hsYS8rVGRVdHdSbVFuQVRhbzVX?= =?utf-8?B?bFdOYnNJNkgvYU5GQjVtRFlyM0JSUVpXc2JQNlBGaExNMDhORXkxMFdVMC9k?= =?utf-8?B?RHFxZkdieXI0TzdEQ2xTSXl2MFl2dGVCR0tMWEl2T3RHZVBWb3o3VGxuRXRS?= =?utf-8?B?cDFpeStwa25EOHc5czdxUmFiQjNBbVJUcU1talZvYXVkMnV3YzhMaWlySWI2?= =?utf-8?B?anM5KzFmNUszWmxlbWJidEJmZmZDSkNuL09WMzUvS2x4V0FHNER5MU1lR0lD?= =?utf-8?B?TjlLUENpNEgyRTUvcGlPa08wZWVQT3VCNllPWGs0aHF6WnFnekdmYnFTV3Ur?= =?utf-8?B?TFNkdDFLQ3kxYzlPSVMwUExsUVl3bS8xMFhGbzJmZGlkaUdqbGpyQ3FQVlkr?= =?utf-8?B?M0hzSkVWRWxXRkxNWXR4VXRPRWFtbVVpZCtoY3hnUmd4REdHVWc5QkpvU0pL?= =?utf-8?B?NkFibVlTYTFNMDZIdU9zV3pybUNVL1YrdWJIQWhobWp0bzVvTVlsV0F1ZEpS?= =?utf-8?B?TkNLRE5aN2x1UHBES056akhPYlBTeGhVbFY2TkIzd3dGMHZUeGVBUndGYUY2?= =?utf-8?B?aXVuUjZCZEdOVVdBY05MRGpISlY5L05Nbkd0cDE4ZlFTMUR5WXY2UzQvdTNh?= =?utf-8?B?a0hOT2lRKzNTVGpSZUNWOXQxaEtoTHozMXdHYkdKK2tpcjU3WG9BTWR0RGZE?= =?utf-8?B?Yy9mOHBvcENMY0lvZUQ1bFJ2Q0poRzFCQ0xJSFR4b3M5MUdhZDBZQlQvS0tq?= =?utf-8?B?SXRIOFlXUXJIdVhaeHdTbDMyVW5RTkNDZSs0Tkw1VW1HdjNlSlNvN1d1eW1X?= =?utf-8?B?YXc1aVNCSU43SzVaRVBldzFxd0ZNM2ZjT2d4UHB6V1hNNmJVWnNua0Z2dVhl?= =?utf-8?B?dzNYVFE0R1hDUEpEbjdibXNIcFdPdVp0Qlc1OTNQMlpSV0l3TmVGd1RhNXZI?= =?utf-8?B?ejB1R1lIUUNSb0l1UzVReXlxZUZoL0VhOUJ1bGh3NmJCd25Dc1ppVk43RDNw?= =?utf-8?B?QzBINHVIVGlOUVNaNEdwd3A5YXBnWGI0cld6UUNTbGo1OGswTFlOS0MvMWZ1?= =?utf-8?B?TXhuUzVVQnJmUWp3b3lLU3kvMmVrSUJrL0t1NStGY2V2TUZxL0tGZmFLbGtX?= =?utf-8?B?ZmgydlJ6NVhyYkZ5NEVVVjJjQXpaajdldTdMYjk0dHZ6K3NqdUJ2SjhZZk0x?= =?utf-8?B?SjdFUEJGeGZwZDI4em1XZitOTUd3Nk16RmZ0TFBKNERlUUZGOXN3R292RDUw?= =?utf-8?B?eWxVcHU4eEhYaXliaXBMMnUzd29KWTNiU0VtSDh0NGlUVkt3NzRUcHNQT0tw?= =?utf-8?B?NFRhTXZLd2o2SHBWNGVRWklwOWNVQkZMMS9yekFSTHE2cHNQVHVBcktHemh6?= =?utf-8?B?U3RJUEd3RnYrRFZkelVTVTR3VTFza3hiYWZrMnAxQXRMVmdseGU1MXJHaWNL?= =?utf-8?B?cE0rM1c3elZ2U3V0MUtaM3RHeEFqN2NNL2doQTRaQnpDRExwdkxZTWpRRkNz?= =?utf-8?B?Y0t6dlluZ1VGcEYzdWcvd2ZENm84Z1JzRklYZW1NRFZ1RGt2MkN2S3JaQnpO?= =?utf-8?B?UGVvYU5kdEx0WmFWYUI5NTBiR1pTODd3VTJtL29mWGNoTThwekExRGpkL0l3?= =?utf-8?B?WlpjT3h4SXdKemNmRU5MNlZzUVVjWE1Mek93M2RUMnphL3UyNUxXSmFLSGZG?= =?utf-8?B?cExYWEt4ZXBUNkRUbTBrelZvV1Z3cEZhU2J5dnVsalBEbG9GMG1mc2lzVHBv?= =?utf-8?B?aDF6a3dGRU12UStkNkx4bUh5L3djRG5hczhwc2IxeE0va3NLcHdIM242MXVs?= =?utf-8?B?ckNzZGo5NytmYlR5RGs4SkhwRGkvTjFCSUVNbWtKR0dUdFFncXlhWGdSa1lm?= =?utf-8?B?QnFwdUQ3L0RyendCSUVPdjV5Y3h3WDY2Wko0N3ZCZDJId3B2dXY5TDVDN01j?= =?utf-8?B?REdudFpjWUQ1aW1EZUxNVHF1cVZQUzlxOTQrOEZjbnpOQXNvaHpXdUtIU3pj?= =?utf-8?B?bVJVYzIvUHYyMmVJVjBUYmIvaDMvOHVITVhWSnZPTnVuK2ZOanJxemUvK2Js?= =?utf-8?B?V1hDNVYxNVVhUzYzdmdhTllxeG9SYnF2cCticzlIcVorYWxpQzVHQjJkL25L?= =?utf-8?Q?JRVi8c1UHuLrojy0Simt5OE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 37733c19-5303-4f0b-442f-08d9e70774cc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Feb 2022 11:22:26.2165 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9G8DhzTcsNUZchtoDirQFssEnJsFDdnj0lWPXwiYI6aC/ALt0rqvgrR64LeetS0AhZ1/kXdXPwbutwb2dzKyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4386 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/3/2022 11:11 AM, Thomas Monjalon wrote: > 03/02/2022 11:57, Ferruh Yigit: >> On 2/2/2022 11:50 AM, Thomas Monjalon wrote: >>>>> Subject: [PATCH] net/enic: adjust memory check and use in proper order >>>>> >>>>> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") >>>>> >>>>> Signed-off-by: Weiguo Li >>>>> >>>>> Reviewed-by: John Daley >>>>> >>>> Applied to dpdk-next-net/main, thanks. >>> >>> Please could we have a little of explanation in the commit log? >>> The title says "adjust [...] and use in proper order" >>> but I see only a move of the check. >>> >>> >> >> Is following good? If so I can update it in next-net. >> >> net/enic: fix dereference before null check >> >> Move memcpy to 'ah->key' after 'ah' null check >> >> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") >> Cc: stable@dpdk.org > > Looks better to me, thanks. > > Updated in next-net, thanks.