From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 7101A72FB for ; Fri, 27 Apr 2018 12:02:54 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0979081A88C8; Fri, 27 Apr 2018 10:02:54 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 13011AB3F7; Fri, 27 Apr 2018 10:02:51 +0000 (UTC) To: Arnon Warshavsky Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-11-git-send-email-arnon@qwilt.com> <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> From: Kevin Traynor Organization: Red Hat Message-ID: <3bc1745d-c294-4059-db60-b40387d89378@redhat.com> Date: Fri, 27 Apr 2018 11:02:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 27 Apr 2018 10:02:54 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Fri, 27 Apr 2018 10:02:54 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 10:02:54 -0000 On 04/26/2018 10:57 PM, Arnon Warshavsky wrote: > > > On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor > wrote: > > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > > Actually the return value did not change, only the warning text did. So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly that patches with rte_panic/exit should flag some warning message, but the maintainer should have final say. I don't think failing checkpatch is the solution for that. > I would rather keep the word 'prevents' as an intention declaration that > puts the fact that a panic is undesired first, and the technical ability > of a maintainer to allow it second. It's only words, but to me 'prevents' does not indicate that it is undesirable - it indicates it is not allowed. > This is just in terms of how one positions the usage of panic. > > > > > > > Seems to drop the patch name if it finds a match > > > Not sure I understand what you meant here. Can you please elaborate? > Sure, I made a patch with an rte_panic and ran checkpatch on a bunch of patches. It gave me the name of all the patches except the one with the rte_panic. > Thanks > /Arnon >