From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39EE6A0C43; Thu, 23 Sep 2021 16:00:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F2C141263; Thu, 23 Sep 2021 16:00:28 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 88B8B41260 for ; Thu, 23 Sep 2021 16:00:26 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="221958037" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="221958037" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 07:00:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="653666835" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 23 Sep 2021 07:00:24 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 07:00:24 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 07:00:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 07:00:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 07:00:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZIs7Vy5NGVMjv/idDNL9GmnTWvi1SUVCvRoXQar5gpWkd75jq9oCi52G4qpI5/nKgN8tbPRTKFDqUI48mGsornJ2blcqXyAYRqao3NfFX9FrvFsQ4JO7OhPvaxZzn1+vfGzUjKulixKVfVo4Lk7M0HBnI+PNlTeaN7riYMD8OGe7qVYfxe+Htp8oWKFpB67X9M2Xk9I+gEAFCejM6s4gqGiMUftUS/1Fkb75hHpknYu+sSizmccFEqL9rZjOoH4h7ZCNLTwzj7+2t8FXiIWCYf6GBoVrUwS3tv7LXK7OFS1+nBygNdYDNV9A+r9jddMPbBoyf7cfFJRO9PEbs6Y1jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sNIuRTBcu5GsBeU9QIzboVQms/PCwCJq8vmQyn/tPCw=; b=L1CFcY7kKz5b+/wUk+KXC96Kz9QUS3nUYlQPScNR92UfkN6aOPCMWr8URbM8yPVZe0/q3uZD0Qk/yLX/EiGWLl0PzC1sSGRS7qu/90znFkkrZeKhwYdb6YAsKPmAb8KcUjpr+wpcmRrrXahm3Sp7KqMdgwuETU2oc9jUxU1jcqYkH3O/SvXvu8EdxnaIi+TVrtM4mpkIcugfKDJP0KrJBJyrof6/3YJ8a45JyyAq8D37us1Qaovwo4v53qIJV2ljzb+EP0kv9gtUlyOIDuu4lo98Xw1dHvsbf9Ah+hB1aaBRB2ypF1XjhBTES9GD9/2cDouUmD0QBNwFhwaLQbRzXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sNIuRTBcu5GsBeU9QIzboVQms/PCwCJq8vmQyn/tPCw=; b=D8InkbTRZsxo+JAa5j14npVmTyw4A+puW+kMcLxghpYr1RM2Z84EddW/L/GqXHobsiRsXAVofJdj3RP2Lx1LXHwCOtaxnN1rqq1ULoHsvQKuNai0qa/jf3L7drgJ23N106LPWFCRDZgde1yr9P+oRXEcq7+3HPOsM5G1rjLWN50= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5055.namprd11.prod.outlook.com (2603:10b6:a03:2d9::10) by SJ0PR11MB5023.namprd11.prod.outlook.com (2603:10b6:a03:2de::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15; Thu, 23 Sep 2021 14:00:21 +0000 Received: from SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::78d4:6f82:aa87:c271]) by SJ0PR11MB5055.namprd11.prod.outlook.com ([fe80::78d4:6f82:aa87:c271%7]) with mapi id 15.20.4523.018; Thu, 23 Sep 2021 14:00:21 +0000 To: fengchengwen , CC: , References: <20210910172737.2561156-1-kevin.laatz@intel.com> <20210917164136.3499904-1-kevin.laatz@intel.com> From: Kevin Laatz Message-ID: <3bcf7db1-041d-c179-e7c2-7a28adbd93aa@intel.com> Date: Thu, 23 Sep 2021 15:00:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DBBPR09CA0005.eurprd09.prod.outlook.com (2603:10a6:10:c0::17) To SJ0PR11MB5055.namprd11.prod.outlook.com (2603:10b6:a03:2d9::10) MIME-Version: 1.0 Received: from [192.168.1.15] (93.107.194.240) by DBBPR09CA0005.eurprd09.prod.outlook.com (2603:10a6:10:c0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Thu, 23 Sep 2021 14:00:20 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cdf5762-54af-40ec-77d6-08d97e9a7b65 X-MS-TrafficTypeDiagnostic: SJ0PR11MB5023: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rRJA4RaM2+e+03TI0uasvAxDo826WdrQZ3G8woiae8nwNtjXrBBuNrj2I+Tw+V59EMNmg8p3j8cM5Gm+Kx1IREAjmlJk3uyt64qmexxtLhIAIPKuw+ciL/Bg55TIHnsgUA8u6dRVfZbRtv6oQOoXM2/5N7T/KQKO1y2aNE/PMdCFdYq39yj5koe3gj6A9yCXVuoLVax8qwtefiDEq++uqqliUKeuPq3HVIHB6P5O1APGA9bSnClf8ulNQK/MwBgZo9OrWvTv9/cXR1cUevKiDiqz56Adzy3ViM/kT4RdSVdlLXC/EV3Lbmn2Pta6dT1ZRcRX1bXGbM0UMM2jw/Ho42F2ratRxbeiAETQaiLLs3r/rXNOBpin/b3eVqwifoM1+4yZhDK9yl8/QPBMFT4vkbVN51Tb2QnwewNS32micaFjBYAWZskTZ5sQx1fNiqjdQWNclbSzYPxFhZ0leuLue7wCyxyXXwEcXukogsjJiTq2kI8nyjI6uTIudm/ZjlwjDMHVb3gz6BvMjpdWcGyLrA2r4XVV2FAJ6BWp7AjQXg61S+sJcu6e8gx6Eh7FqfM1me5CcUSo8sLjxXTwc8JsnggrLCgQVbc7+ky7cyfdGCvbGmJBoqnv1ERw5YCXtXHSwrvjnKZ+tgQQKddKdy+gfP701wtnzWA7Hr97g0D26kV77Gz7eQyFu/8Oo+rQc9sybE/E/jT2ERnYcZRrEhODXkNzAshREXx/YPLNBXtL6kY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5055.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(26005)(186003)(86362001)(508600001)(36756003)(53546011)(31696002)(31686004)(956004)(2616005)(66946007)(66476007)(4326008)(16576012)(83380400001)(6666004)(2906002)(8936002)(6486002)(316002)(8676002)(107886003)(66556008)(5660300002)(44832011)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlZHRUhVRVR0MG9FbTVHRFIzYkoxM091QkFnV2pyWDJXTDRNaloxSndCb29M?= =?utf-8?B?SkMzN2xyUlBNNjNzUWZHNE04bVBrdXNNN05ITTRaNnVwZTVaSUgrSFdHbTZO?= =?utf-8?B?M1NWQjJIaGRJSkpFRUUySCthQkFHamQ0cjFoN0lyWmhmKzZaUTFuWUJScTlJ?= =?utf-8?B?cU1DMkVCcFROb1NjM0dmZG1zWm9CcERoVVRhTmdJMzRFSEtkcGVlN2Z5T0RL?= =?utf-8?B?VUNBU1ZPWm9mcURaejhheURKazJFQ3c3aDlkc3lCaWgzdFZjdUtXTzFKalla?= =?utf-8?B?b1Rva0RtK1pmc3NvSHZSR2QrMDIvQnZvVFFGblg1NzdVcFZEK0VpUXMyd0Vr?= =?utf-8?B?TWhpQ2tiUGk3MjlYS25vNGg0c0tqY01FM1ZMdGtXaWVQVEg0bmlSSWp6Lyt4?= =?utf-8?B?MGxYRnljZEJsdGVUaDFBSjE0NmdkdGdkNVhEdVB6d2E5SFBFZGsvVkhRS1F1?= =?utf-8?B?M2Q4Nzg1bEJnTUdqTTM5RWtzbm14Qm5wZXV3U1dQeklnejNJZ1FVUlVjNnNy?= =?utf-8?B?ZEFRNjVaSnZpaU1uQ0ZQd2pDM0l6Y1RFZFRjR1pMcTczNVNhUHgwRGtBU2Qx?= =?utf-8?B?UUNyUnFFTitibjEvTXpXdm1kVHhmMDZqajlHSWtKbkhySm45TWRRZjVxUVo2?= =?utf-8?B?MVg0a2FTUzg3NmpEcW5OekxRNVlwREVOK1h5eGcwR201L1FPYXZoMGJvWWJR?= =?utf-8?B?YTh5V2RIU1ZzVS9Cc3F5dHMvOEJFS01sL0dYU0dDQU9pVFJLRzRiOXhLaldr?= =?utf-8?B?MU5CeU02cERiOXBWZVdyYk9DRDY3VExtMXI0cWs4YktxMkxCaThta3ZaTmFm?= =?utf-8?B?VW5tRE5ucHo3c20zVUlQbk1vL25aUDFVWkVJN2dYWlJHSllmOVNLenUxdno4?= =?utf-8?B?RTljT0pwVjEwV081YnZlWk9QN0Q0bUdrMHFKbVdmVGxxSG5DbnYzS2Y0MGx2?= =?utf-8?B?aWtucmw4Vk1RQTJiVVo5WVhLcVNra2NhWkYrejZZRU5oL0hBMTdJOHhxb1Nt?= =?utf-8?B?L212UnpaTXJzSkw5M0VFdnB0bjRPeENnNnYwWkZTeWRkeGxFQ0VFSWxmZ0hI?= =?utf-8?B?NGZQcmNOQlZXeWprbkFsMDJKVEdDNm5HSG9xcUZyVUkzOHVtUmJLdzBHUGtx?= =?utf-8?B?RmZRV1ZkQWFyd0F4dWl4MUJOaXorRFhaSjJDVFFXakxjK3prRzcrNTdLK1RW?= =?utf-8?B?V3M3d0FQWXRGVldWOTE1bVdmNnJMTmozNE9RRWJwWmtqa3JnL3FKT1FCL3dR?= =?utf-8?B?NDlIQ1ovWE9vMElBVit2T1F1NW0wbE4vT1JWbldsR1N1VE1ndk02SDlVbWZm?= =?utf-8?B?R1JpWStJMHBhR092VVNVYWhIZlhIVVVVb0ZGTXkydVRpakVnUW5xRHptY1dH?= =?utf-8?B?b1A2Q1grbWYwTTB2NFFlMVNEQlgyUy81UVRBVi9iSXJBQjM1NFF1VlhQd1U3?= =?utf-8?B?aDJlNFRsNlBrRDFmZC9EOEI4emYxbHRzZW5yMElWdzNYVElmc0xrR3dxZmYw?= =?utf-8?B?allpVHJjcVJwOTdOVTFEK3FPQnVNNkJ5REVIUFRXSitTRzFhWHJwc2dFMXhp?= =?utf-8?B?d0dTZHRuOW9mOHFkcFpNT0ZDRXRlMzU5aFBtU2xSRGNvRlkvVUFyN0pYZkJq?= =?utf-8?B?MVlGM2s4VUhQalFEMjl5WGp6SzB5TVF0QnRFRVNtT0tPamdjYTJnNWU5bEJC?= =?utf-8?B?bEgzUE9LSmZ6a3N6dVdhNTR6ZXBoRDBDNUJXWDVZT1NFdWxGdURDcnZINTdW?= =?utf-8?Q?iY10E/mi9j7uBwgofmmxcDVm/FFtbq1y6HmYGNm?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdf5762-54af-40ec-77d6-08d97e9a7b65 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5055.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2021 14:00:21.1071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rmcpeBJdON9jbId6Fi3/qjpL1FL1hxfTrUVYwu+GJW7Jb/4DnNOe9vrSAvQ9zrdJQnJj/tZj4qFF9MKe4ahZxQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5023 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/6] port ioatfwd app to dmadev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chengwen, On 23/09/2021 14:53, fengchengwen wrote: > Hi Kevin, > > Can you add the following functions? > 1. Add dump dmadev which trigger by signal, like: > ... > static void > dma_dump(void) > { > uint32_t i, j; > > if (copy_mode != COPY_MODE_DMA_NUM) > return; > > for (i = 0; i < cfg.nb_ports; i++) { > for (j = 0; j < cfg.ports[i].nb_queues; j++) > rte_dma_dump(cfg.ports[i].dmadev_ids[j], stdout); > } > } > ... > static void > signal_handler(int signum) > { > if (signum == SIGINT || signum == SIGTERM) { > printf("\n\nSignal %d received, preparing to exit...\n", > signum); > force_quit = true; > } else if (signum == SIGUSR1) { > dma_dump(); > } > } > ... > signal(SIGUSR1, signal_handler); Yes, can add this in the v3. > > 2. Controls the output frequency of print_stats. currently fix 1s, hope could control by parameters. Are you asking for a function to control this? It would probably be better as a cmdline option IMO. I can add this in v3 also. Thanks for the feedback! > > Thanks. > > > On 2021/9/18 0:41, Kevin Laatz wrote: >> This patchset first adds some additional command line options to the >> existing ioatfwd application to enhance usability. >> >> The last 3 patches of this set then port the ioatfwd application to use the >> dmadev library APIs instead of the IOAT rawdev APIs. Following the port, >> all variables etc are renamed to be more appropriate for using with the >> DMAdev library. Lastly, the application itself is renamed to "dmafwd". >> >> Depends-on: series-18960 ("support dmadev") >> >> Kevin Laatz (3): >> examples/ioat: port application to dmadev APIs >> examples/ioat: update naming to match change to dmadev >> examples/ioat: rename application to dmafwd >> >> Konstantin Ananyev (3): >> examples/ioat: always use same lcore for both DMA requests enqueue and >> dequeue >> examples/ioat: add cmd-line option to control DMA batch size >> examples/ioat: add cmd line option to control max frame size >> >> MAINTAINERS | 7 +- >> .../sample_app_ug/{ioat.rst => dma.rst} | 114 ++-- >> doc/guides/sample_app_ug/index.rst | 2 +- >> doc/guides/sample_app_ug/intro.rst | 4 +- >> examples/{ioat => dma}/Makefile | 4 +- >> examples/{ioat/ioatfwd.c => dma/dmafwd.c} | 586 +++++++++--------- >> examples/{ioat => dma}/meson.build | 10 +- >> examples/meson.build | 2 +- >> 8 files changed, 380 insertions(+), 349 deletions(-) >> rename doc/guides/sample_app_ug/{ioat.rst => dma.rst} (73%) >> rename examples/{ioat => dma}/Makefile (97%) >> rename examples/{ioat/ioatfwd.c => dma/dmafwd.c} (63%) >> rename examples/{ioat => dma}/meson.build (63%) >>