From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DF5EA00C2; Fri, 6 Jan 2023 10:14:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90D994067C; Fri, 6 Jan 2023 10:14:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1C410400D4 for ; Fri, 6 Jan 2023 10:14:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672996439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tBqGvEBYAsHi6GuHN0I1TRbBHOKoR/9W6n/NaJdgp6o=; b=RC/Ubl+uWD+DyATPiYKo53PyR6NZOSEWwEWWSvjCmx4bn05kMhXc0YTvsSZCW4W5xr+56N 1B5DPPAZ18QQcnWsKeXG9HnoTutPdXUKKuxzFsL2AvsRq1yWvbAM1t+cMGuXMB/sxdg4Df BMWARPP0v5L655+SHj3N8DQd2ZvX6Ng= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-313-8_3Tgm4-PiWgNoy5SzY7dw-1; Fri, 06 Jan 2023 04:13:54 -0500 X-MC-Unique: 8_3Tgm4-PiWgNoy5SzY7dw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A804B8533AC; Fri, 6 Jan 2023 09:13:53 +0000 (UTC) Received: from [10.39.208.15] (unknown [10.39.208.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55872492B00; Fri, 6 Jan 2023 09:13:52 +0000 (UTC) Message-ID: <3bf97385-2a1b-f396-4bbb-a39c9f4f9d62@redhat.com> Date: Fri, 6 Jan 2023 10:13:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 5/7] baseband/acc: acc100 use define constant To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230106054443.199473-1-hernan.vargas@intel.com> <20230106054443.199473-6-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230106054443.199473-6-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/6/23 06:44, Hernan Vargas wrote: > Use define constant ACC_HARQ_ALIGN_64B instead of hardcoded number. > No functional impact. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index 1ca95f4440..4ac8061ebd 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -1392,7 +1392,7 @@ acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, > harq_in_length = RTE_MIN(harq_in_length, op->ldpc_dec.n_cb > - op->ldpc_dec.n_filler); > /* Alignment on next 64B - Already enforced from HC output */ > - harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, 64); > + harq_in_length = RTE_ALIGN_FLOOR(harq_in_length, ACC_HARQ_ALIGN_64B); > fcw->hcin_size0 = harq_in_length; > fcw->hcin_offset = 0; > fcw->hcin_size1 = 0; > @@ -1435,7 +1435,7 @@ acc101_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc_fcw_ld *fcw, > /* Cannot exceed the pruned Ncb circular buffer */ > harq_out_length = RTE_MIN(harq_out_length, ncb_p); > /* Alignment on next 64B */ > - harq_out_length = RTE_ALIGN_CEIL(harq_out_length, 64); > + harq_out_length = RTE_ALIGN_CEIL(harq_out_length, ACC_HARQ_ALIGN_64B); > fcw->hcout_size0 = harq_out_length; > fcw->hcout_size1 = 0; > fcw->hcout_offset = 0; Reviewed-by: Maxime Coquelin Thanks, Maxime