From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EAFB17CC5 for ; Mon, 31 Jul 2017 16:53:18 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2017 07:53:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,442,1496127600"; d="scan'208";a="113924206" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga004.jf.intel.com with ESMTP; 31 Jul 2017 07:53:16 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Stephen Hurd References: <20170729205409.3702-1-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <3c1219bb-552e-cca0-3ba3-516b20b2c939@intel.com> Date: Mon, 31 Jul 2017 15:53:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170729205409.3702-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix bug which could set multiple conflicting bits X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 14:53:19 -0000 On 7/29/2017 9:54 PM, Ajit Khaparde wrote: > Only set the vlanonly bit if vlan_nonvlan is clear. Also, allow the > VLAN table to be cleared when vlanonly is set. > > Clearing the VLAN table when vlanonly is set will stop all traffic > since it requires all frames to have a VLAN tag, and that tag to be > in the zero-length table. This is still a valid use case though, > and has been seen in the wild. > > Fixes: 36735a932ca7 ("net/bnxt: support set VF QOS and MAC anti spoof") > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks.