From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by dpdk.org (Postfix) with ESMTP id BAB60AAB7 for ; Wed, 21 Mar 2018 07:31:11 +0100 (CET) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 31A7D60C66; Wed, 21 Mar 2018 06:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521613870; bh=jZsyhSb6zPIexu78ADTZ3kXiiMZ9a2AiDHeHZsR29TI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=oL/zsTNU2fFaJX+/c0+7M1O5zizyYb2t0BnHXAIoS+s/IqTSKGzeO5qs35AC70Vaz 0qQ8VrCJ4x5HtDFRdxjzoH0J2pGkJ4nk0SWPZU1RMMM1LEg5AnJ7DYmetftYvbw4Pc HGWEd8zZZG5FHSK2fwHRpF7EWZuPg3QB+N9P5xWA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.43.33] (unknown [106.205.111.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: hemant.agrawal@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 69CF86025C; Wed, 21 Mar 2018 06:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1521613869; bh=jZsyhSb6zPIexu78ADTZ3kXiiMZ9a2AiDHeHZsR29TI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=is5CaiyFEIiJ3asVmo1WNNcYvS2bzlLyoOUPs4NO7CuSbKEiLc5e2v7yuqTuKUkpI oLfJn53phaQIGxBoNCHM+m5+1fiv3lD0+siOC5dY2p/jAdZKJ4+NyfWYeW7eYJVHvd w6KN2px5sXwU/chj0iO4U5P3qzojL/UzK0ymXALo= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 69CF86025C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=hemant.agrawal@codeaurora.org To: Shreyansh Jain , ferruh.yigit@intel.com Cc: dev@dpdk.org, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, akhil.goyal@nxp.com References: <20180312092547.18472-1-shreyansh.jain@nxp.com> <20180313054431.19556-1-shreyansh.jain@nxp.com> <20180313054431.19556-4-shreyansh.jain@nxp.com> From: Hemant Agrawal Message-ID: <3c88da66-fb3b-e41c-471a-812f115c792f@codeaurora.org> Date: Wed, 21 Mar 2018 12:01:04 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180313054431.19556-4-shreyansh.jain@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into dynamic logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 06:31:12 -0000 Hi Shreyansh, On 3/13/2018 11:14 AM, Shreyansh Jain wrote: > Signed-off-by: Shreyansh Jain > --- > config/common_base | 5 - > config/defconfig_arm64-dpaa2-linuxapp-gcc | 9 - > doc/guides/nics/dpaa2.rst | 44 ++--- > drivers/net/dpaa2/Makefile | 6 - > drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 30 ++-- > drivers/net/dpaa2/dpaa2_ethdev.c | 290 +++++++++++++++--------------- > drivers/net/dpaa2/dpaa2_pmd_logs.h | 41 +++++ > drivers/net/dpaa2/dpaa2_rxtx.c | 59 +++--- > 8 files changed, 258 insertions(+), 226 deletions(-) > create mode 100644 drivers/net/dpaa2/dpaa2_pmd_logs.h > > diff --git a/config/common_base b/config/common_base > index ad03cf433..64bdfbb73 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y > # Compile burst-oriented NXP DPAA2 PMD driver > # > CONFIG_RTE_LIBRTE_DPAA2_PMD=n > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n See the comment in PATCH 2/7 w.r.t usages of DEBUG_DRIVER macro. > @@ -322,9 +322,9 @@ dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, > > retcode = dpni_set_pools(dpni, CMD_PRI_LOW, priv->token, &bpool_cfg); > if (retcode != 0) { > - PMD_INIT_LOG(ERR, "Error in attaching the buffer pool list" > - " bpid = %d Error code = %d\n", > - bpool_cfg.pools[0].dpbp_id, retcode); > + DPAA2_PMD_ERR("Error configuring buffer pool on interface." > + " bpid = %d error code = %d", > + bpool_cfg.pools[0].dpbp_id, retcode); Can you try to convert this and others into a single line message? Regards, Hemant