DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Brandes, Shai" <shaibran@amazon.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
	Tyler Retzlaff <roretzla@linux.microsoft.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Schmeilin, Evgeny" <evgenys@amazon.com>,
	"Beider, Ron" <rbeider@amazon.com>,
	"Bernstein, Amit" <amitbern@amazon.com>,
	"Atrash, Wajeeh" <atrwajee@amazon.com>
Subject: RE: [PATCH] net/ena: revert redefining memcpy
Date: Thu, 12 Sep 2024 14:53:24 +0000	[thread overview]
Message-ID: <3c9a7743d29240ccace41a185d7f99ba@amazon.com> (raw)
In-Reply-To: <16f62350-896e-458c-bbb9-0ef3453883c2@amd.com>



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Thursday, September 12, 2024 11:20 AM
> To: Tyler Retzlaff <roretzla@linux.microsoft.com>; Stephen Hemminger
> <stephen@networkplumber.org>; Brandes, Shai <shaibran@amazon.com>
> Cc: dev@dpdk.org; Schmeilin, Evgeny <evgenys@amazon.com>; Beider, Ron
> <rbeider@amazon.com>; Bernstein, Amit <amitbern@amazon.com>;
> Atrash, Wajeeh <atrwajee@amazon.com>; Chauskin, Igor
> <igorch@amazon.com>; Michal Krawczyk <mk@semihalf.com>; Artur Rojek
> <ar@semihalf.com>
> Subject: RE: [EXTERNAL] [PATCH] net/ena: revert redefining memcpy
> 
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
> 
> 
> 
> On 9/12/2024 6:12 AM, Tyler Retzlaff wrote:
> > On Mon, Aug 12, 2024 at 08:34:17AM -0700, Stephen Hemminger wrote:
> >> Redefining memcpy as rte_memcpy has no performance gain on current
> >> compilers, and introduced bugs like this one where
> >> rte_memcpy() will be detected as referencing past the destination.
> >>
> >> Bugzilla ID: 1510
> >> Fixes: 142778b3702a ("net/ena: switch memcpy to optimized version")
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> ---
> >
> > Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> >
> 
> Hi Shai,
> 
> Did you have any chance to check/test this patch?
[Brandes, Shai] sorry, I missed this. The change will be tested by the upcoming Monday is this is fine.

  reply	other threads:[~2024-09-12 14:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200~bug-1510-3@http.bugs.dpdk.org>
2024-08-12 15:34 ` Stephen Hemminger
2024-08-12 20:53   ` Wathsala Wathawana Vithanage
2024-08-13  8:57   ` Morten Brørup
2024-09-12  5:12   ` Tyler Retzlaff
2024-09-12  8:19     ` Ferruh Yigit
2024-09-12 14:53       ` Brandes, Shai [this message]
2024-09-16  6:33       ` Brandes, Shai
2024-09-16 15:11         ` Stephen Hemminger
2024-09-16 16:06           ` Brandes, Shai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c9a7743d29240ccace41a185d7f99ba@amazon.com \
    --to=shaibran@amazon.com \
    --cc=amitbern@amazon.com \
    --cc=atrwajee@amazon.com \
    --cc=dev@dpdk.org \
    --cc=evgenys@amazon.com \
    --cc=ferruh.yigit@amd.com \
    --cc=rbeider@amazon.com \
    --cc=roretzla@linux.microsoft.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).