From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE335A0C43; Fri, 22 Oct 2021 08:44:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 637FA4068C; Fri, 22 Oct 2021 08:44:29 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6011240040 for ; Fri, 22 Oct 2021 08:44:28 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 41CBB7F5B3; Fri, 22 Oct 2021 09:44:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 41CBB7F5B3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634885067; bh=3sDeuOCcyu4vngt1NMXQSOoZpT1HwVm7jDPKzup6rig=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=j22RjhavcQXVKL2Ywc/qabN0eu4Y2cnQjghh1b15x63SEkYw7i/r995jSPQOvAtAG +TaA5M1+f9d+4/caJkVIVU0PRReWY1OiKYxzvTtbuyy+8QGE8M9bnGaf6oZ7pJPbwj C1j9zyAh9PiO+rh3qUfZWviTY8md63fPzD3SUP2g= To: Ferruh Yigit , Maryam Tahhan , Reshma Pattan , Jerin Jacob , Wisam Jaddo , Cristian Dumitrescu , Xiaoyun Li , Thomas Monjalon , Jay Jayatheerthan , Chas Williams , "Min Hu (Connor)" , Pavan Nikhilesh , Shijith Thotton , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Qi Zhang , Xiao Wang , Haiyue Wang , Beilei Xing , Matan Azrad , Viacheslav Ovsiienko , Keith Wiles , Jiayu Hu , Olivier Matz , Ori Kam , Akhil Goyal , Declan Doherty , Ray Kinsella , Radu Nicolau , Hemant Agrawal , Sachin Saxena , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , "John W. Linville" , Ciara Loftus , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Steven Webster , Matt Peters , Chandubabu Namburu , Rasesh Mody , Shahed Shaikh , Bruce Richardson , Konstantin Ananyev , Ruifeng Wang , Rahul Lakkireddy , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , Gaetan Rivet , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Srisivasubramanian Srinivasan , Jakub Grajciar , Zyta Szpak , Liron Himi , Stephen Hemminger , Long Li , Martin Spinler , Heinrich Kuhn , Jiawen Wu , Tetsuya Mukawa , Harman Kalra , Anoob Joseph , Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru , Devendra Singh Rawat , Jasvinder Singh , Maciej Czekaj , Jian Wang , Maxime Coquelin , Chenbo Xia , Yong Wang , Nicolas Chautru , David Hunt , Harry van Haaren , Bernard Iremonger , Anatoly Burakov , John McNamara , Kirill Rybalchenko , Byron Marohn , Yipeng Wang Cc: dev@dpdk.org, Tyler Retzlaff , David Marchand References: <20211020192352.2078742-1-ferruh.yigit@intel.com> <20211022020243.2932559-1-ferruh.yigit@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <3ca612c6-b590-981a-8a49-225fa1bab431@oktetlabs.ru> Date: Fri, 22 Oct 2021 09:44:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211022020243.2932559-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add namespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/21 5:02 AM, Ferruh Yigit wrote: > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > way. The macros for backward compatibility can be removed in next LTS. > Also updated some struct names to have 'rte_eth' prefix. > > All internal components switched to using new names. > > Syntax fixed on lines that this patch touches. > > Signed-off-by: Ferruh Yigit > Acked-by: Tyler Retzlaff > Acked-by: Andrew Rybchenko > Acked-by: Ajit Khaparde > Acked-by: Jerin Jacob > Acked-by: Wisam Jaddo > Acked-by: Rosen Xu > Acked-by: Chenbo Xia > Acked-by: Hemant Agrawal > --- > Cc: David Marchand > Cc: Thomas Monjalon > > v2: > * Updated internal components > * Removed deprecation notice > > v3: > * Updated missing macros / structs that David highlighted > * Added release notes update > > v4: > * rebased on latest next-net > * depends on https://patches.dpdk.org/user/todo/dpdk/?series=19744 > * Not able to complete scripts to update user code, although some > shared by Aman: > https://patches.dpdk.org/project/dpdk/patch/20211008102949.70716-1-aman.deep.singh@intel.com/ > Sending new version for possible option to get this patch for -rc1 and > work for scripts later, before release. > > v5: > * rebased on latest next-net > > v6: > * rebased on latest next-net [snip] > > +/** Maximum nb. of vlan per mirror rule */ > +#define RTE_ETH_MIRROR_MAX_VLANS 64 > +#define ETH_MIRROR_MAX_VLANS RTE_ETH_MIRROR_MAX_VLANS > + > +#define RTE_ETH_MIRROR_VIRTUAL_POOL_UP 0x01 /**< Virtual Pool uplink Mirroring. */ > +#define ETH_MIRROR_VIRTUAL_POOL_UP RTE_ETH_MIRROR_VIRTUAL_POOL_UP > +#define RTE_ETH_MIRROR_UPLINK_PORT 0x02 /**< Uplink Port Mirroring. */ > +#define ETH_MIRROR_UPLINK_PORT RTE_ETH_MIRROR_UPLINK_PORT > +#define RTE_ETH_MIRROR_DOWNLINK_PORT 0x04 /**< Downlink Port Mirroring. */ > +#define ETH_MIRROR_DOWNLINK_PORT RTE_ETH_MIRROR_DOWNLINK_PORT > +#define RTE_ETH_MIRROR_VLAN 0x08 /**< VLAN Mirroring. */ > +#define ETH_MIRROR_VLAN RTE_ETH_MIRROR_VLAN > +#define RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN 0x10 /**< Virtual Pool downlink Mirroring. */ > +#define ETH_MIRROR_VIRTUAL_POOL_DOWN RTE_ETH_MIRROR_VIRTUAL_POOL_DOWN > + > +/** > + * A structure used to configure VLAN traffic mirror of an Ethernet port. > + */ > +struct rte_eth_vlan_mirror { > + uint64_t vlan_mask; /**< mask for valid VLAN ID. */ > + /** VLAN ID list for vlan mirroring. */ > + uint16_t vlan_id[RTE_ETH_MIRROR_MAX_VLANS]; > +}; > + > +/** > + * A structure used to configure traffic mirror of an Ethernet port. > + */ > +struct rte_eth_mirror_conf { > + uint8_t rule_type; /**< Mirroring rule type */ > + uint8_t dst_pool; /**< Destination pool for this mirror rule. */ > + uint64_t pool_mask; /**< Bitmap of pool for pool mirroring */ > + /** VLAN ID setting for VLAN mirroring. */ > + struct rte_eth_vlan_mirror vlan; > +}; > + I guess above is an incorrect merge which returns mirror structures and defines back. Andrew.