DPDK patches and discussions
 help / color / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] example/vhost_crypto: fix incorrect fetch size
Date: Tue, 14 Jan 2020 10:30:21 +0100
Message-ID: <3ca778f2-eee5-bcf2-61bc-cda6e7271dcb@redhat.com> (raw)
In-Reply-To: <20191126095410.72395-1-roy.fan.zhang@intel.com>

Hi Fan,

On 11/26/19 10:54 AM, Fan Zhang wrote:
> Coverity issue: 343401
> 
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> Cc: roy.fan.zhang@intel.com
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
>  examples/vhost_crypto/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c
> index 1d7ba9419..5d80bcaca 100644
> --- a/examples/vhost_crypto/main.c
> +++ b/examples/vhost_crypto/main.c
> @@ -387,7 +387,7 @@ vhost_crypto_worker(void *arg)
>  				continue;
>  
>  			for (j = 0; j < NB_VIRTIO_QUEUES; j++) {
> -				to_fetch = RTE_MIN(burst_size,
> +				to_fetch = RTE_MAX(burst_size,
>  						(NB_CRYPTO_DESCRIPTORS -
>  						info->nb_inflight_ops));
>  				fetched = rte_vhost_crypto_fetch_requests(
> 

Could you please add a commit message to explain the change?
With just the patch context, this fix looks weird.

Thanks!
Maxime


  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  9:54 Fan Zhang
2020-01-14  9:30 ` Maxime Coquelin [this message]
2020-01-29 10:21   ` Zhang, Roy Fan
2020-01-29 10:19 ` [dpdk-dev] [PATCH] vhost/crypto: fix missed user protocol flag Fan Zhang
2020-04-07 13:34   ` Maxime Coquelin
2020-04-10 14:42   ` Maxime Coquelin
2020-01-29 10:24 ` [dpdk-dev] [PATCH] vhost/crypto: fix incorrect fetch size Fan Zhang
2020-02-05  9:20   ` Maxime Coquelin
2020-02-05  9:48   ` Maxime Coquelin

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ca778f2-eee5-bcf2-61bc-cda6e7271dcb@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox