From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 41B391B2F6 for ; Tue, 10 Oct 2017 20:24:23 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 10 Oct 2017 11:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,359,1503385200"; d="scan'208";a="161560890" Received: from unknown (HELO [10.241.225.83]) ([10.241.225.83]) by fmsmga006.fm.intel.com with ESMTP; 10 Oct 2017 11:24:22 -0700 To: Jasvinder Singh , dev@dpdk.org Cc: cristian.dumitrescu@intel.com, thomas@monjalon.net, wenzhuo.lu@intel.com References: <20171009125846.106218-2-jasvinder.singh@intel.com> <20171010101818.146523-1-jasvinder.singh@intel.com> <20171010101818.146523-6-jasvinder.singh@intel.com> From: Ferruh Yigit Message-ID: <3cbfbc77-7b4c-9b1d-301d-b28d97290a3c@intel.com> Date: Tue, 10 Oct 2017 19:24:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171010101818.146523-6-jasvinder.singh@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 5/5] app/testpmd: add traffic management forwarding mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 18:24:24 -0000 On 10/10/2017 11:18 AM, Jasvinder Singh wrote: > This commit extends the testpmd application with new forwarding engine > that demonstrates the use of ethdev traffic management APIs and softnic > PMD for QoS traffic management. > > In this mode, 5-level hierarchical tree of the QoS scheduler is built > with the help of ethdev TM APIs such as shaper profile add/delete, > shared shaper add/update, node add/delete, hierarchy commit, etc. > The hierarchical tree has following nodes; root node(x1, level 0), > subport node(x1, level 1), pipe node(x4096, level 2), > tc node(x16348, level 3), queue node(x65536, level 4). > > During runtime, each received packet is first classified by mapping the > packet fields information to 5-tuples (HQoS subport, pipe, traffic class, > queue within traffic class, and color) and storing it in the packet mbuf > sched field. After classification, each packet is sent to softnic port > which prioritizes the transmission of the received packets, and > accordingly sends them on to the output interface. > > To enable traffic management mode, following testpmd command is used; > > $ ./testpmd -c c -n 4 --vdev > 'net_softnic0,hard_name=0000:06:00.1,soft_tm=on' -- -i > --forward-mode=tm > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu > Acked-by: Thomas Monjalon > > --- > v8 change: > - fix compilation warning on uninitialsed parameter > > v7 change: > - change port_id type to uint16_t > - rebase on dpdk-next-net > > v5 change: > - add CLI to enable default tm hierarchy > > v3 change: > - Implements feedback from Pablo[1] > - add flag to check required librte_sched lib and softnic pmd > - code cleanup > > v2 change: > - change file name softnictm.c to tm.c > - change forward mode name to "tm" > - code clean up > > [1] http://dpdk.org/ml/archives/dev/2017-September/075744.html > > app/test-pmd/Makefile | 12 + > app/test-pmd/cmdline.c | 88 +++++ > app/test-pmd/testpmd.c | 15 + > app/test-pmd/testpmd.h | 46 +++ > app/test-pmd/tm.c | 865 +++++++++++++++++++++++++++++++++++++++++++++++++ Testpmd documentation [1] is missing, can you please send a separate patch to update it? I can squash it later into this patch. [1] doc/guides/testpmd_app_ug/testpmd_funcs.rst