From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78400A0032; Mon, 15 Nov 2021 12:16:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E059B40E01; Mon, 15 Nov 2021 12:16:10 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 4903140141 for ; Mon, 15 Nov 2021 12:16:08 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10168"; a="319632441" X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="319632441" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Nov 2021 03:16:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,236,1631602800"; d="scan'208";a="585235570" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 15 Nov 2021 03:16:07 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 15 Nov 2021 03:15:59 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 15 Nov 2021 03:15:59 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 15 Nov 2021 03:15:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OvMWiXQNnoFi2mOZNBW+WsFgRwZWK3FMRAHobF4lT8dFc1NJw4bthHBBLHfcjiIw2cmW6UTvt7famgyWu+M/U0ROg/C4g8QoGv6XEf3yJyv3S/yKmm9tkWCWHSgj8L69zTBdqim49faeJzgTvTvR1vPNaj8pXztAEPNODEdTzrUurTJ+2WgzlcX91iexD6sHDWZzoXzXJFGhUs4maGHefNkpFwA5GPAjs6O2hu6BgoBvXZpKa0FltwESjJOdImuXu1m4+D/E0a280ZhWuUKilq5ewCWde4WOebS1GZ0wjAJNXE3BfAgVawTLhOG6H8kGjS+Onb4rgRTOvGdiUx3x8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tXQXRYMDypcsxwa5ursUTVt3DcVlEcBlr42MKRIkGgM=; b=VIhSdd9iQBDb8PRo0kQ+g9ieWxN7wBs7Z441Tl1RjabLO+/7ODZ5ApoI0EhRyidOWg1xWQCjdNLy/C3uF56TuyGEA3jdcdSny2FWINggC3xCfxvs5vFP1BgLO18Y+mDEntWA42cjZNm9UpcMvI+gJbpvrVQgOlON52Hioc+up4VHF3cV75WmCUjWfmswZH5+GqmWw//osSSwtsv34oEDdjjU/BokISPn4Z8BNCCZ3xQRbOGTUfzzVX4tE1NRYTj4OUipHbhvPmchrXuh8faoG6sTLwEs7rm69M6ib2e9SUd6YI7fZFJrbQGgrAZzBtfbOiEdir5sgPD56Sfr1PIs8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tXQXRYMDypcsxwa5ursUTVt3DcVlEcBlr42MKRIkGgM=; b=JRshxwnG0bSFl8mxSkWKO1MMNTiy2TzbZrsgoxV6la3whNjuQQvwIejEXY91Ut65PmV1XSCP14/78TLFJc0J0KACVyHsGf1gCHNpYhoeka/fg7A/rF9K9S9Cgi4SmnztOYqlV+0OhEgCYgXPTzetppWGtSykqCblAEo8gqDb8Cc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4840.namprd11.prod.outlook.com (2603:10b6:510:43::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Mon, 15 Nov 2021 11:15:58 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Mon, 15 Nov 2021 11:15:57 +0000 Message-ID: <3cdf4bce-a022-92a1-164c-874ce4ed4863@intel.com> Date: Mon, 15 Nov 2021 11:15:51 +0000 Content-Language: en-US From: Ferruh Yigit To: Apeksha Gupta , CC: , , , , References: <20211113043141.18888-2-apeksha.gupta@nxp.com> <20211115071940.12942-1-apeksha.gupta@nxp.com> <20211115071940.12942-4-apeksha.gupta@nxp.com> <584e322e-3a8c-68d2-7e0d-a243f1f56909@intel.com> Subject: Re: [PATCH v11 3/5] net/enetfec: support queue configuration X-User: ferruhy In-Reply-To: <584e322e-3a8c-68d2-7e0d-a243f1f56909@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB7PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:10:52::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB7PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:10:52::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19 via Frontend Transport; Mon, 15 Nov 2021 11:15:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8860dfce-4f3e-446d-ef5a-08d9a8294c4e X-MS-TrafficTypeDiagnostic: PH0PR11MB4840: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wQG49fuw+kVi4ZauZYyrk+VNFox7Hqf+vHwcRE4vMRCNeKr1zUdklN/CVOSF1og81dSxgUCCjnuDxtlvQoGVgYP9zUmMBa9KeAWhA9F/TlHMYZ7odTyKXkM/kqzjfOJ8OHZw2ZrbtWAPnlUaDxoz5jqsNTT2NQBXBCYC4+hM19Z+O+hD5XbrCoC2jZid6FSErAB6WvZSERePgV6nau6J3BqVWyNRNtFCjmHRXlmW54Kk3t5yIHWwsIiBt7iIFqa6Im51GHtDEq6ie+0sQHIrlRRRAL7pBdf3OlJI6wX4PYZliCmqkCwHdTcQS597FPPWwgksP4821rvtESqvvOg8FqV73/8jp+2ygisrsjttuj3aXgLaCXCm1RAmRjzAjIO2FBUW7K2mDwoOqwPz6hhamVejcm3PUrW1owxLJ4VJcrUbfXUtIBA+VZO6L6RpU135tNil6dgNsH6IPxf30xiXHORlx4hRz8yuOKK1636V0q3/N9klA41fLVyQ/wTK5hE8ISpejC0Ug7hEhYt6XUl5++Fa5JxMD6LYURNDAWL8sSNlYkam6vHddCP+1YukKkAipfxo3e7GKlPG+42RplF2oLkw3haWe1iBwcwT4zf5ND616X0LPqudFh2jDRBS0q6VE2j4ZxrhVsLqHFpz9pHGLChMZ45zbeciJ6fyRmz/CUenlwOb7D+xnF6tWU1WL9KhKKLt0g/7VDDJzptNFyDEAg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(4326008)(82960400001)(26005)(5660300002)(316002)(956004)(86362001)(8936002)(2906002)(2616005)(6666004)(36756003)(8676002)(6486002)(66476007)(31696002)(186003)(66556008)(508600001)(66946007)(16576012)(44832011)(31686004)(53546011)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnBnMzJ1MWV6VjBFU1JuZlZOakVrRjlxekZwczFtWGk0QVA0Z1FTODR4K1Y2?= =?utf-8?B?Z2MvWWtPZXQzR2YyTWYvWmh0TzM2cE12d0xSNXJycWozVmkxQmVJa2g1TG91?= =?utf-8?B?MDIwYnJsQVpwNWZFOSsvbHhvcTRmR0J0c2hUUUNRbzd2SGd4M1RaTThGdWFS?= =?utf-8?B?by9lRGFIcnZKYzhRMGJDUUFZQlp6dUhBU0dmS2xLWmRiMzdWVm4wVWVYT25s?= =?utf-8?B?eXhBaXpDN2VWVk16NDlTYkRiQnYrakQ4T25FaGtwMlpHZm9CSGVOZDhXb2Zi?= =?utf-8?B?aUtJNk9MQ2NaYy84VG44K3p6MkZyMXIwWTdHTUtHMVJpdzJrWEsyTVN3U0xU?= =?utf-8?B?REZuWVNGNWRlZFc5WGlsSThyMFhBV2V6ZXJ4NHhldlJIdUVxVVlyekkwUUZM?= =?utf-8?B?bjhoZEcrdUl4ay9JelRYWG9mZlJBSHkxZ2pwTnpaOXYwOXIxQ2hrdzk4b0pj?= =?utf-8?B?aldNR3Qwd2EzYjBXWHZ5OXpoaWM4TmxsZmJkQVZoTlkyNEZhMldYNWY2cXFJ?= =?utf-8?B?ZEM2bUNicnhZeDVlaUVTMkp2RGtjTCswS3NKM2pPRkJKaForanpieGtwNzRw?= =?utf-8?B?OUJ2R0NIS08rYm01am1FU2FtVmF2MjN2RS90ZzlveGhjdnNVWlZ0dVRRaDR0?= =?utf-8?B?dk5VbDNBQjkrOXZMQm5pS1h2QnJwZGtObXlvWVNoRVAvZG9DYXFHYlhNVTRi?= =?utf-8?B?VXdwNUhhdThHNmkza1htQkM5djZuaFByaHR0YktleXNNcENXV3EzNGc3WXRJ?= =?utf-8?B?ZER5TVJ6dllEZVZNUjlYZXk3ZDhGaW9ZZ1BVMVZEdUZJemJ4WmRIRzFMU3I2?= =?utf-8?B?WnFkaUwycW5ob2tVMW9uUXI1a2c2RDAxY1dETUt3Uk1KQXQyMWJPRk1QWEJ3?= =?utf-8?B?amtNalljb0ovK25sdVgrL0Nod2RRQXhvVFNSYXBmTkNFRnZzZHIrajF5OEFY?= =?utf-8?B?bmtZSWdUMUQvMlhNMWdEZ0pjbFBiWHlZOXBlRXdvd3hBTzdrTGgxR0xyaEVO?= =?utf-8?B?R1lBQ3Bja3NCeEpJUXJVbElsbVBRMFcrczdtb2kvTklqMUdPUjJQczI2aHZo?= =?utf-8?B?cjBuazFNZDdrR3BrY2pvVFIzQ1lMYWR5NDFZZzhSOWQreHNmbHFSNE9tNFN2?= =?utf-8?B?U2JvcXpDTllHVTluczBUYURrYW1aWk1MYS8yT0Y5L1hBVXFjcnlaWlljdHdp?= =?utf-8?B?VHlyR3IvOEhWc3RyZm1ySS81bTgxbDdhREg3Szh1K1duc1VXTGgwQlJrUys1?= =?utf-8?B?RjQxY2N2RkhmZzZuTUR4enl6bWtPZUIzY3l5OGkvSHFveDI5enZIQStUWFhi?= =?utf-8?B?bVJEVE14Z3EvU0VxODRpQ1ErRUdScTl6djBLVVlJUVZoRDVORVBUbzd2VExV?= =?utf-8?B?SXVEWVVQNWZpOTVaWTI3Y1UwUTQ2V05nMXVrc1lvemYxTGM1M2VwdngxVVlq?= =?utf-8?B?REcrTGVrMHBPOXRDOTZvRGNVWmNabVM4bk9vdDVLbThvdGp1ZUlaTnlaREZi?= =?utf-8?B?bHdkaDBUY3k2QXBZOTFMbG8zZFMxaUtmMEtRdHdwcnVxZjdlWFdZOHhPbEJP?= =?utf-8?B?Zm9TcFYxdlR3WjNtTVZDWkwzQk9ZRk5SK0w2VmI1aEo4MTJXem83SFlqdG0w?= =?utf-8?B?S0dOT3JJWUFDWHBYc2FUeHpNN0FDa2xoTkR2akl0WTZ1c2RtMVA3R3dsWXR0?= =?utf-8?B?dlBEM3QxOVltdlY3S1BMOEZZUU50MzQ2aGhiTi9OUVhUdzVMTnlENVJLSXNU?= =?utf-8?B?bUIyek0ySjlzcVVYaGxraDVQZG5GdlVaT2FyTU5rNUVIRVdzVnMvTUp2SUdu?= =?utf-8?B?eVgyeXhqS1dtYnhhUTVjV0pKODAzTE5uaEE0aVVKYVYrWFFLelFBR3lEQ3lY?= =?utf-8?B?STlqVE9TTW1MRHArc3REQ1JUd2dpNFp0RUlhU2pHcUUza2lYY01XOXNMdHc5?= =?utf-8?B?U2dQN2Z3YjB2VXcvL3dCQnJxZjUwQ2ZpY050MFJtMjBkd05vSXdSbWZ3RFZR?= =?utf-8?B?Yk9HNm1ONi9yOXF4TUlZSlhoNHhaMFd1TjkxWUNJeGlqd2pGMnB6WGhFK2hC?= =?utf-8?B?SWhBOFBBR1E3ZXAzSkNTbG9ERHhoT0hmZU1MWnFnU0FGRHJ5NjVNaERKY1VE?= =?utf-8?B?TjZ5OGhLTkF5VGhjejZ4RThRS0kwUHJJZGVKaTg2YURpNzNiRjBOM3h4TlFE?= =?utf-8?Q?76waR6scxyNhnbtE9nbAv1s=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8860dfce-4f3e-446d-ef5a-08d9a8294c4e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 11:15:57.9153 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ki2AQL6QWjtV4bOs+UtPZxAMLQ20oZ/xOd6XXWgqt8DgYDtGvcDznlDI4ZtQRjKCHY0nOr0rz2/6Xkkv/UCmpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4840 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/15/2021 10:24 AM, Ferruh Yigit wrote: > On 11/15/2021 10:11 AM, Ferruh Yigit wrote: >> On 11/15/2021 7:19 AM, Apeksha Gupta wrote: >>> This patch adds Rx/Tx queue configuration setup operations. >>> On packet reception the respective BD Ring status bit is set >>> which is then used for packet processing. >>> >>> Signed-off-by: Sachin Saxena >>> Signed-off-by: Apeksha Gupta >>> Acked-by: Hemant Agrawal >> >> I put a comment to v9 on using 'fep->bd_addr_p_r[queue_idx]' & >> 'fep->bd_addr_p_t[queue_idx])' 64 bit variables as 32 bit, can you please >> check it? > > hmm, 'fep->bd_addr_p_r[queue_idx]' & 'fep->bd_addr_p_t[queue_idx])' are no more > 64-bit variables. Not sure why gcc12 complains about it, can we follow it on the > v9 comment? Since the 64-bit variable issue is addressed and it is not clear from the build error if there is a real issue in the code and gcc12 is experimental, I will continue with patch, ignoring the build error for now, we can address it later if the issue is still there when gcc12 is released.