From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52597A0C43; Tue, 19 Oct 2021 11:39:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41FF440E5A; Tue, 19 Oct 2021 11:39:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 18C6640683 for ; Tue, 19 Oct 2021 11:39:18 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B16C67F6B8; Tue, 19 Oct 2021 12:39:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B16C67F6B8 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634636357; bh=wWD+3U6WdMG9YKayGBFgoI4d+jbHm/uiKRPRCT8Pm3k=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=LWv0VN/Lr/y788I3MbTUWAoZTpGev6Bdo+hVgsJpW/509Im0nJnnb8iJmGreaBIYU i9HLKfT94LGzoKOrMbyK0zxCjbWop0jl4F/JP64nZSTw8kZY8Xa0ZO5HyVfjJMhrtG sMByDIP6/MBe7ovLPXkqgU9+9liAp6R7Dq5KOwCY= To: "Xueming(Steven) Li" , "yuying.zhang@intel.com" , "dev@dpdk.org" Cc: "konstantin.ananyev@intel.com" , "jerinjacobk@gmail.com" , NBU-Contact-Thomas Monjalon , Slava Ovsiienko , "ajit.khaparde@broadcom.com" , "ferruh.yigit@intel.com" , Lior Margalit , "xiaoyun.li@intel.com" References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211019081738.2165150-1-xuemingl@nvidia.com> <20211019081738.2165150-3-xuemingl@nvidia.com> <1339af28-46bf-39ff-094d-1ae5052fa80d@oktetlabs.ru> <02d2dd094b42d1af3b5f188b82d787e1ae97e87b.camel@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <3ce370d0-c8eb-6570-0770-b175c12f6407@oktetlabs.ru> Date: Tue, 19 Oct 2021 12:39:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <02d2dd094b42d1af3b5f188b82d787e1ae97e87b.camel@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 2/6] app/testpmd: dump device capability and Rx domain info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/19/21 12:10 PM, Xueming(Steven) Li wrote: > On Tue, 2021-10-19 at 11:33 +0300, Andrew Rybchenko wrote: >> On 10/19/21 11:17 AM, Xueming Li wrote: >>> Dump device capability and Rx domain ID if shared Rx queue is supported >>> by device. >>> >>> Signed-off-by: Xueming Li >> >> LGTM except one minor note: >> >> Acked-by: Andrew Rybchenko >> >>> --- >>> app/test-pmd/config.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c >>> index 9c66329e96e..c0616dcd2fd 100644 >>> --- a/app/test-pmd/config.c >>> +++ b/app/test-pmd/config.c >>> @@ -733,6 +733,7 @@ port_infos_display(portid_t port_id) >>> printf("Max segment number per MTU/TSO: %hu\n", >>> dev_info.tx_desc_lim.nb_mtu_seg_max); >>> >>> + printf("Device capabilities: 0x%"PRIx64"\n", dev_info.dev_capa); >> >> IMHO, it should be decoded > > Thanks for checking this, do you mean decode to readable names? > Then we need a new API rte_eth_dev_capability_name(), it's simple, but > is it ok to add API w/o RFC? It is trivial. So, I think it should be OK.