From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42478A04B1; Wed, 23 Sep 2020 18:41:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 84E311D44A; Wed, 23 Sep 2020 18:41:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id CA5961D37E for ; Wed, 23 Sep 2020 18:41:44 +0200 (CEST) IronPort-SDR: uBKcptY/dw4wcrSu0GWCgp2cUN4WN603/DpgdZv4b8tvk6mWpRNXasyUV7Ycgbwhd1TG+WKlKm UpOwyXumytRA== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="140414892" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="140414892" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:41:44 -0700 IronPort-SDR: IapE7rhLB4YGHEfRDkURxq/WBwiZUiEv4spXPPo4ON9rsZUMVQoD38+BxkXJlyc9a9SjWImheP /Gzm05A0N44w== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305447481" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:41:29 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com, "John W. Linville" , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wei Zhao , Jeff Guo , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Akhil Goyal , Jasvinder Singh , Cristian Dumitrescu , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-3-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <3cec8608-ff68-5749-7d6d-b97a3d5f3fcf@intel.com> Date: Wed, 23 Sep 2020 17:41:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200913220711.3768597-3-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 02/20] ethdev: allow drivers to return error on close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2020 11:06 PM, Thomas Monjalon wrote: > The device operation .dev_close was returning void. > This driver interface is changed to return an int. > > Note that the API rte_eth_dev_close() is still returning void, > although a deprecation notice is pending to change it as well. Why not update the 'rte_eth_dev_close()' in this patch? After the updates below it should be easier. > > Signed-off-by: Thomas Monjalon <...>