From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 05BFD455C1; Mon, 8 Jul 2024 06:08:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E09B840A75; Mon, 8 Jul 2024 06:08:44 +0200 (CEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2051.outbound.protection.outlook.com [40.107.247.51]) by mails.dpdk.org (Postfix) with ESMTP id 24888402C5 for ; Mon, 8 Jul 2024 06:08:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mP1K5YI9cv3cpsiUlAtZuxpayhfEMtXc6CADx1oC1QTx7aTQ22/Dp2wQfdi48SQE0sRCEuDW5gpsUiwT+Hk9wzlGPp4TubYecK2oI8jfq3NIcV1Xvpy0JKb5zP5FZwGv08empnaUkaGLRsceGhPLzQXBu79CUwci8syMa5zByDmbtR77+t+7RpMqtQ9T5yzn9IOzfh25NqfaYAqOfgohfd17+uZnE8lv2hQDU6tsmRUxzX+R5W5hVPSUutXmBaJQW09ZpKHVw+cE9dNnnmDExkqdX33qpGKBLMZdpvPqEriRHV1drui8iMmIVYAdg3DmXKJWxs/4yzXc1f/ajbzCBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xP1Aisk+P0HAg1EeQvKvc5ST5tg21pEawXJ+Y+5aqj4=; b=NQo0mV8z2VIuJI9aDIl+zp7ms0x2Px0WJfWQVhpGnzIdKwaPZiFT+g4iq76shppWIxTgqmZ50R3osg9iAw+kcmK7RkikGzEEprWvqA+ZinK/17l8JgT1ysTHlS/OGnFM7re26HifrEoShASrbP6BNGaZmDhSpdf9iSokulnvJf4MsNgxZhZReuzXFEMWguXAT+vHoznhNnhUi7L0tlLUWVK5S90QX6aKjKgJdOzvEG3Ks0j3oZANPPFmeyKiItVUsL2iR3U9GGcFfc+Sk4zS7LKKG4h7w2Tq349O0aYhrhEhU2uacCCkW0Cz1YaSuygyOF4AC1ytPI55TSB5SGICEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xP1Aisk+P0HAg1EeQvKvc5ST5tg21pEawXJ+Y+5aqj4=; b=MFOPZyv9SWxinSF3VOOTTL4BuReOGX7/86mAPCanSDRUyss1jIn4BgNKxrvb90z285vQ2FXfHZBsamF4K5FNdZyV7bV1z2EPizB7okk9SQWtXmQcHH5R0Z5CP3D6YjuHu2VvM00DpanqoGlanWk4PzK9f6puhOyBgF0xfXRZqf8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by GV1PR04MB9055.eurprd04.prod.outlook.com (2603:10a6:150:1e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 04:08:42 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%3]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 04:08:41 +0000 Message-ID: <3cfddde7-6b3d-8350-c664-12c0a6bfa0dd@oss.nxp.com> Date: Mon, 8 Jul 2024 09:38:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 07/15] net/ena/base: update copyrights comments Content-Language: en-US To: Ferruh Yigit , shaibran@amazon.com Cc: dev@dpdk.org, Hemant Agrawal References: <20240702144626.14545-1-shaibran@amazon.com> <20240702144626.14545-8-shaibran@amazon.com> <26909df4-4858-41a3-a523-f8b567dc26e6@amd.com> From: Hemant Agrawal In-Reply-To: <26909df4-4858-41a3-a523-f8b567dc26e6@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN3PR01CA0085.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:9a::21) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|GV1PR04MB9055:EE_ X-MS-Office365-Filtering-Correlation-Id: eedd2b01-4b7c-48d9-884d-08dc9f03a6c9 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YUJUTldORlVQVXdlbElJbkd3VlY5S3dDUkhPY1k2ell4TkVCenFwV1FiVDhs?= =?utf-8?B?RUhQeWl5aFRXS0EvbW53MTM1Mjd4ejNaVk1reS83MmQ3UHk0VDN6QUJoeDZo?= =?utf-8?B?Uyt4RmZ1ZmMwMDJoQVNTNFZLWkQ3R2o0VEgzMU83VldtTk1GWGdlV3Q0Q2Rw?= =?utf-8?B?TndiMTVUdXh2SEpBM1JZSEdGbUlOdDIyc2FhOUJTejBEYkRnckZvOXN6ZVAy?= =?utf-8?B?MWVER1JoNnlJeHRpUm44cXRFSGFINUNRenltUU5lQkdYWk9tVkxMR1FsL0xw?= =?utf-8?B?Z1hCNnJwUlIrNm1yZ0daZUNzMTFGSWZVTzB0VGlBQ2QvN1QwSFdpUmxNcGxP?= =?utf-8?B?Tmt3SVo4bERkWVNNSEJtQUpJZ0VRSURkQjFKZWdjRzZoZ1JoMm80M3FjYjVD?= =?utf-8?B?SWlPMS91Z1ZLZ0Nzdno5ZGR6SjVRZnREbDBUV0Ewb3dPNEZrMXQvMTB4a2tG?= =?utf-8?B?L3h5UUNicURQbndSOFJGQTA3Wkp5NDdLcEJvWFVYSTFzTTBjanl5d2tZTkVy?= =?utf-8?B?MVhlcURpcVcySXhEaDVwaTNmSC94clFqdU5DbVpUaXNEQ1RJQ20xRForalcy?= =?utf-8?B?amRmU2hqeWxXaHVqYWpLL1A5RHpuTlJyYXpXOUgzbmxFM0JOT3hzYXJZaWhu?= =?utf-8?B?T1dNWStzYmdVTVorNHQ2RTA0dU9vQ2Y1NlFXcGFYTCs4azM2TGRldk1qc0Va?= =?utf-8?B?WkhXL2NOajM5T2d6VTVvMVQvcWNvdm1VekwxZkpuNVlqeGlFU0srZmUwL3Q5?= =?utf-8?B?a21EM3BhUEw3NkJYbGNGSXpQb3RCQVhDU2hOS3l0bnlNdSswR2FHbWdod29J?= =?utf-8?B?YVhBY2hReERxSzVSZnp1a2hpTTUxYmlUakJpQk1Hd2F3UjdETWF4YU52VCs4?= =?utf-8?B?VEUzODVrVFI3eGlLNUZGQ1pRclR4RUJoN0RIV1VLTWxxMkE5ejRIb25UTEhE?= =?utf-8?B?Qk9JWk1yWW0ybVREL2JOSlUyYVIvUWN5c0MvSFFrS2wvOGVVdkowNVBHMitk?= =?utf-8?B?TDRaVlVwZ1kxVzUrYnlHUDB6TDk5czVLMno2dGV5Yk1UU2piQUNTSkVjaFh2?= =?utf-8?B?SVVtZU5xQ2hvbEJ0RWZyUU1UTkFCdjMvdm42OUFBRnNXY21IRzg3U3UrMVps?= =?utf-8?B?dWE1VzVzV3RWZGw0cmNZTWdDZVpkekt5QjZCV3VZSjBNTkxJSVJOVDRGTW0r?= =?utf-8?B?bUR1NFB0NytNRzg2T05jb3c2U2ZQMThoNUFKRUhKL2YxVXBNbFdWdXNhVktr?= =?utf-8?B?citTLzhmRVdzaE91ZTlvcXJLTEVNY1dhYU1JWUxHbEdwbUtiZzVzY1JRcXR4?= =?utf-8?B?elVyZFBTVXJlVEdDWEpTZWxQdVV4dXFZUzd5MTBDTmJUWGhlSGNzNGkzaDcw?= =?utf-8?B?UXZsOFBFUE0xUG9VY3E4NTlzWEowWWF6ZU9UcGRQV0E1eXlRRXNFR0tKM2d1?= =?utf-8?B?WStXU1J1Z0hYOExrR3lCTkhEWXIvekJHM3lIQWtRRFNUSWk3WnozZ1Z4aGV2?= =?utf-8?B?bHFZajllT2ZTSFZnTThhd0tpc3V5M1V1ajJqSzBXQ20zajlVa0k2Z1NjeUQr?= =?utf-8?B?clU5bnpGbVFEelQrMTRBQS85cUlwYVl1RVdQTHBuSCtUTGdyek1pSUdMeWto?= =?utf-8?B?ZXZzNmNaekVNVVpyYlZ5VWNkV2pwdlNnc3JLdXBKckd0WTd0SXpGdk4wN2Nj?= =?utf-8?B?R3YwMmdzZk5rSkc0YXNaUXY5K2Y2WkhjaVZUL3VLUFlKdzMzSmJ4d0d3RDZN?= =?utf-8?B?V1ZRdjBYYTl0WmJGT1h5cDI0Ym4zZkkwSGF6T1UvYklkdVorYmZ1TkIwSVZU?= =?utf-8?B?bHpSMVN1OHlFK3hGVFU1dz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlU1MGl1NGg5akFxRXFJaXlzbWsyRWxpbDJ3eVh0Mm1Lb1R3UFMrSmRDVHE2?= =?utf-8?B?Q2dPR1g3K2dRdTBQZllBeEFDb04vRzdCbGRVLzV1UFZoRlUzT2ttMHJWaE1O?= =?utf-8?B?WmtwQURHUVY5QjYxek5EQVpTdlpuL0N2VmsxZXNJdmllQTlpeFIydTlyZHFl?= =?utf-8?B?MThyRUxOZTlweERjYnMwdnVINWU2Wk9sSXlWMFd3OC96bVBsTVVZOHlCTWFV?= =?utf-8?B?OXFnU1RXY1kzMFEzNFR6cFd2ZzNuZk5JYWtxN2tmSloxNUtiaXpmaUVsbnN2?= =?utf-8?B?OThOYUZ4OXFPQUswOGtlYTM3aC9QOU9YNjFHeUkzd3ZsdWM4bG9pWlZzY0JB?= =?utf-8?B?TkkvNWJEU0Z3MTNqYnlTZTJMNzdYeURHM3NGQTU0WDY5a0lHUjJvZlplRG1K?= =?utf-8?B?dlczZlZhUUxxM2lmczZBSThVdlRJQVB0UlV3QlJXN2Z0L1JKUjNHbmpnTG5p?= =?utf-8?B?VVhva0FzUzY1RCtGWTJlMEZNOUNQRXN4Y1BkbHhtVGVPQndadEx0SHY4QkZL?= =?utf-8?B?RUdXVkVHeVVzMXd1UDdhVS9iRytQbkpFN2gyM2ZCZ1FEc0Mrbk9GSGdKY1Fs?= =?utf-8?B?RGFsbXBRNngyYWsrU3dUazd2SHlzaVFSKzIvV3FITDBLQU5vdldLMXV5NFdI?= =?utf-8?B?c25PeGpsSnhLeGxLNmpDZnpENWpYd29GaWlGRDVKMTNVY3NicUtRY2RBZ1N1?= =?utf-8?B?WHhnQ0FJeUFrcmlza1ltQlJRV25Odkx4dzJzM1kxUVB6R1oxRTI0M0dRRGZ5?= =?utf-8?B?N3ExVzRHRUgvbDBMSlFjNnloRURuR2JXTk5vQ1R2MGtlTHJJZVZhT1JpN2Vh?= =?utf-8?B?cDI0anozT2cvN2VCUCs0TFpGeXJXLzVoaGd0MW9wdTFmWGQxZHhYSkdnNjRC?= =?utf-8?B?UGpmMHB3TWozdVY1b2MrdWNsSk9iMjlZMEg0VHhDaER6bk9SUnp4OG8rZ2xX?= =?utf-8?B?VmRUcktmK1lnbmZkUEc3U1dhOUtpZTF4QVdLc1NyNzd3NEUyeFZnTWpySEFL?= =?utf-8?B?L2tkbXNoT1FsOTVCMUg3LytzTWo5QUpjYTdrQmp4bFRuWGRCU0tDYW4weHpS?= =?utf-8?B?eTYyN2prdzEwZlRhVUJIdi9KWmVobXBtNkFvYUYvdTVBa3RuSVQzSHVLaUJ1?= =?utf-8?B?bFV3V1ZING5vdDFFNVlCc0IrcytxVkt2Uk1jbDVucjI0SkpoRi9VZVg3QzdN?= =?utf-8?B?VUp3SElIMUE0WUJIZUNocS9CT2krNUZCbkEvNkVFQUd3VWphTlpHbzlVNVhu?= =?utf-8?B?ZWhkdU9WWTFnbUJqQXZYQml1Q01iSXdLcVNrV3BPckZMZDFKdFg4MnlsMXNX?= =?utf-8?B?R0h6cllxMExXRVZXK1E2SGR3NFlMUlNyRDNSYm8veWVucWtYZS9rTkRZMmhJ?= =?utf-8?B?eHBHRTJhTFYvRE5ETFAxZGl4R3BEdDFBWXFlcEZmOU02U3lQQzRLUXZNS2x5?= =?utf-8?B?V0M3MWx0UFBnbXpVbXovMklpSUVja1Y0Y2hDcENjc25COFk0K25EMFVHMEpF?= =?utf-8?B?QWVkd1A4eHA1L2ZTRjArd0xtWERKQjc1Sm5IeEpJbitVVys0Q1NYeXRnYU1X?= =?utf-8?B?Nm51cXVOUDhEUmRhUkhJM0VreUF0Y2NTWFZRcVhjYVE1WEZNQmY0b3p3a2NF?= =?utf-8?B?cWxJNHRkWXFZY3NSdDZYdnAzTmZ2Qk1SSW52QnQ0dHNaQnJqdUQwU2JoRVQz?= =?utf-8?B?aXV3SXlSMDY5M1dqMnIzTHJ3WDNZWWdFOXJHY090TWpHRFI2SUtnaDFTOHFw?= =?utf-8?B?dVFzTXN1clh1Qjg5WXFvT1VZWCtMYVh0ZmlxNW1lSFdscVRxUjdaaTVzYlla?= =?utf-8?B?SDRCaWo0enEzd3VBVEU2S3p5WHBzYW5CY2tXM1J1UEpkSFhUazgrVlZpY0RK?= =?utf-8?B?cGVuT3YvbGF5ZmVyVWJya0JDdWtxZ0NRazFtNVZHZk45bWVzY1VYSGxrUngv?= =?utf-8?B?L2JydGJFcGJ6bWJJUXJDRC9iakkyUnlXV216dURCWFdJOUZQVzJMci9mMjVK?= =?utf-8?B?SStZR2lxQXFUOUVDUGViUUM1anVZa3l4ZHo3SWVzWXBKZE9pbWFpbnRKeUNl?= =?utf-8?B?Qm9IcmtOa3B6d3Z3dEtmUlhkR1dQTmMydW1BRkJFKzVkanJjd1BpZ0lEMTVu?= =?utf-8?B?SkVKMWVpdGhKUXAzRTNQQTNZaWxucHc5eVBMWjByWTlPSUI2ak4wd1M3UnQz?= =?utf-8?B?Qis4L0wxNzR5dEF0ck5MekMweDZzM2VaMHdDK1VuM1FYUjgwTEpwQ0Rzc0xF?= =?utf-8?B?a1MrOVhnYmpMWDNSY2hMM05sOUNBPT0=?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eedd2b01-4b7c-48d9-884d-08dc9f03a6c9 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 04:08:41.5417 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pIhRWddUyIYbmg9TTftXB3KTBngxGg/9uMev9fAwb/VhG27oZXahBIB1hAthV00m1Mmnl35wfUd5mzl4m8HHdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9055 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 08-07-2024 00:27, Ferruh Yigit wrote: > On 7/2/2024 3:46 PM, shaibran@amazon.com wrote: >> From: Shai Brandes >> >> copyright dates are not mandatory to be maintained, >> therefore the range of years was removed. >> In addition, the copyrights lines were separated >> into two comments. >> >> Signed-off-by: Shai Brandes >> --- >> drivers/net/ena/base/ena_com.c | 4 ++-- >> drivers/net/ena/base/ena_com.h | 4 ++-- >> drivers/net/ena/base/ena_defs/ena_admin_defs.h | 5 +++-- >> drivers/net/ena/base/ena_defs/ena_common_defs.h | 4 ++-- >> drivers/net/ena/base/ena_defs/ena_eth_io_defs.h | 5 +++-- >> drivers/net/ena/base/ena_defs/ena_includes.h | 4 ++-- >> drivers/net/ena/base/ena_defs/ena_regs_defs.h | 4 ++-- >> drivers/net/ena/base/ena_eth_com.c | 4 ++-- >> drivers/net/ena/base/ena_eth_com.h | 4 ++-- >> drivers/net/ena/base/ena_plat.h | 4 ++-- >> drivers/net/ena/base/ena_plat_dpdk.h | 4 ++-- >> 11 files changed, 24 insertions(+), 22 deletions(-) >> >> diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c >> index ad4f3f9431..5f46e692b3 100644 >> --- a/drivers/net/ena/base/ena_com.c >> +++ b/drivers/net/ena/base/ena_com.c >> @@ -1,5 +1,5 @@ >> -/* SPDX-License-Identifier: BSD-3-Clause >> - * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates. >> +/* SPDX-License-Identifier: BSD-3-Clause */ >> +/* Copyright (c) Amazon.com, Inc. or its affiliates. >> * All rights reserved. >> */ >> > Hi Shai, > > I don't know about implication of dropping the copyright year > altogether, we need to ask to an expert. > > What I know is, a copyright expires after some year, so to hold the > copyright, there needs to be a starting point. And people use ranges to > extend this copyright year. > > > Instead of removing the year altogether, it make sense to me to just > keep the initial year and don't add range later as code updated, this > also will be more consistent with rest of the code. > Let me drop this patch from the set, and learn more from the experts. It > can be included later, I don't think this is something urgent. > > > Another aspect is, the history of a source file can be acquired from the > pubic git repository, so when it is first merged, when updated, all > these information is available. > So this feels like no need to record these days in the source code files > but I don't know if these git repository metadata information is legally > valid and accepted. > > > And I am not quite sure if it has really any value to worry about > copyright for a publicly available device driver code anyway, but this > is not my domain. Hi Shai,     Will you please just update the copyright year instead of removing the year completely?  e.g. 2015-2020, 2024 or 2015-2024 -Hemant