From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 289C1425A5; Fri, 15 Sep 2023 15:46:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14BA3402EC; Fri, 15 Sep 2023 15:46:05 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2045.outbound.protection.outlook.com [40.107.244.45]) by mails.dpdk.org (Postfix) with ESMTP id 41FD840041 for ; Fri, 15 Sep 2023 15:46:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OQrONffVUHwS/r307tXvW2kt3bjodqe5lb9rQrXjAuGQtrTcTS21lU57C0Nje8PpFmimohCQrPYoPd2IFkFz+hTOXsbOJ48wBZnT0yaNmx5zTY196ujxw9SPwjO3zsXzF2OrYBOqZMiso9ODNZf50HbYa7BuF658v0lMvSiwDuLmJa7HUL2u0MA4tNitbShLTZ+NZejDJ7RhPoeeRsb9NqbwcZEScW8DMQpS3YBZALaFjUWO5UfK3S8gpAypHkLumraGBHnM/4OcJ27nSPSGLWIYnFE6bmPAOTleaidkU6z4uvSX6/PXN9TFUpQZXdsDM3/ItTeRoxj8RyCeSFiBQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WeIALUB4IkiOa4Rrwr98crwR7dca8dtPy7ZsuimtXRo=; b=KQtyFnoixYZa2V3U3vn1YWktMcoPzvuvebFfw8+OSYvGKTo+TcqLBaw706J+AtMJnzjFi6mcHcRAyQgi/DG7lltiNxu5nO6K3Fa+YBY1SyyV4y5a6kBjckw7n7ZINWfNW701DQX8T8InWEBXYHDGpd6mPqnzkd4Jsvb8CdYHsZmj3ELdM78YWbq/eZfkUABn+CERfv8jAAnI5S1ScMYdaHWnL7xLQB3yncuhJXOjTpL4r1aG/ISl0t6JbZgiTEuNSfzqLGBLTEUxRWrbWgk247ziCqIAUfGuMN/go6oBI+w8alcZDPsPu4TDxHi9DYgjENdRWpCIEb9zv1R0tVTXCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WeIALUB4IkiOa4Rrwr98crwR7dca8dtPy7ZsuimtXRo=; b=A/oNo/LifFn4poel59JKCF978ANl/zrnNDvxeSuTrshPw5xkOmOQ6YgzxUW3EQSSlQpeyC6xAv+kZkAE7c3xzXPJpnC0YaXg48e/1Xo/TE2HWgWpUe/fPHMgEGSoDe7G1r4ZuO727JRmQDY7+GwzBVU1ZyKJJiNdOP45rtotE40= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CO6PR12MB5393.namprd12.prod.outlook.com (2603:10b6:5:356::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.21; Fri, 15 Sep 2023 13:46:02 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.021; Fri, 15 Sep 2023 13:46:02 +0000 Message-ID: <3d0bf9ad-2564-4e96-bb6c-f735241b425d@amd.com> Date: Fri, 15 Sep 2023 14:46:00 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/27] net/nfp: refact the hwinfo module Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, =?UTF-8?Q?Niklas_S=C3=B6derlund?= References: <20230830021457.2064750-1-chaoyong.he@corigine.com> <20230915091551.1459606-1-chaoyong.he@corigine.com> <20230915091551.1459606-13-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230915091551.1459606-13-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0054.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::18) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CO6PR12MB5393:EE_ X-MS-Office365-Filtering-Correlation-Id: 7759b8d4-a72a-4baa-cd8b-08dbb5f219a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fr5RDmU+9fPokPgVZ4Jo4Cq2MvGGDlIXmh/iG7Svrdqdm5CtiBkyHEWZYJ1Fu0+Cz7VRqzNVYiQVqOHZKgpBrSy5WMB3N888ZNgxKABZeBRodhJkRWmpUt2hgJVAANaCutMrpu6Vqq18ts33ecaRkVWXqIiTIfWAUyJeL3WdLvoxdUixf1bUyUuUzGKfVZc738Oj/BuaRiY1stcHnAnRDH3sHfURfqrRLRdbKlTVZRA3u14qj0AVsx/BV46VHVJgyft3Xrf/zzAXD3ew+gT/E6w3UtBcURoip1ewHXr7nMNhb1B2jaZYvilygyk0jjLY+TquzQhCyj/bEQ8hmkYQf+dv/FLMCRBvbxt+cO1pXecA2eUks4JHFHLD+cdzJpIjHCKwW8TYygyyum9nHiC8ImeT1ECZ2zmXMVugxmHbbz4n55KgtFlB7MPryhvPhwz9WSLI8fedPVfTSBsNbzXSCb5vo53jGSOVYB8KNVrlHQ8TvzUlIG9PXYDNeUhePeCF5cVfT8JAysFtbz9v8C5G2W4caIOmfYhK683t7D6n/dupWzW28NeynLqSOLNJ6iwTSuohQuYgXwQZIqfDKK9ioxVB8G7afK8n6VtytGcvOtVycliJolxV+FRh8Qp/PE3Q/iB9nszv+yzEuPbNxzet8g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(346002)(39860400002)(396003)(376002)(366004)(1800799009)(186009)(451199024)(6506007)(53546011)(6486002)(6512007)(478600001)(26005)(2616005)(4744005)(2906002)(44832011)(66476007)(66556008)(66946007)(8676002)(316002)(4326008)(5660300002)(8936002)(41300700001)(86362001)(31696002)(36756003)(38100700002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjE2ZFZFT2M0cDYyM1p0b3luUXhhbUhucmFZZnJvbFFadGIwdWJVK0JZai9T?= =?utf-8?B?MkZzV1R4WUNzNGowUytyL1VSbzVUenJoZUdnQUhQN291ajdKamltMEN0NUZ0?= =?utf-8?B?dnB1blI1YS9oZ09aNG1DcHlBTWo3WDZPaVNySFp6bWFqT1BOTFgwSlcvWEMw?= =?utf-8?B?bHVVR29obmRDS3J2R1MzQUVtcmFLd0oyYjVQZ2JuSUpTQllOS1dlaWgvVlZs?= =?utf-8?B?UktiT3pkQ0cvay9pdGtFTHErWW9US0ZyeENQZlFmdmVFaEpvL2RxeWN5anFK?= =?utf-8?B?S1ZnSzgwVHVmaW1HTElIUmRMS1YrUGdISnh3UVcwSDNSbC9wSG1zV1FMaXRU?= =?utf-8?B?TWt1OWdlSW9uZWFTb3B6TXowT2dzUDhSMVdqcnVRRjZJck8rNUxRRHZEVk1a?= =?utf-8?B?OGZHN3kzZDBjYjg4SXRLRVNMZXk4OXRObHNSeUlzcHIrczBjV2IybHNoT3cr?= =?utf-8?B?bXYwaHQyRXRtRlBtRmxhMk9TMm9GeTMva0llcXAzVE5QV1k2amhNOFZ6UW1G?= =?utf-8?B?SDZKV3FOcEFSZ3VqeE82WFlyV0dqSElqd0U5RmRWSFhjUlVrdERmeXhPNmJu?= =?utf-8?B?SzJSd3h3T3loenJMR3ZNdUZYK2tyUkpvSXRvbUtRdkFlWkxUT2oxdzlHY2FB?= =?utf-8?B?SkpCTDlPc1paZUFDQjFjS1IxejV1VlYvN3FTcThKVi9Mc1VWR3YxNENQV0Rj?= =?utf-8?B?TmRjdTBFVXorNzdpYkhud2dXajNsNXhnMEVyakV0U0JlRTV2V0Q5eVp4RmJQ?= =?utf-8?B?RHpkaTVxQTljSHRlZDZPZ281eWthaFdUYkJ6emUwRmM2R29CajJOZ2UwcW1q?= =?utf-8?B?VHFHbE9oNjVrWnBNd2F6NFRWQzlmRTZUd1kvWXlyRnBQZDg5RXA0ZDBGVzFx?= =?utf-8?B?QW9Gcms0RE4vZVZwNTRFc2pZMkYvZGg1eklNSmpCSWdHMDViaGM2MnlJK2pO?= =?utf-8?B?aENsOGU1RHBFQVczdXExZUZFamVrd0x2RGF2VzJCZGt4eTNxbE5nVEdzempN?= =?utf-8?B?b3JWdE5oSWl5Z1lia1VUaFcwS3g3ay9QRDBjdDNYd1pYVTBVQkFwcm5UR3JR?= =?utf-8?B?Zmx0MGlhdUFxaVVSMzJjU284akhhMXd1MWZKaHczQ1FKeDRmN2IrSy9LUWZl?= =?utf-8?B?RlFZYm9uTUU0WEU4dFpEQ2dHN2F2YUxZaUU4cm5OMmg3bEJPRVY2NlAva2w2?= =?utf-8?B?ZVRwM2hxZncwR2FQRkxpOU1nYmtldm1mcEtRRHhiR0FWcDZyajFrR0Zwdytw?= =?utf-8?B?N0dVUFFYQm1lVW9XSHdXVWVwY2RIRmJmc3ZDdHlWOGRtU3pQdEcvdWQxaGUx?= =?utf-8?B?RDZ4Q1ZMSllzZ0R3UkJzZjJYQVZQT0pyTDBVQUEySWozaVRBZWQ5azduVm1P?= =?utf-8?B?dXNjbFUrNzlxR1BmT05mYzFzeDhRcE1tYy84aWQ4OGJsaktHMjhrWm0zNG9I?= =?utf-8?B?SDJnQ0UwditmeUYwVGU3ek0yNG41MW9vY0lqRVBSVkVVbkwyaXlRNnlOQURs?= =?utf-8?B?eVlodjUxTVIrYVBhWTY0TTBvV0k1bjUrQkRvdXBBN2w0RkNQaG12b0MwVWxQ?= =?utf-8?B?NTFWaFlXd05qUTg4V1N4eFluNUxWQVZocWwzQ1FONTRDbnc3SlpmNWJiQmEz?= =?utf-8?B?QStXYjM1UUhDWWUrRWNBRENURmVmL2h3MG1nWGh3RTljUlAxRTFYSmI5clRT?= =?utf-8?B?L2tPSU0reDhwZ0tBYWpWRy9qTXVWNHZ0MXFldTZ5bWt5U0lMYTk0SDJJL05K?= =?utf-8?B?MHJaL3U1SGJ6TWJRSnpZUVQxb1RUcm8yM2ZPK1ArekVMZWFkRUtQMmloR0tW?= =?utf-8?B?V1U5WCs5dWFCYTlnY0grdVdHaFdSK0FIS1VtNzRKUFZ2ZkRUZlVCbXQ3NTNC?= =?utf-8?B?VWRTMkd3Q0ZWVVN3UDYrT21MS0JYZDd0VEJxcGYyTXJpZDhUcSs3MHFseU5T?= =?utf-8?B?ZXdCMi9jeWNIaFJtN2grZ09WTS9KU2JKcnBiY1QvSDFWcWxJRzBiVGFzT2Q5?= =?utf-8?B?cm5yV0MyMkxGeXhIczZtWHU2SzVmNDgvT2JpNmQvZndSTU5jMVNSL2ZXZDd5?= =?utf-8?B?OVFTNUNvR01SZmh2eCt6dTYyM0Nra3E1KzBxNUtaR3MxRUNrWnlaSE9HVEYx?= =?utf-8?Q?kqUQv/mg2+xCazqUJA/n1dz/q?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7759b8d4-a72a-4baa-cd8b-08dbb5f219a0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2023 13:46:02.1657 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RLqPag/iVBnU/S0FOe7LRBBKvrWb/rilMFeXirey/EAkSUoa21OIZ/qCFIXtt0JH X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5393 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/15/2023 10:15 AM, Chaoyong He wrote: > Move the definition of data structure and macro into the implement file. > What is the motivation for this move, I can see same is done in multiple other patches? Header file is still included by .c file, what is the benefit of moving from header to .c file?