[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[Anatoly Burakov]

When .get_monitor_addr API was introduced, it was implemented in the
ixgbe driver, but only for the physical function; the virtual function
portion of the driver does not support that API.

Add the missing function pointer to VF device structure.

Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index ff65145f55..6cca039a11 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
 	.rss_hash_update      = ixgbe_dev_rss_hash_update,
 	.rss_hash_conf_get    = ixgbe_dev_rss_hash_conf_get,
 	.tx_done_cleanup      = ixgbe_dev_tx_done_cleanup,
+	.get_monitor_addr     = ixgbe_get_monitor_addr,
 };
 
 /* store statistics names and its offset in stats structure */
-- 
2.25.1

[dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

[Anatoly Burakov]

When .get_monitor_addr API was introduced, it was implemented in the
i40e driver, but only for the physical function; the virtual function
portion of the driver does not support that API.

Add the missing function pointer to VF device structure.

The i40e driver is not meant to use the VF portion any more, as
currently i40e VF devices are supposed to be managed by iavf drier, but
add this just in case it needs backporting later.

Fixes: a683abf90a22 ("net/i40e: implement power management API")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 drivers/net/i40e/i40e_ethdev_vf.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
index 3c258ba7cf..156ad9ab96 100644
--- a/drivers/net/i40e/i40e_ethdev_vf.c
+++ b/drivers/net/i40e/i40e_ethdev_vf.c
@@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
 	.mtu_set              = i40evf_dev_mtu_set,
 	.mac_addr_set         = i40evf_set_default_mac_addr,
 	.tx_done_cleanup      = i40e_tx_done_cleanup,
+	.get_monitor_addr     = i40e_get_monitor_addr
 };
 
 /*
-- 
2.25.1

Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

[David Hunt]

Hi Anatoly,

On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> When .get_monitor_addr API was introduced, it was implemented in the
> i40e driver, but only for the physical function; the virtual function
> portion of the driver does not support that API.
>
> Add the missing function pointer to VF device structure.
>
> The i40e driver is not meant to use the VF portion any more, as
> currently i40e VF devices are supposed to be managed by iavf drier, but
> add this just in case it needs backporting later.
>
> Fixes: a683abf90a22 ("net/i40e: implement power management API")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   drivers/net/i40e/i40e_ethdev_vf.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index 3c258ba7cf..156ad9ab96 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops = {
>   	.mtu_set              = i40evf_dev_mtu_set,
>   	.mac_addr_set         = i40evf_set_default_mac_addr,
>   	.tx_done_cleanup      = i40e_tx_done_cleanup,
> +	.get_monitor_addr     = i40e_get_monitor_addr
>   };
>   
>   /*


Same issue as the ixgbe, get_monitor_addr op missing for the vf portion 
of the driver. Thanks.

Reviewed-by: David Hunt <david.hunt@intel.com>

Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for VF driver

[Zhang, Qi Z]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of David Hunt
> Sent: Monday, April 26, 2021 10:23 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Xing,
> Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>; Ananyev,
> Konstantin <konstantin.ananyev@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/i40e: allow get_monitor_addr for
> VF driver
> 
> Hi Anatoly,
> 
> On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > When .get_monitor_addr API was introduced, it was implemented in the
> > i40e driver, but only for the physical function; the virtual function
> > portion of the driver does not support that API.
> >
> > Add the missing function pointer to VF device structure.
> >
> > The i40e driver is not meant to use the VF portion any more, as
> > currently i40e VF devices are supposed to be managed by iavf drier,
> > but add this just in case it needs backporting later.
> >
> > Fixes: a683abf90a22 ("net/i40e: implement power management API")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >   drivers/net/i40e/i40e_ethdev_vf.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 3c258ba7cf..156ad9ab96 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -216,6 +216,7 @@ static const struct eth_dev_ops i40evf_eth_dev_ops
> = {
> >   	.mtu_set              = i40evf_dev_mtu_set,
> >   	.mac_addr_set         = i40evf_set_default_mac_addr,
> >   	.tx_done_cleanup      = i40e_tx_done_cleanup,
> > +	.get_monitor_addr     = i40e_get_monitor_addr
> >   };
> >
> >   /*
> 
> 
> Same issue as the ixgbe, get_monitor_addr op missing for the vf portion of the
> driver. Thanks.
> 
> Reviewed-by: David Hunt <david.hunt@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> 
> 

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[David Hunt]

Hi Anatoly,

On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> When .get_monitor_addr API was introduced, it was implemented in the
> ixgbe driver, but only for the physical function; the virtual function
> portion of the driver does not support that API.
>
> Add the missing function pointer to VF device structure.
>
> Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff65145f55..6cca039a11 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
>   	.rss_hash_update      = ixgbe_dev_rss_hash_update,
>   	.rss_hash_conf_get    = ixgbe_dev_rss_hash_conf_get,
>   	.tx_done_cleanup      = ixgbe_dev_tx_done_cleanup,
> +	.get_monitor_addr     = ixgbe_get_monitor_addr,
>   };
>   
>   /* store statistics names and its offset in stats structure */


Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual 
functions here, and can confirm that this patch resolves the issue.

Reviewed-by: David Hunt <david.hunt@intel.com>

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[Wang, Haiyue]

> -----Original Message-----
> From: Hunt, David <david.hunt@intel.com>
> Sent: Monday, April 26, 2021 22:20
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Wang,
> Haiyue <haiyue.wang@intel.com>; Ananyev, Konstantin <konstantin.ananyev@intel.com>; Liang Ma
> <liang.j.ma@intel.com>
> Subject: Re: [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver
> 
> Hi Anatoly,
> 
> On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > When .get_monitor_addr API was introduced, it was implemented in the
> > ixgbe driver, but only for the physical function; the virtual function
> > portion of the driver does not support that API.
> >
> > Add the missing function pointer to VF device structure.
> >
> > Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >   drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index ff65145f55..6cca039a11 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = {
> >   	.rss_hash_update      = ixgbe_dev_rss_hash_update,
> >   	.rss_hash_conf_get    = ixgbe_dev_rss_hash_conf_get,
> >   	.tx_done_cleanup      = ixgbe_dev_tx_done_cleanup,
> > +	.get_monitor_addr     = ixgbe_get_monitor_addr,
> >   };
> >
> >   /* store statistics names and its offset in stats structure */
> 
> 
> Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual
> functions here, and can confirm that this patch resolves the issue.
> 
> Reviewed-by: David Hunt <david.hunt@intel.com>
> 
> 

Nice confirmation, thanks, David.

Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver

[Zhang, Qi Z]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Tuesday, April 27, 2021 9:43 AM
> To: Hunt, David <david.hunt@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; dev@dpdk.org; Guo, Jia <jia.guo@intel.com>;
> Ananyev, Konstantin <konstantin.ananyev@intel.com>; Liang Ma
> <liang.j.ma@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for
> VF driver
> 
> > -----Original Message-----
> > From: Hunt, David <david.hunt@intel.com>
> > Sent: Monday, April 26, 2021 22:20
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>; dev@dpdk.org; Guo,
> > Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> > Ananyev, Konstantin <konstantin.ananyev@intel.com>; Liang Ma
> > <liang.j.ma@intel.com>
> > Subject: Re: [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF
> > driver
> >
> > Hi Anatoly,
> >
> > On 26/4/2021 2:49 PM, Anatoly Burakov wrote:
> > > When .get_monitor_addr API was introduced, it was implemented in the
> > > ixgbe driver, but only for the physical function; the virtual
> > > function portion of the driver does not support that API.
> > >
> > > Add the missing function pointer to VF device structure.
> > >
> > > Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API")
> > >
> > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > > ---
> > >   drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > index ff65145f55..6cca039a11 100644
> > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > > @@ -605,6 +605,7 @@ static const struct eth_dev_ops
> ixgbevf_eth_dev_ops = {
> > >   	.rss_hash_update      = ixgbe_dev_rss_hash_update,
> > >   	.rss_hash_conf_get    = ixgbe_dev_rss_hash_conf_get,
> > >   	.tx_done_cleanup      = ixgbe_dev_tx_done_cleanup,
> > > +	.get_monitor_addr     = ixgbe_get_monitor_addr,
> > >   };
> > >
> > >   /* store statistics names and its offset in stats structure */
> >
> >
> > Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual
> > functions here, and can confirm that this patch resolves the issue.
> >
> > Reviewed-by: David Hunt <david.hunt@intel.com>
> >
> >
> 
> Nice confirmation, thanks, David.
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi