From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B9B5A034E; Wed, 9 Feb 2022 20:06:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 697CE4114A; Wed, 9 Feb 2022 20:06:57 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B38D340140 for ; Wed, 9 Feb 2022 20:06:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644433615; x=1675969615; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=hZvMNGmS6I2K8c3Eu96FjRCxj2mRRPj2Iw4GqUXsMFU=; b=TwS++JbCThFqBG99fKgbgUKVN494e9V70/olkGKnlTRzDUYSB2KAN2+D MCAedKPIPLZFgNQQUps4E3OhkZwHPyzyJeYGLQ8d0F37OLwivBMqdnP8e eVSIWC4ec0s5X+h41VtoniFAKMfxLiESF7I11zoLILhZ7RYDSz4ss6jsE yNM/IJwPGFqRG5MVUkqqHu1o+67lATTP0LViloUw2iYd6xiZxQNl6zWEJ 1hmRUpgtb9n2T2ntc55+5LEQzMOEKiHWCMLfHqs4/3LtHd0xOBl7z+coC mNzgYNu4pfBHTLwYvoRHSxZx1GuzTaUyOAEVNdTdMDYtoEk97yvHXTXJ6 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="229955682" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="229955682" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 11:06:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="482453925" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga003.jf.intel.com with ESMTP; 09 Feb 2022 11:06:54 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 11:06:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 11:06:53 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 11:06:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G/WQbTdNe/BUzWrEXnw0yqChGvSqp8rKCcRiOFMVxKLfQ+Wb5nlWQhGSCdrbT+SaRK5ACwKQVSEgGreYm9PwLA6K+JxaFSeR+oDbRjNi4NWjrc2iroLyEYifN6ZKDX8W/PoUDXGmn7lb7EP3ZJWss6SOpctotKNwHyZgc+vtWW+HUiE0/+HnWZCXl22ZzIY8i7lwfoojbJo3QSX/IqB1GY00EQ6S7XIGXkJx3HiCQ+yEEJTSNLp5qAbTRnqpIvCCjlHWTc1l9p5csFvyM2MAkBR8nSo/+QFTQL6HBwfm5OHwokLHnCKApXVW2L1yI/bmsebp24uYT7Js/DtPyD13iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mEoYrz69CePr6jkDtUbc4S/GDyrSj4AEpgH/iz8657k=; b=Y/8sj1tIqz4rXP2hFzgjg5vCEwfOKpTfo/MrWyTYLbbNu28ghGE7PMcNQuVA+aYBaGJakax8w6znJwb42Ocd/+uJYKvwMo/RENImomvniYrLS7hqmH57+YDBPKnip1XhTJSNHysr9xD7Tt+s0eZ6SMugeW1u453LLba77fZC7HlR/NwoYrj21qLanHK9aQjmv7IF794bdFZRSxb57UaBUUHb8qB/66JqrCgeYrUUwlIOECutYi4q3fgDatJOVE2xi3lvI2sdRL2qbNeC2IEwYxLMayoJFoiCMhIVSL3oUXGCFo1gRhqS0k/wxUZ1nIZ+tP8H3f1EemPmqyEhNsgMgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL1PR11MB5222.namprd11.prod.outlook.com (2603:10b6:208:313::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.11; Wed, 9 Feb 2022 19:06:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 19:06:52 +0000 Message-ID: <3d314c38-ea66-2e3e-1cf8-68bc98307416@intel.com> Date: Wed, 9 Feb 2022 19:06:47 +0000 Content-Language: en-US To: Jiawen Wu , References: <20220209104213.602728-1-jiawenwu@trustnetic.com> <20220209104213.602728-8-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH v2 07/12] net/ngbe: add LED OEM support X-User: ferruhy In-Reply-To: <20220209104213.602728-8-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0441.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f771f35f-effd-4fa8-a6e8-08d9ebff5497 X-MS-TrafficTypeDiagnostic: BL1PR11MB5222:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:519; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IjU30hdO8mWNiql2q7dP5O/J2Hl51mDz41KRkW/hQ3lPXE3YOvDd5Fwa3hgUPz1RNaU1E1EhNZI3xs7YRQ3vnVa/tl7xPKIGOcZcmZvTf2t0mS+rYhRSNPDeg5OVSx13G9uOlieJNZaMi0Exp4SrTPJV727hYlHyQfUudvOG2DCeTa0wqe+NWtGAECOTi37fMs2hyPKd+XZZEKmn+ME1rWY0bEzr06PMyv86YaLGjX1NhfrqGmR91JUuY4AAFL4cqbDm9+m1RjJC2/f6+uWXYW+TJ8PAQBqJIGDYwC3flaVJ3Bl1HZWAXxpvrS8ig8ky+or3rUSrLrXcnBOYgcR+zuvByBDdBG+e9VZRDOAlGxq/RDqImgbIM9KG1RNHgXx/EZtzY3A32FjO5a+Klh8Ok+NqjNVh75qV+npeMNzm8MxLBcJkGgDajnxbj9WWwP6tjUnIxNaYQKFWIgM+YqadZr2wcgsh5TYqQAIueNngyHmeSvi+xrUZK4C8OF+DrP2uPI5BI4Z5KeHajHjc0w8cO0JBVFFEpPF5lA6LBTDeJf5seewHQZNpxji56BotVHyUOAx6miO8i/NQ/xcn9GgIqWCIalnkXQ1PxTcjRpbI51u/m1wxOHsaudZJUKwjZBMCUvS0bhhwmdzQjg7bFjwI1pCjqeaXjl4DHPw1FJ540QmqAFKT9WodsvUuZxKTKH/nxtLxhqfUTbHSauCCXdCaKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(66556008)(55236004)(6512007)(6666004)(82960400001)(66476007)(186003)(2616005)(38100700002)(316002)(6506007)(53546011)(8676002)(6486002)(508600001)(31696002)(2906002)(66946007)(26005)(4744005)(31686004)(36756003)(44832011)(8936002)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Vk5IZExaQk03MXVIT3JxajhRc2pCQXNLRkNoemlkWGpGTit1RjlYQXNvdjFX?= =?utf-8?B?SkdlMDBkQk0yQmwvc2FhVDRsa1lEMFppRGRkQzZIT0Q0WnZkenZCZUxnK29H?= =?utf-8?B?aXprTWF1aS9KbG5mdUt5OFZ5enNOS1lFU1RJRW1FTlBZb2NYd0JJcjg3SmNy?= =?utf-8?B?QmN6Y3Fxd1VUTHFoZ1dtLzZqR1poV2IwZEtxcFNlZ1VsNzk5eFlFdVdVR1VP?= =?utf-8?B?ZkZCbi9iQ1JhOFhFNDgwU3RkUUNKRHBYTEs5VXZqUkwrT21LVEkvdUVTV2hC?= =?utf-8?B?ZDJvUFZLaHRxWHVaQThrRUFiVG5QQlNjNlJSNUlWK0pOeXkyOGo3dDhVb2Iv?= =?utf-8?B?ZS92TVhLcWcwMTEyaW1qMzBHTTJTZ2JEWHJzN0VBY3YzVWxmcE9pRTl6T2hq?= =?utf-8?B?SVZkeW92TzVweEhub2FLOENLN3Q2V0gvb1FmdzhFdS9acFhXWmxYVnZ5MW11?= =?utf-8?B?YmlqeUFnajRNd1dYa0cyWlF4N0pkR29JZFF2UG5CZzF4WGtIVGtjTG5FYlFt?= =?utf-8?B?VExDYzRoLzBOVFluZkVpUzBITDZOU1RpbGkzdVJEMmFzdFFzTzdHNkMzQzZD?= =?utf-8?B?Ym1HMVV5REV1V0d0V1h4RFF4RDkwOFFOYThLeHFDWU04a2tPaXNEZzExa012?= =?utf-8?B?ZFp5NzZEVEM4YmJnV1YzTVhIS3dwdWl2bHJIci9rTXh4N1BhdXpqV1dLK0ZZ?= =?utf-8?B?MzhkeW5BS2x6bEVUekpxWkhQbnRDRDNSK1MrdE9Jd2wyZHE5enZRa3l5WDRS?= =?utf-8?B?V0VvS0FtZUVGL2ljT24zNm91T3dqOGRPTS82OXdBVXlrWVBxV05FVTJJTXcz?= =?utf-8?B?M1V1MUhxS25ESzlDdFlQek9uYzF0R21hREU5UmpFMTlzSS9JYTB6NjhJbEpW?= =?utf-8?B?Vy96Vk83MXIxY2ZLYTBGVi9yMVdETngxQWpzbDRmbWRvRm5tSGtLSXVDYS9L?= =?utf-8?B?VVlHN05WdER5cUNmVkt1V1JQWlYxU1BSNVRNMC84alM5Z2tqV3pudEdSZFZG?= =?utf-8?B?SkduTnVmSnFxZ2tTV0F2ZUxya2plRG9Xb1VuNzlGelJTYUNKemxsT3VCY2Zp?= =?utf-8?B?TllrN3pMaXJIb3pSVUhGWjBvaHdxaHlnZ2dHSC8vWVN0b3pBZWxmNnFWUTZB?= =?utf-8?B?dGxscDdvZGZ5elhuNnZqV0xybEVkblBveWNyRTRsSlVNNDRqdnk2Znp4a0VU?= =?utf-8?B?bXc5NFF1ZTJOODRSeGhTU3MxNTVUWTMvN1pWSlFJVVpMWEMxcVFLZEN5NUpW?= =?utf-8?B?QkYvLzZXd25Ic2tlZmZYcEhub3B5SHh5VytIMXFPc1BkczNacGd4Zy9mRnZ2?= =?utf-8?B?akl3cW9LME1TVTc5bVBwdDdhM0NSUmRUSzloOFlkcXNsWUxlaW9MMHRhMzJ3?= =?utf-8?B?bm9yVjZyZXNhUm1rRmhobjNZNDVCd01Cam5UUXNXMVJCRDArbjFXSU9WUFJL?= =?utf-8?B?Njl6UDRBQXB0bU9sRjJtcmY5MC9IQ2V3QlkraWdRbGtzWDVVaTdPVzhBVE00?= =?utf-8?B?aXYwa1FCSXNzUXNxNnZ2RXdvK3Vnemo5NnVvT0p0OUNpYnRHR0RWWDRFYjZ6?= =?utf-8?B?bGlqNmJ3Z0RkK2c0V2NtNjJodE9uWFpnaDVTWjVuRU9CQnFKOHEvVlRDenlU?= =?utf-8?B?aDZGVE5MdzlvREVBNm1TTGM2WENkb2xWS1N1c3NaOHM4L3pHS250QnhhSS9M?= =?utf-8?B?a1MzaTN6OHZpUUVtSDdYbUNxR3lnbi9GZDJRaGhOcEdFWi8xS3MrYldudHp2?= =?utf-8?B?YzRiYlRvL1IwTEZlOHRya0xnbHcxK1NVUlJQczNLK3Rid2tFSy9yT3FKRVQw?= =?utf-8?B?bmRkUmpyU3dhVGJuSlkxeHJQVVFkSTBNSTJYUmo5elB6ODAzMkE4b3o1Q1BV?= =?utf-8?B?ME16U1FobDk5MXlsbGZoN21maDhwNjl5RktLdHNCRzk4MzMrcnkxUWRvS2xz?= =?utf-8?B?eTF1WmVsdGx5Wm91SHZIQ2ZYU0NiRmhreEVIcUpjN2tSUjhHaHR3U2hSQktG?= =?utf-8?B?TGN3YkRqQjM4YjlsWndZSlFHQVZiMi96aDZjWjR2SHZ5OS8vTFp5OURiZDho?= =?utf-8?B?RkdNQUErOUZDSnBkbHhnVXgwRTRySlUrVDRQc3UwY0NCM2xiVUh3SFJjSTdE?= =?utf-8?B?RmwxRlhnMjVGSjl1ZEd0S1l1TnF0d1I1VERZaGhyOG9HRHIvbHV5RjhKTm9C?= =?utf-8?Q?ocTJ6vqT6WfdogDCIvbCyDA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f771f35f-effd-4fa8-a6e8-08d9ebff5497 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 19:06:52.0704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ikqo2wFm+giaRq5W0f4eayzYNVbBZ8ilMHIWgxPr164G+RDrECoUnf0SjGpX8JnVYfL9N/CbcNYnwT5q3aCzOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5222 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/2022 10:42 AM, Jiawen Wu wrote: > Support to get OEM customized LED configuration information from firmware. > And driver needs to adjust the process of PHY setup link, based on this > LED configuration. > > Signed-off-by: Jiawen Wu <...> > @@ -338,3 +338,52 @@ s32 ngbe_hic_check_cap(struct ngbe_hw *hw) > > return err; > } > + > +s32 ngbe_phy_led_oem_chk(struct ngbe_hw *hw, u32 *data) > +{ > + struct ngbe_hic_read_shadow_ram command; > + s32 err; > + int i; > + > + DEBUGFUNC("\n"); > + What is the point of 'DEBUGFUNC' without providing function name?