From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0089.outbound.protection.outlook.com [104.47.38.89]) by dpdk.org (Postfix) with ESMTP id C24892C66 for ; Mon, 11 Dec 2017 10:00:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=w+OOLwtbOZGOpwoMetA7wDBEGFpCMKTa0F/Z6xHZfbY=; b=ikB8kQ3P6wItJH3jSNkGAZV5C6NpNRGVpgJaNWb8/mkQPRoUgUq3L9uJwoqxxD0mANIh6UVdSJqYpqJJVMEtGh5qnRfLM2XPzRdnvnLiSSB5GUoPdO4BVmkEb4XjB0V+IHEXg+BVpY8tPCZMFDAZ3q96aPoNKP4muQ6XABEDSoI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Anoob.Joseph@cavium.com; Received: from hyd1ajoseph-dt.caveonetworks.com (115.113.156.2) by CY4PR0701MB3635.namprd07.prod.outlook.com (2603:10b6:910:93::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Mon, 11 Dec 2017 09:00:13 +0000 To: Nelio Laranjeiro Cc: Sergio Gonzalez Monroy , Radu Nicolau , dev@dpdk.org, Jerin Jacob , Narayana Prasad References: <6ac80a2be156911ee35c894924a02f04c43f49fc.1511449894.git.nelio.laranjeiro@6wind.com> <20171208144000.seega54cbv7prktb@laranjeiro-vm.dev.6wind.com> <11087367-b892-aae7-07bc-555232a0ce8d@caviumnetworks.com> <20171211082132.usggk5hfz3xy5usl@laranjeiro-vm.dev.6wind.com> From: Anoob Message-ID: <3d536158-7371-614d-a2ee-a3282fda2c65@caviumnetworks.com> Date: Mon, 11 Dec 2017 14:30:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171211082132.usggk5hfz3xy5usl@laranjeiro-vm.dev.6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [115.113.156.2] X-ClientProxiedBy: MWHPR14CA0034.namprd14.prod.outlook.com (2603:10b6:300:12b::20) To CY4PR0701MB3635.namprd07.prod.outlook.com (2603:10b6:910:93::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40c9f506-bd6e-438b-bf5a-08d540759872 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(5600026)(4604075)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(2017052603307); SRVR:CY4PR0701MB3635; X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3635; 3:AMDALeYuZCWT8B7TFIR7/aVAFy4O9vPV4NeBf00QrKSiMUyQMx+Cwz/L4vL9QHNJalGRdW/IaSjFO3AXZYGqFBEs6/mPdY20UEh5xRrcZwV/RQqqRHcn5eCt4p/eqSgZDvawtr7r05q0UjMpoWou2LIQsPOW85RwOTef92OrGhsrSjYV+nUqYUsBhZDvn8NGZs0wJ7ntcuRvj3Fzsqb9hnqNnNZqSQ3lCdTVA35UFRe7QTQ+fU5OAx1TG/roKPnS; 25:Iy7HFiE5xI8v29tFqz9kAv5aCKHpoezesaZR/mwq1MKJ2VhdMtDHBqdRIuyXlt+CDCfY7xd4XqQEu48vrIfUbts9aBBScqP0u9c8IffYhXXBYjw5OLLKMzQbNtK6+wh040pzmQbYtwOVHvYtvv+SBX3lyuzDLoA5YSkVmwbLKBazNGR0vDxOid1sIGYsGubNtzwTlmuqSiC5DZWqgYp0fTSoYbN0f5ixApsQjlTH0lYeykWXvBXceRWdE/EveRoeT17XBqHog3TyOAbfnoGL0pwY6UTTDbEBK/V0/dDKMFGAdVx0P+khdCOpNCsrWnVSWQvO4fZjEN8km4w9TQb/Tg==; 31:WM8rjPEaKU3xqadfx7wNigDuud6lOikLpwFDbSJeVyx8Kh3yEABmsqE+LDBm4Da+A1Hi1jHxWPsHpLn4IMuJQcFb5AUYa3j5rTmdx5Or+M0JmupM5kg4DA8yO6Qv+ault6Bhi+VF8rYBHcnJVuocc7TGS59Ay4f7izhhak0LXwe6rFfcRtJEsZKI2jKPfbnUXA5qJwWrUh7eaONF7x2XDOCVpQewM2r69NTOVjFu/rY= X-MS-TrafficTypeDiagnostic: CY4PR0701MB3635: X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3635; 20:WQdFs4J0nWIOzOahn3EZ9e0ceLITkR3WN8nq3qfl9QSJToJrsqoxEpCqa4zw4eSwP4saEne4SYOV3wudvVvaGGdkYlwEragbitQKJxRIrS7I7vKr0woZjvit0MI7uzsPOg7MJElTTRPjyb4SgLfMJgVGpPM2ZyVBd5hddKh6JEBxTrJ+6kOQAKXiTpdY+IjqMX8nLa3EXx8/ApnvYsJKkioDUoDk7klQ2s/qKXDvnNO3YVdM6q9XiLOEQ/LpgVgMlxgayflEz1c3D7TmWY/oF6dknsK78EZ3GUSlL3gPtlMLGXSFNIfzZq/vb4VIkW+5t5oRqG2Z1RvqARQBZ343kA/CsB6x+4jYG7f8ZWTV7CNnnGcUokLWf9sBa5j4BGRRd8uQ+lYgjja/CKnfKJaBbK9mKCGEDwjLGKM53NBLx+Hwgz9hh9W9CP46t+LYWLypbNlABZ1OIvRP3PTPpXNshEopNzp3eYXoqsy7pUr8SKYbE/8K6Ac185/PiooSypaERUYqSlIFvedztUSwuLo/qCythNs2fKSl5M+K3yJwgfP2GPXfQSXMTMZ2wz2VtvExi/7kLcvbp4UMzZspZu8LBLc9a9NjoI/sqIgeBhwmZJk=; 4:/FWgvGOt+dTgynTjgOU3HbyfUc3b4YRBm4m2JAoEeo2exbYV0i1ZHtWftsy4KMOAB4D1fVTxbI58nF/IJzhfES0LWjefPdffZoatFW6MqZf7hTHvnni5zkOzgb+1973hmNMKqHb3vw5PtL3EphgpBaCIFmiKw1gt+SZlCn7OQiR3TZDUcMYw2AqcqGdUFL6LTmsyZbu8NWQoqDPyb3UGMwbIFZZ2T1qZI4ZBQhzPBqovTkxs+P1a681gZS/+RN1zwpifaxBWCXxOIX6dUWjdocFUCwzWfgWZAUTqLgiBue4Vo85eEGgK5+kLLQJSwoFP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(278428928389397); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(3231022)(10201501046)(3002001)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011); SRVR:CY4PR0701MB3635; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY4PR0701MB3635; X-Forefront-PRVS: 0518EEFB48 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(376002)(346002)(366004)(377424004)(199004)(189003)(24454002)(52164004)(52314003)(8676002)(6512007)(53546010)(8936002)(65826007)(81156014)(5660300001)(2950100002)(6916009)(6666003)(54906003)(4326008)(36756003)(305945005)(58126008)(25786009)(50466002)(81166006)(42882006)(229853002)(97736004)(64126003)(7736002)(59450400001)(93886005)(16526018)(66066001)(65956001)(65806001)(47776003)(316002)(107886003)(2906002)(31686004)(53416004)(105586002)(33646002)(230700001)(106356001)(53936002)(67846002)(68736007)(3846002)(6116002)(6246003)(23676004)(52146003)(72206003)(69596002)(52116002)(76176011)(6486002)(478600001)(31696002)(6506006)(83506002)(55236003)(2486003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR0701MB3635; H:hyd1ajoseph-dt.caveonetworks.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjA3MDFNQjM2MzU7MjM6OHJLOU81YmtCOXJZajRZcXhQdS9xK2Nh?= =?utf-8?B?QVgxMHNBcG9mcXRnNnBBekhHZEtIajJmcnJmMWtRT1drcGpwSDFOMzVLZlho?= =?utf-8?B?a2JwV2Y0K0tYWnIxelkyWDJDU29ZdlBVKy80UDF6cU80NE1ETEFTMGxyNXhH?= =?utf-8?B?a1FvOWZFM1R5SE1QS3J6TlR0bEgwZ2t5dXZ2ZWdqSGVlU2RBSDBDUG9oVmtP?= =?utf-8?B?aU5zK2NwYmlTQWR5ZGgzeHFJZ1dxb3RFVXVKREZWNTlTWnZsWHorbWlJNUJK?= =?utf-8?B?K29tK1JTL3hwczg4enRRYTlSUWZpK2hLMzlNaWlWTllKdWdHbGZNbDVGYUg1?= =?utf-8?B?TW9YeDIwNG9XRWcyQVNJRDdKcGtlMmNuQ2Qzd1NpTGZkVGtmOUozeEcxcTZC?= =?utf-8?B?Y0w2VDZIcjZrTFZpbFU2K2t3eW9nMGZObnNSUDF1RitrL3RodEZLQy8wa1d6?= =?utf-8?B?SXJ6ZzNYbVJ0U2tIL1VlVTBJenB5cmFvaGZoM01uRWgxRFBVdnQvR3doQTZY?= =?utf-8?B?OFF5WHdmSCtjQ2RMK21OTDlkTEtBTTZrLzdaemRISE5YYmZJMUlCV3kxSlQ3?= =?utf-8?B?MXR6amp0NzNGcHUwTnZFa3dDenVKdnltbEJjcWJGYlgyVHQ2QmlEZ2JnRnpF?= =?utf-8?B?RHp5b0VhclF4ZVRCeTZHTjRrMVdiS09Xb2lETzRZTzlyOGhoOWp0andOQ0Fr?= =?utf-8?B?dVhKWXZPSThUTXRhYVNkSjFOU3RXZzVYYXZyNUNGZjREcEpyQXhxak16akJo?= =?utf-8?B?ZmNUL20zM3N3RnZoeldwdm5EaTNFajFZOXFaQkRTRzdqRHpTNWR1a25WenJX?= =?utf-8?B?RW1HeGFaMy9vcHBjaXBJckVISklURE1OeVAwV0xET3NiT1YrNzBscUVtVktR?= =?utf-8?B?T0xReWVSeVRtckdpUTcwMVV1YXNjUzhNYk5LYWN0dUQyVm1hWVArQmxQSmxF?= =?utf-8?B?dG9rY2NUS3diR29DQWJuVFFOVUorMGhkVnVGWlJpbGQra3pMcnQwVVNQME04?= =?utf-8?B?b1lieUdNZWdjMUJVYVg4MEp1UittdHJtZkc0MjV3OGk4b0ZhaFB4NVhEaVRx?= =?utf-8?B?dmZPYklqOHh6ZlI0ODVKbURTRXNUQkpaWGtuTEdMRmx1Q04vZ3pPcGhLenN6?= =?utf-8?B?MzU3Rzg5R1FrU2RqYnZKMHBJWkxWSWpuSDNDaTJ2SWxDZ3NhVktLMDE4SG9L?= =?utf-8?B?R3JXeUxRTDhjZXk0NmloR2NwTDVWR1d6N1dyLzZqd3FZaVdRdFFHTDRzV1RV?= =?utf-8?B?NEJrS0VQeUhUMll2cExCNHZjbVNCUjErenBYOGxOenVCYk9NcVdJOUpzNitv?= =?utf-8?B?dU0wZ2ZSM2pMVStCOWc2eUxneDF0WVVsYlFQTERqQlJwSGFLSDZQUW9pTnlm?= =?utf-8?B?R0lVVVpuZDFLNlllM3JHUFh0cU92Ky81VU1nVG5OVitsbmRMMkpHK2JWZWRq?= =?utf-8?B?MUlZbmxqL0pqQXRBMDRkQXA4RUtZRzZvYkRBRjhlNU5uSmVqME1oY3hJbXRO?= =?utf-8?B?SWpLMUpZMUwyaG5sQ2NIYUx6Z290VEV5eWFUUk1OQnpHV1k0NkpzdTFXaVN1?= =?utf-8?B?THh2L3BrVUxRYTNGVmk2Z0grTEtNNUZKK2N1WlZYQ1FldzRrWENtdXYzYjhF?= =?utf-8?B?SjR2a3I4V1RwUFhETy9jank1L2h0dnBwOWFweHF2cUVhQTBWZnM3azFuZDNl?= =?utf-8?B?UXVkUnpycDFLT0ZmakNKMDBUREUrQk0vZ0pUM09vUFlidXIzdUIra1prd0Fi?= =?utf-8?B?ZDloNDBIZnZhbjJ5YnVHVjJmRjVnek14R0o3Z1UwUW4zNkQ3cG1XdVV3SENR?= =?utf-8?B?ZzdCYkFOYTYrT3k2VlFrWkdFMXR0OWNUd2dSMVN1N05aOXBJWFBMUnhMUEdz?= =?utf-8?B?RWV5aGRMMXl4c1hSK3FOdGl6bkZ1SjZaaEV6SWRya056YWNNV0xCMWlYNHd3?= =?utf-8?B?ME5zYU5LTU9uZHpjand1NElycGF5MHZiN0x5NjZ2RHFIMjEzMExOaDZYMTJ5?= =?utf-8?B?RWE5eThWazVjTVFPN21YZzJuUmc0Wlh2NHJQSTIyQXh0Mld1Q3NpeFVNTGRD?= =?utf-8?B?MnR3d3ZtSHMxUFFqc0Z5RkpFTWtOcEpyNFZoY1ZseTA4a0FocWRLMXdFRmx0?= =?utf-8?B?TFV3WmlKVTNnbERPTjRvVWhxR0pUU203Wk1RRmFSRlJ3U1ZrbFE1TzdEREkv?= =?utf-8?Q?qhAQ6KyFsIxfOrdwHWlfuMTYqXBsCYMKKxXbnob/ye8E=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR0701MB3635; 6:wgmdejTFwXmafynK0geu6Sx/wS6QtcqlBvLPNNf+Kd729IbTn0yAjSpPcL9vPnBaSs6VRK/MUjCbydv+Bx+ZzFOoaAUp2GavaRF6ad+evKA5SecVqF4nnvfUo2LE+HKi2+Smv5kQseqmfbaWwU23IY9NqgWzhxtOBX82HIuXTv2j/rcpecsZNaY8f8BKqOl7BKFKOR8kQA7cLl6IvFbinAr2Wf4vzab1l3H2EaWDlLfrJAmoppvx+5fR4XPSmW3999AB4hTyJiaqHnUYO+RfOxeTHWsS/HqHBZLFPAq/Tk9X+2+XKMu/1VxiFBI80kknO4HcHKVX3QcdK6s+IBsXkVaM5IM0nwR6F+ec0gOdV6U=; 5:t0kemIS88I0mGnvW1Uke7ggZXJ+EGbkChXMaY9F1tbT+3LpQme4s1JOfeacJMv8YHDyMFq+YmgN8bIP54K7Nxw6traQDRK7VoRp9ypP2r7tIJrr1QbuudO0VBnllGM9TAEO68l5K+6wHU8nR0WRODdOhaKaEkBIHsnSgljz+I9I=; 24:4c067pLF/r5uIMMca5s8p+BxaODsU83U+56mCxIjK0TjswarySWVcp7PxFmvuHRBk9ckxn6sFB+T1VCYzYzp8gGJ5oCAckuP3mYfUO2N09Y=; 7:ogYSWjPed9dqub8Z94z7voz5cxNtfhBxWLpFjirhYL4Mxzyi3wfxbF2inOqdphF4as5q0pCYOCAiWVWcvfaMbJvLrKWuLIOq2kh3Z6Dg657/08KLLeOEn9GcAInZSlrBnLewpLOP/sGzuE/8EvbJAatX62KlI1r6+yeHaq88sms8T5AfhQwk3wErmyjB7a+K+piVBCr2UIJtsmreGScz9SxjDLi7p7NjRXqrk9q93zEh5q8kttzjbP/bctIoDX9P SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2017 09:00:13.3301 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40c9f506-bd6e-438b-bf5a-08d540759872 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0701MB3635 Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add target queues in flow actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 09:00:17 -0000 Hi Nelio, On 12/11/2017 01:51 PM, Nelio Laranjeiro wrote: > Hi Anoob, > > On Fri, Dec 08, 2017 at 10:10:28PM +0530, Anoob Joseph wrote: >> HI Nelio, >> >> >> On 08-12-2017 20:10, Nelio Laranjeiro wrote: >>> On Fri, Dec 08, 2017 at 07:30:03PM +0530, Anoob wrote: >>>> Hi Nelio, >>>> >>>> >>> [...] >>>>> + goto flow_create; >>>>> + /* Try Queue. */ >>>>> + for (i = 0; >>>>> + i < eth_dev->data->nb_rx_queues; ++i) >>>>> + if (eth_dev->data->rx_queues[i]) >>>>> + break; >>>> Is the following check correct? >>> [...] >>> >>> For an application, it seems not necessary. The application knows which >>> queues are configured in the drivers has it has made the configuration. >>> >>> Removing it in the v3. >> I think you misunderstood me here. > Indeed, I misunderstood, > >> I was talking about the following line. >> >> + if (i != eth_dev->data->nb_rx_queues) >> + return -1; >> >> Shouldn't it be? >> >> + if (i == eth_dev->data->nb_rx_queues) >> + return -1; > Yes it should. > > Anyway, I don't thing it is necessary to keep this check, from what I > saw in the application source code, it initialise all Rx queues up to > nb_rx_queues without leaving any hole. > According to this, I'll just remove this verification, is it okay for > you? I think you can just use Queue 0 here. So you can get rid of the checks etc. For real applications, we should have an entry in SA structure which will determine the Queue to be used. Even for RSS, something like that would be required. Thanks, Anoob