From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D42357CBF for ; Mon, 29 May 2017 19:43:49 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2017 10:43:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,415,1491289200"; d="scan'208";a="267757269" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by fmsmga004.fm.intel.com with ESMTP; 29 May 2017 10:43:48 -0700 To: Ajit Khaparde , dev@dpdk.org Cc: Stephen Hurd References: <20170526183941.80678-1-ajit.khaparde@broadcom.com> <20170526183941.80678-21-ajit.khaparde@broadcom.com> From: Ferruh Yigit Message-ID: <3d568535-8eda-d79f-bbe5-43f9f1071184@intel.com> Date: Mon, 29 May 2017 18:43:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170526183941.80678-21-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 17:43:50 -0000 On 5/26/2017 7:39 PM, Ajit Khaparde wrote: > This patch adds code to get and clear VF stats. > It also adds the necessary HWRM structures to send the command > to the firmware. > > Signed-off-by: Stephen Hurd > Signed-off-by: Ajit Khaparde > > -- > v1->v2: regroup related patches and incorporate other review comments > --- > drivers/net/bnxt/bnxt_hwrm.c | 38 ++++++++++++++++++ > drivers/net/bnxt/bnxt_hwrm.h | 3 ++ > drivers/net/bnxt/rte_pmd_bnxt.c | 87 +++++++++++++++++++++++++++++++++++++++++ > drivers/net/bnxt/rte_pmd_bnxt.h | 64 ++++++++++++++++++++++++++++++ > 4 files changed, 192 insertions(+) It looks like new APIs not added into .map file. This doesn't cause a build error because they are not used anywhere, that is why using testpmd to implement them helps to find any issues. <...> > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > +{ > + struct rte_eth_dev *dev; > + struct rte_eth_dev_info dev_info; > + struct bnxt *bp; > + > + dev = &rte_eth_devices[port]; > + rte_eth_dev_info_get(port, &dev_info); > + bp = (struct bnxt *)dev->data->dev_private; > + > + return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count); > +} This function is not to get VF stats from PF. As far as I can see this just gets queue stats, does this really needs to be PMD specific API, isn't this something generic? <...>