From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48A05A00C2; Thu, 6 Oct 2022 09:10:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3A8674280E; Thu, 6 Oct 2022 09:10:29 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 064CA41153 for ; Thu, 6 Oct 2022 09:10:28 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8B98D67; Thu, 6 Oct 2022 10:10:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8B98D67 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1665040227; bh=hNxe63maYt0kjsyC4atzdJrYtowStnVWdQ/8S4kkYF4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HBFU34DIFT5ZlyRoTaJjmpjmLydvkT6a62wTI6k0QyoTGLquV/Voo1qDraWM5Wveg DdPnVrLvhb9/4IJQIOUTDDMk0TAegERg4JZW3itJx5RAQ2Fpuk07S2FuWvmv24g+P/ NvagKPRLzOLekv2BCbrTMjB99Ceg7Lqr3ImkpaYw= Message-ID: <3d66f2b3-b377-89c5-5cbd-636afd823e97@oktetlabs.ru> Date: Thu, 6 Oct 2022 10:10:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 0/4] add trace points in ethdev library Content-Language: en-US To: Ankur Dwivedi , dev@dpdk.org Cc: thomas@monjalon.net, mdr@ashroe.eu, orika@nvidia.com, ferruh.yigit@xilinx.com, chas3@att.com, humin29@huawei.com, linville@tuxdriver.com, ciara.loftus@intel.com, qi.z.zhang@intel.com, mw@semihalf.com, mk@semihalf.com, shaibran@amazon.com, evgenys@amazon.com, igorch@amazon.com, chandu@amd.com, irusskikh@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, jerinj@marvell.com, mczekaj@marvell.com, sthotton@marvell.com, srinivasan@marvell.com, hkalra@marvell.com, rahul.lakkireddy@chelsio.com, johndale@cisco.com, hyonkim@cisco.com, liudongdong3@huawei.com, yisen.zhuang@huawei.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, simei.su@intel.com, wenjun1.wu@intel.com, qiming.yang@intel.com, Yuying.Zhang@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, jingjing.wu@intel.com, junfeng.guo@intel.com, rosen.xu@intel.com, ndabilpuram@marvell.com, kirankumark@marvell.com, skori@marvell.com, skoteshwar@marvell.com, lironh@marvell.com, zr@semihalf.com, radhac@marvell.com, vburru@marvell.com, sedara@marvell.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, spinler@cesnet.cz, chaoyong.he@corigine.com, niklas.soderlund@corigine.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, g.singh@nxp.com, apeksha.gupta@nxp.com, sachin.saxena@nxp.com, aboyer@pensando.io, rmody@marvell.com, shshaikh@marvell.com, dsinghrawat@marvell.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, jbehrens@vmware.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, steven.webster@windriver.com, matt.peters@windriver.com, bruce.richardson@intel.com, mtetsuyah@gmail.com, grive@u256.net, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, jgrajcia@cisco.com References: <20220804134430.6192-1-adwivedi@marvell.com> <20220929102936.5490-1-adwivedi@marvell.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220929102936.5490-1-adwivedi@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/29/22 13:29, Ankur Dwivedi wrote: > This series adds trace points for functions in the ethdev library. > The trace points are added in ethdev, flow, mtr and tm files. > > v2: > - Made rte_eth_trace_call_rx_callbacks and rte_eth_trace_call_tx_callbacks > as fastpath trace functions. > - Moved some trace functions call to the end to capture return value and > data. Looking at the patch series I still see many-many places where tracing happens on entry point. Intentional? > - Removed rte_eth_trace_tx_queue_setup as it is not required. > rte_ethdev_trace_txq_setup() is already present in > rte_eth_tx_queue_setup(). > - Removed trace in ethdev_driver.c > - Removed trace function check patch. > > Ankur Dwivedi (4): > ethdev: add trace points > ethdev: add trace points for flow > ethdev: add trace points for mtr > ethdev: add trace points for tm > > lib/ethdev/ethdev_private.c | 3 + > lib/ethdev/ethdev_trace_points.c | 699 ++++++++++ > lib/ethdev/rte_ethdev.c | 148 +++ > lib/ethdev/rte_ethdev_trace.h | 2062 ++++++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev_trace_fp.h | 19 + > lib/ethdev/rte_flow.c | 54 + > lib/ethdev/rte_mtr.c | 27 + > lib/ethdev/rte_tm.c | 40 + > lib/ethdev/version.map | 232 ++++ > 9 files changed, 3284 insertions(+) >