From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C67A04AD; Wed, 19 Jan 2022 14:07:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34E114114E; Wed, 19 Jan 2022 14:07:07 +0100 (CET) Received: from sheloe.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 74B6D41147 for ; Wed, 19 Jan 2022 14:07:06 +0100 (CET) Received: by sheloe.oktetlabs.ru (Postfix, from userid 115) id D809E42; Wed, 19 Jan 2022 16:07:05 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mail1.oktetlabs.ru X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_DISCARD autolearn=no autolearn_force=no version=3.4.6 Received: from bree.oktetlabs.ru (bree.oktetlabs.ru [192.168.34.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by sheloe.oktetlabs.ru (Postfix) with ESMTPS id 70CEE38 for ; Wed, 19 Jan 2022 16:07:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 sheloe.oktetlabs.ru 70CEE38 Authentication-Results: sheloe.oktetlabs.ru/70CEE38; dkim=none; dkim-atps=neutral Date: Wed, 19 Jan 2022 16:07:05 +0300 (MSK) From: Ivan Malov To: dev@dpdk.org Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints Message-ID: <3d9945a0-bca4-559-88a1-864d90a11b44@oktetlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > +Rules management configuration > +------------------------------ > + > +Configure flow rules management. It is either "management OF ruleS" or "rule management". Perhaps fix similar occurrences across the series. > + /** > + * Number of counter actions pre-configured. > + * If set to 0, PMD will allocate counters dynamically. > + * @see RTE_FLOW_ACTION_TYPE_COUNT > + */ > + uint32_t nb_counters; > + /** > + * Number of aging actions pre-configured. > + * If set to 0, PMD will allocate aging dynamically. > + * @see RTE_FLOW_ACTION_TYPE_AGE > + */ > + uint32_t nb_aging; > + /** > + * Number of traffic metering actions pre-configured. > + * If set to 0, PMD will allocate meters dynamically. > + * @see RTE_FLOW_ACTION_TYPE_METER > + */ > + uint32_t nb_meters; If duplication of the same description is undesirable, consider adding a common description for these fields: /** * Resource preallocation settings. Use zero to * request that allocations be done on demand. */ Instead of "nb_aging", perhaps consider something like "nb_age_timers". > + * Configure flow rules module. > + * To pre-allocate resources as per the flow port attributes > + * this configuration function must be called before any flow rule is created. > + * Must be called only after Ethernet device is configured, but may be called > + * before or after the device is started as long as there are no flow rules. > + * No other rte_flow function should be called while this function is invoked. > + * This function can be called again to change the configuration. > + * Some PMDs may not support re-configuration at all, > + * or may only allow increasing the number of resources allocated. Consider: * Pre-configure the port's flow API engine. * * This API can only be invoked before the application * starts using the rest of the flow library functions. * * The API can be invoked multiple times to change the * settings. The port, however, may reject the changes. -- Ivan M.