From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: David Christensen <drc@linux.vnet.ibm.com>, dev@dpdk.org
Cc: thomas@monjalon.net, david.marchand@redhat.com,
viktorin@rehivetech.com, ruifeng.wang@arm.com,
jerinj@marvell.com, bruce.richardson@intel.com,
konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros
Date: Thu, 3 Sep 2020 10:48:35 +0100 [thread overview]
Message-ID: <3da14380-51dc-5bb0-05fb-1d71162ecd08@intel.com> (raw)
In-Reply-To: <c516800f-bd44-cf74-48c9-6905d1912303@linux.vnet.ibm.com>
On 9/2/2020 5:57 PM, David Christensen wrote:
> On 9/2/20 3:43 AM, Radu Nicolau wrote:
>> Remove RTE_MACHINE_CPUFLAG_ macros from the build.
>> Deprecation notice sent, pasted here for reference:
>>
>> build macros: The macros defining RTE_MACHINE_CPUFLAG_* will be
>> removed
>> from the build. The information provided by these macros is available
>> through standard compiler macros. For example,
>> RTE_MACHINE_CPUFLAG_SSE3
>> duplicates the compiler-provided macro __SSE3__.
>>
>> Radu Nicolau (4):
>> x86: change cpuflag macros to compiler macros
>> arm: change cpuflag macros to compiler macros
>> ppc: change cpuflag macros to compiler macros
>> doc: remove reference to RTE_MACHINE_CPUFLAG
>
> I'm not too familiar with clang and icc. Do all compilers use the
> same macro definitions for the same CPU features? I would have
> thought the RTE_* definitions were there because there are compiler or
> compiler version differences that need to be supported.
>
> Dave
All supported compilers should have these defines, and the
RTE_MACHINE_CPU macros were defined based on the compiler defined
macros, as an unnecessary extra step.
Furthermore, as per Bruce's comment, new features will be easily
implemented directly in the relevant sections without needing to update
the build system.
next prev parent reply other threads:[~2020-09-03 9:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 10:43 Radu Nicolau
2020-09-02 10:43 ` [dpdk-dev] [PATCH v1 1/4] x86: change cpuflag macros to compiler macros Radu Nicolau
2020-09-02 11:20 ` Bruce Richardson
2020-09-23 10:44 ` [dpdk-dev] [PATCH v2 0/4] Remove RTE_MACHINE_CPUFLAG_ macros Radu Nicolau
2020-09-23 10:44 ` [dpdk-dev] [PATCH v2 1/4] x86: change cpuflag macros to compiler macros Radu Nicolau
2020-09-23 15:11 ` David Marchand
2020-09-23 10:44 ` [dpdk-dev] [PATCH v2 2/4] arm: " Radu Nicolau
2020-09-23 15:11 ` David Marchand
2020-09-23 10:44 ` [dpdk-dev] [PATCH v2 3/4] ppc: " Radu Nicolau
2020-09-23 10:44 ` [dpdk-dev] [PATCH v2 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG Radu Nicolau
2020-09-24 8:18 ` [dpdk-dev] [PATCH v3 0/4] Remove RTE_MACHINE_CPUFLAG_ macros Radu Nicolau
2020-09-24 8:18 ` [dpdk-dev] [PATCH v3 1/4] x86: change cpuflag macros to compiler macros Radu Nicolau
2020-09-24 8:18 ` [dpdk-dev] [PATCH v3 2/4] arm: " Radu Nicolau
2020-09-24 8:18 ` [dpdk-dev] [PATCH v3 3/4] ppc: " Radu Nicolau
2020-10-05 19:43 ` David Christensen
2020-09-24 8:18 ` [dpdk-dev] [PATCH v3 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG Radu Nicolau
2020-09-25 9:18 ` [dpdk-dev] [PATCH v3 0/4] Remove RTE_MACHINE_CPUFLAG_ macros David Marchand
2020-09-02 10:43 ` [dpdk-dev] [PATCH v1 2/4] arm: change cpuflag macros to compiler macros Radu Nicolau
2020-09-02 10:43 ` [dpdk-dev] [PATCH v1 3/4] ppc: " Radu Nicolau
2020-09-02 10:43 ` [dpdk-dev] [PATCH v1 4/4] doc: remove reference to RTE_MACHINE_CPUFLAG Radu Nicolau
2020-09-02 11:21 ` Bruce Richardson
2020-09-02 16:57 ` [dpdk-dev] [PATCH v1 0/4] Remove RTE_MACHINE_CPUFLAG_ macros David Christensen
2020-09-03 9:48 ` Nicolau, Radu [this message]
2020-09-15 14:28 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da14380-51dc-5bb0-05fb-1d71162ecd08@intel.com \
--to=radu.nicolau@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).