From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95D374342E; Thu, 7 Mar 2024 14:27:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F36D4067E; Thu, 7 Mar 2024 14:27:06 +0100 (CET) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 32C8C40272; Thu, 7 Mar 2024 14:27:03 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Tr9532x3rz1Q9lk; Thu, 7 Mar 2024 21:24:39 +0800 (CST) Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10]) by mail.maildlp.com (Postfix) with ESMTPS id D5EBA1A016C; Thu, 7 Mar 2024 21:27:01 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 7 Mar 2024 21:27:01 +0800 Subject: Re: [PATCH] doc: update size parameter details To: Vipin Varghese , , , References: <20231212104508.1941-1-vipin.varghese@amd.com> From: fengchengwen Message-ID: <3dc0dccf-190c-0588-1927-ecb865400d30@huawei.com> Date: Thu, 7 Mar 2024 21:27:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20231212104508.1941-1-vipin.varghese@amd.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500024.china.huawei.com (7.185.36.10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Vipin, On 2023/12/12 18:45, Vipin Varghese wrote: > For configuration parameters `mem_size` and `buf_size` are represented > as megabytes and bytes respectively in application. Update the > documentation to represent the same. > > Signed-off-by: Vipin Varghese > --- > doc/guides/tools/dmaperf.rst | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/tools/dmaperf.rst b/doc/guides/tools/dmaperf.rst > index 9e3e78a6b7..6f85fceb8a 100644 > --- a/doc/guides/tools/dmaperf.rst > +++ b/doc/guides/tools/dmaperf.rst > @@ -74,10 +74,10 @@ Configuration Parameters > Currently supported types are ``DMA_MEM_COPY`` and ``CPU_MEM_COPY``. > > ``mem_size`` > - The size of the memory footprint. > + The size of the memory footprint in megabytes (MB) for source and destination. I prefer not add "for source and destination", it makes sense without this, and maybe future test like fill don't have source buffer. > > ``buf_size`` > - The memory size of a single operation. > + The memory size of a single operation in bytes (B). > > ``dma_ring_size`` > The DMA ring buffer size. Must be a power of two, and between ``64`` and ``4096``. > BTW: Could you please also modify the app/test-dma-perf/config.ini (which also missing this) Thanks