From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 36013137C for ; Thu, 3 Nov 2016 21:48:08 +0100 (CET) Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FB56C04B924; Thu, 3 Nov 2016 20:48:07 +0000 (UTC) Received: from [10.36.6.90] (vpn1-6-90.ams2.redhat.com [10.36.6.90]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3Km4YC021517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Nov 2016 16:48:06 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478189400-14606-4-git-send-email-yuanhan.liu@linux.intel.com> From: Maxime Coquelin Message-ID: <3dcee423-4cad-3de2-2593-51415d8e8d7d@redhat.com> Date: Thu, 3 Nov 2016 21:48:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478189400-14606-4-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 03 Nov 2016 20:48:07 +0000 (UTC) Cc: Ilya Maximets Subject: Re: [dpdk-dev] [PATCH 3/8] net/virtio: simplify queue allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 20:48:08 -0000 On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > Let rxq/txq/cq be the union field of the virtqueue struct. This would > simplifies the vq allocation a bit: we don't need calculate the vq_size > any more based on the queue time. s/time/type/ ? > > Signed-off-by: Yuanhan Liu > --- > drivers/net/virtio/virtio_ethdev.c | 18 +++++++----------- > drivers/net/virtio/virtqueue.h | 7 +++++++ > 2 files changed, 14 insertions(+), 11 deletions(-) Other than that: Reviewed-by: Maxime Coquelin Thanks, Maxime