From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1550F6CC3 for ; Fri, 27 Apr 2018 15:41:03 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2018 06:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,335,1520924400"; d="scan'208";a="51321085" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.25.158]) ([10.252.25.158]) by orsmga001.jf.intel.com with ESMTP; 27 Apr 2018 06:41:01 -0700 To: Reshma Pattan , john.mcnamara@intel.com, dev@dpdk.org Cc: jananeex.m.parthasarathy@intel.com References: <1524835241-12778-1-git-send-email-reshma.pattan@intel.com> From: "Burakov, Anatoly" Message-ID: <3dd747a8-f549-bd2f-8d2b-c4dbc10e11e2@intel.com> Date: Fri, 27 Apr 2018 14:41:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524835241-12778-1-git-send-email-reshma.pattan@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/test: enhance sanity script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 13:41:04 -0000 On 27-Apr-18 2:20 PM, Reshma Pattan wrote: > 1. Sanity Script is enhanced with additional test cases > being added to autotest_data.py > 2. Fixed in autotest_test_funcs.py to handle test cases > which returns "Skipped" as result. > The issue was skipped test cases got timed out, > causing delay in sanity script execution. > 3. Enhanced support for FreeBSD to add the respective memory limit, > as FreeBSD doesn't support socket-mem, file-prefix options. > > Signed-off-by: Jananee Parthasarathy > --- I don't think number 3 on that list is needed. FreeBSD doesn't support file-prefixes, so it's not possible to run multiple unit tests in parallel in the first place, so no need for grouping and no need to limit allocated memory. On a more general note, IMO this whole thing needs to be redone and simplified. I wanted to fix all this as part of Memory Hotplug patches, but didn't get to it yet. (not to mention that this infrastructure itself is a lot like IVSHMEM, in that it was built to solve a specific problem, consequences be damned...) The reasoning behind splitting tests into groups was largely the fact that we had to preallocate memory, while also running tests in parallel. This is no longer needed for two reasons. First, most (if not all) tests now clean up properly after themselves (when this was written, it wasn't possible to un-reserve memzones, rings etc. - now it is), so we can run them one by one without restarting the test application. Second, memory is now allocated on the fly, so there is no more reason to split autotests into groups at all. Instead, we can just group all tests into "performance" (to be run one by one) and "non performance" (can be run concurrently via different prefixes), and run them with a pool of workers. For FreeBSD, since there's no dynamic memory allocation and no support for file prefixes, there needs to be only one worker, running all tests one by one. For Linux, you can add all unit tests into a queue, and use a pool of workers dequeuing and doing tests in parallel under different prefixes. No '-m' or '--socket-mem' switches needed. -- Thanks, Anatoly