From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F674A00C2; Thu, 10 Feb 2022 09:55:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 755B941181; Thu, 10 Feb 2022 09:55:04 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 9BA9D40041 for ; Thu, 10 Feb 2022 09:55:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644483302; x=1676019302; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=Kh0u+iba+IgTEoP3g592o1hKHZuOvBrGKr4vLSrWWAQ=; b=LdMKZHKcUa5HkVq0VUXrZR7s6OQPz2VJKOiB2GdbT5Dt86EqxxOx2hh5 CWkGiNbq2Fq2VwDQkbiFi9nftSipteioqS8wjwr/KHSvug0oQh/J3fV5y 7v+pe6uomKV58Vt42CUMw5XyWDcCJg+2X+mzzoJKExhzNZLknXyWb0xnx 6RgIDJdCqs3r3mkaE67tQwkaqe2MT6qrqdxzbovZsDBEUG5HToizrE2Lc yY/2pAiGF6ZKSafF4vmedeKT5In0OTt4Ka5rMgR+69Qz9PyxjpRlBdURK QxVTHz8TxqN/bW79HAQW7UW32NUUslIcxTyfv0QGfcek0uz1rr4xGzkjQ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="335857860" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="335857860" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 00:55:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="585891933" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 10 Feb 2022 00:55:01 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:55:00 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 00:55:00 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 00:55:00 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 00:54:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e11KqieXgvpOBIyFU5+Z+ZA8bC5Fn90bUr5NdxI9gMD5DZAiLTtZ87J/ueMCZcNMHzS97sEKsaZC7G422cVCjdBioz0dAnbvBCmorCsuFLAwG2uqqyZuNAHjgxZrx+wVpgfzLGbjVf5xZr1OSoP6ok/D0NKBGc0pK29kosKbC6VavMyW3Y5vfDvzgid8onjeo2yRr5SuJTQVA9Wc8w0eJtL0kWC5lD+bPwEFtlXLf8r3ERH84ftCXGla711OmCUyo5tZjDXKF6qkOyLiYD2vnSgw/xb3jwWv9jxDZ7+K4p8N6o5lRHO9+9HhJ3nsp8gBgmPcAQfvUEq/bI9hveB8Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kl8DCX6c/FMmmBWBGPCi8otxCVjxVOmYNNcJ6+DZa9I=; b=FGy9hQw3iatQvuP09azfvY/DXHgT3Xg8MJDlxpF7un9ZZMCMNR6x4j/Fy7dW6mGTrTIWD0VD6IkYLZfBC1g5qA6K0nUwzaPwgmRbDX6VRRqRhU+iLfWWI2koTx0qQrWEdmQfg5zFoybl0ZZYXLzkwx2oQ4Xufs7ZE6eIqoehwJhVnh6UHjboi8OjxgAw9pJlFvEPJIzvP2j0qxAOIxrZ4qMbB+Rx/Q8kG4alIY9qLEYtKwvR4BryDOzBYR+0jwUhgI11dcaKSQ1de4CfjvvOdhBhw0gpPZiyY7M9CFDzZGHt9mscJv3Oqr57BkrX+s/buO5G1qPo2Dqj4RtybyZCKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SN6PR11MB3374.namprd11.prod.outlook.com (2603:10b6:805:c5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 08:54:57 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 08:54:57 +0000 Message-ID: <3ddcd5a8-47ea-d474-b409-90520dcad93f@intel.com> Date: Thu, 10 Feb 2022 08:54:48 +0000 Content-Language: en-US To: Akhil Goyal , CC: , , , , , , , , , , , References: <20220208201111.420971-1-gakhil@marvell.com> <20220208222027.1364292-1-gakhil@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v6 0/3] ethdev: introduce IP reassembly offload X-User: ferruhy In-Reply-To: <20220208222027.1364292-1-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0601CA0026.eurprd06.prod.outlook.com (2603:10a6:4:17::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 996bf533-aef4-4bf6-fe34-08d9ec730391 X-MS-TrafficTypeDiagnostic: SN6PR11MB3374:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +u0KR38Ljv13GBJhnBeJga9X5Xdnu5LqOjIEBMbpfKWKlrzUeroqRCNGdsmdgRuVz96vDxmVJNHTQDw3DVCdqxYbVGmKMwbxTDzAbkqFxBDPtr9sEZ9SoB/s9jmYoMBNertx6HBXm8dRnBk0hmoXyrqNnNV6+b3GAMcvkUQV1YHr7ubtKBtGISNsq085oax2DGrqobQRas3PsDm6uMBDVUoeKvLm275UkAbclpY6+tIPHbJV4ypNcB+setmEFo9O5EUjgSwW4sY/OFZelbVbp2ttWpkpuchoq44v9XH8SbXZuJSC2Bmi3s8ke4/DnftO7Effb35jn0rLkk+pgq79kcDyEtOuowx5YRthu6L3LwRn89nY9cy2D9aBLIPoYfPsdl53q+veqNVXc4D5IgoLxgMFTcL3A5qPaB22fkB79Pm6mof4l06zNUwz7dvrfFVByA8YeF13HyM+fGCFC/aqcIW3DCE9ylbo76xcgwtcETLoIM3haOReJGqeB1RlmSt6nyrCaUVmwgeUth3DZLa+yvGumWQWBOMEkWS7lxnN1SKJc3305aVOo3Q18euzE7h7OQ0uNjP30ynvoburGUSUKFa1UCEfTMUMtLiw+le0qQ90zrMj+Fkz5nVGNVY8HLZilW3z6XDMFHbJ0Q7IKNRzzOHfteRRWD/UbMrQWowOYx7bFwn9xcmuGTmk+vQE1ZjlwDEYAroP3QNHb1qg5olWHXfpPzvOqRwCSuFgE70VeAAyo7mVZkyiE8bX8q1A43cZ4wz8990yjkAQ0y+QmC+v0Crdst300zTnoEz6nIQpz7gsZp6zYe3Zrlp7JzFCB47qdEzf9QGs61b7yamstNHu7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(26005)(186003)(508600001)(6486002)(2616005)(6512007)(7416002)(31686004)(38100700002)(66556008)(966005)(4326008)(8676002)(66946007)(66476007)(44832011)(5660300002)(316002)(6666004)(36756003)(31696002)(83380400001)(6506007)(2906002)(86362001)(8936002)(53546011)(82960400001)(55236004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXpSVXFHajZiQWYrTkd6WHdkRVNGUkdsS3I0cFBuV0U2VlM1dzNzb3pwdU1r?= =?utf-8?B?MVRueFliWEQzUHVvcHFFQUFCTVNhcDlrWEtWSEZ0WXJzZUs1QmU1eTlKMmNB?= =?utf-8?B?b2dkUkVHdkJmS2xKTG0xUVhMNUFYT1BlZVc4S1p3cFBPWFE0WlNTMVU2OHRL?= =?utf-8?B?K3Zuak9HamRHcEozSzJzb0ozcXZyNlUxSzBwVmRTNGNUamI3UTFMZkNnbk5Q?= =?utf-8?B?dXpPUGttOXhGLzlhQkZIa1liaEhRc3c0RnlGWFFidVZ2UzdiaDVLRXVoU0lW?= =?utf-8?B?WjNCdlU0S09oSElPZldpT0lkZW4rTGd0WjBCT0JoZElNQ1g2Z241bHA5WElp?= =?utf-8?B?R3NZc2JpN2pVc1ZLemU4SG5FZTZtZURXelZDekM5OFpUQXpVZ0IwQWV6bDRo?= =?utf-8?B?QXRBZjJldStpVVJKRDd3bW5WcE1wVXEzVjJvSjVpYTFoSGhMU2NPbHByQzh3?= =?utf-8?B?b2VCNXZZemNoMm5MWG5BT0FpYTZ2eTcwTGlITUUrU3RWN2tsK1RLWmNYL0Fo?= =?utf-8?B?azN2UEc5ZTJPaG9vL2dmM1FNTzBHM2w0WEszRVlBTUYxY3FRSGtBblI5VWFG?= =?utf-8?B?dVFMaEtDM00zeTBqQ2NkbE8xZzJjYWNUT3kxc0dJNnpxNmFHTzlrd2ZKcENV?= =?utf-8?B?MkszeWIxOU92Y3FTRFM5Qk1CM2xJKzhuRGROUzNNdVdvRDNXK0drMDY5a1Z0?= =?utf-8?B?MmV2TXR2WVRPaUdTNm90MW9oRjVaNldHRzFXeUdQZFVRem5JMjEyM3JnYVQ2?= =?utf-8?B?MFl2a3k1Qmh2SDFhRVJuK1JKY0dqejVTdXpFUElJVzJlUktLV1RUUzJNSE9D?= =?utf-8?B?cEt4VFVaSzNTOWJabGNaMzYyVFdUUXdsUEp5UlVrNHhsMlFEb1hEdG9Xck5v?= =?utf-8?B?SG56Q0JwQkF0VTdIMGYxb1dZWGhsUEZwSWpVSTE5c1orTlFDZzNndkdMNUtl?= =?utf-8?B?VlJzUlBFaWdVU1o5U2R5TURZdzV3dENYZEVPTVczRmpXMG85dzd5bnVaTmtU?= =?utf-8?B?SDMwUjlyYjZxRXl5VFZ1MXhQNXgwR2lob2kxYzVDTG9MWi93RTdUYXFGMGFO?= =?utf-8?B?NE1PeUNoT1oyc3M3bkhPNW81VnU3Zmp0ZmpzcmtBNWhqdnVPVDJQTnJzazhQ?= =?utf-8?B?cWRyejJmSEhTS1kyeHJqN1N1Ri9VdkFwV1pPY2lsbzI2bGh0ZEt1SHlUUmxr?= =?utf-8?B?WkxhcU9sdmNJdWk3YW9tZm1IM0JtUngwSVdwWWw2KzNEcFZYaGlMQ3lsR0hl?= =?utf-8?B?M1pDQXN3amtwNVpJVWg4K08vSmpVTnI4MktYOWVDRWJyK2RnaW1FUEZuSU16?= =?utf-8?B?eE1JS2tTNDBSTm5uLzZYMjV4aThaTWlUSFhDeVlmOXNRK3hHOENsV2ZuSzdw?= =?utf-8?B?QUgyQkNEQXpoMGFWS1BiQkdxdEhKbDhZU0lzRlFLR3Q4Z0ZSVy85SlhVWm96?= =?utf-8?B?YStwQTc3eVMvR2xpOXZ4VnFwVUZXT2ZtMUVBeWFjMWRUTWUyaC9ZTlhneTM1?= =?utf-8?B?ZVNJT2NBakJjb2Q3WDI1dUtpbTY4bFlIWlRYTXhEYjB5UVRRb29jaU1TSk0w?= =?utf-8?B?cFAzNTIwQ0Y2VWVDUGxBZzBMYVNzUEMwUmMvZ0h6QW51bFdLMk1XbHFjOVN4?= =?utf-8?B?NjAwMjZzWUU2bHIxaUk2RlpTcFVPVk5CNC9FSGFaTDVKM1BINTlUVlgzUjBI?= =?utf-8?B?QkpKWFBSZXc4RmN2eDUzaS9jZ1h5RkhTUEd6YWRHRXhzWUVlWWlMTFU0OXdE?= =?utf-8?B?RzV3ZFpZOGNIbWRheHBXV3cvTGxjbmJwdFF5RUxrbC93VVRoei9IL1kwVU9L?= =?utf-8?B?cVRnR1kyZHB6cXJ6d2IvS2ZLRnk5MmdXRDIxWFlsalB1RWIyc3AxQUVLVDdq?= =?utf-8?B?eldoU3czVG5mVmN2NlF5em9yOE9nd2puSVRUeksvdXgwSlRzeDh4b1NKQjRs?= =?utf-8?B?akF5clFseGNab05FbXJ5QU0zNHFjZXM3Wkt6RWRQb2lieFdGd1MzR3JOSzFT?= =?utf-8?B?eWw5SEdjZC9PSGM2TGtuaDhTOVJDaTRSK2t6WlZybjZzd1BsUDhEU1VFV1Fp?= =?utf-8?B?Rnh2c3RFVEZGcGhvLzJFcWR5T2FlaEJPYmZpRE9CVjVuOE1mYmROa1paWXZV?= =?utf-8?B?emVLeGF6cGFyUTEwUzZtSFFqVmwwOGtoNWpQMVREYk02am1rek9VMStRNDBj?= =?utf-8?Q?uGFXiD2imuYKPAcJYw4mlOE=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 996bf533-aef4-4bf6-fe34-08d9ec730391 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 08:54:57.7585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +Ogx0GUHkcuzqiDQ3GRhrX8PrJUfmEM0q7e+1rYOI/VfMwBB9Nx+aTZAYHTH/HnZegUTxj/lWmyybpK5QcQjVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3374 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:20 PM, Akhil Goyal wrote: > As discussed in the RFC[1] sent in 21.11, a new offload is > introduced in ethdev for IP reassembly. > > This patchset add the IP reassembly RX offload. > Currently, the offload is tested along with inline IPsec processing. > It can also be updated as a standalone offload without IPsec, if there > are some hardware available to test it. > The patchset is tested on cnxk platform. The driver implementation > and a test app are added as separate patchsets.[2][3] > > [1]: http://patches.dpdk.org/project/dpdk/patch/20210823100259.1619886-1-gakhil@marvell.com/ > [2]: APP: http://patches.dpdk.org/project/dpdk/list/?series=21284 > [3]: PMD: http://patches.dpdk.org/project/dpdk/list/?series=21285 > Newer versions of app and PMD will be sent once library changes are > acked. > > Changes in v6: > - fix warnings. > > Changes in v5: > - updated Doxygen comments.(Ferruh) > - Added release notes. > - updated libabigail suppress rules.(David) > > Changes in v4: > - removed rte_eth_dev_info update for capability (Ferruh) > - removed Rx offload flag (Ferruh) > - added capability_get() (Ferruh) > - moved dynfield and dynflag namedefines in rte_mbuf_dyn.h (Ferruh) > > changes in v3: > - incorporated comments from Andrew and Stephen Hemminger > > changes in v2: > - added abi ignore exceptions for modifications in reserved fields. > Added a crude way to subside the rte_security and rte_ipsec ABI issue. > Please suggest a better way. > - incorporated Konstantin's comment for extra checks in new API > introduced. > - converted static mbuf ol_flag to mbuf dynflag (Konstantin) > - added a get API for reassembly configuration (Konstantin) > - Fixed checkpatch issues. > - Dynfield is NOT split into 2 parts as it would cause an extra fetch in > case of IP reassembly failure. > - Application patches are split into a separate series. > > > Akhil Goyal (3): > ethdev: introduce IP reassembly offload > ethdev: add mbuf dynfield for incomplete IP reassembly > security: add IPsec option for IP reassembly > Series applied to dpdk-next-net/main, thanks.