From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Li Zhang <lizh@nvidia.com>,
dekelp@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,
matan@nvidia.com
Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com
Subject: Re: [dpdk-dev] [RFC v2 1/1] app/testpmd: distinguish ICMP identifier fields in packet
Date: Tue, 22 Sep 2020 16:38:13 +0100 [thread overview]
Message-ID: <3def4458-0cb1-835e-1006-463ce4878361@intel.com> (raw)
In-Reply-To: <20200909033434.31059-1-lizh@nvidia.com>
On 9/9/2020 4:34 AM, Li Zhang wrote:
> From: lizh <lizh@nvidia.com>
>
> Ability to distinguish ICMP identifier fields in packets.
> Dstinguish ICMP sequence number field too.
> Already supports ICMP code and type fields in current version.
> Existing fields in ICMP header contain the required information.
> ICMP header already is supported and no code change in RTE FLOW.
> Extend testpmd CLI to include the fields of ident and sequence number.
> One example:
> flow create 0 ingress pattern eth / ipv4 /
> icmp code is 1 ident is 5 seq is 6 /
> end actions count / queue index 0 / end
> The ICMP packet with code 1, identifier 5 and
> sequence number 6 will be matched.
> It will implement action counter and forward to queue 0.
>
Overall looks good. @Ori, any objection?
@Li, is there any PMD implementation planned to use these icmp fields?
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 6263d307ed..6e04d538ea 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -143,6 +143,8 @@ enum index {
> ITEM_ICMP,
> ITEM_ICMP_TYPE,
> ITEM_ICMP_CODE,
> + ITEM_ICMP_IDENT,
> + ITEM_ICMP_SEQ,
> ITEM_UDP,
> ITEM_UDP_SRC,
> ITEM_UDP_DST,
> @@ -893,6 +895,8 @@ static const enum index item_ipv6[] = {
> static const enum index item_icmp[] = {
> ITEM_ICMP_TYPE,
> ITEM_ICMP_CODE,
> + ITEM_ICMP_IDENT,
> + ITEM_ICMP_SEQ,
> ITEM_NEXT,
> ZERO,
> };
> @@ -2193,6 +2197,20 @@ static const struct token token_list[] = {
> .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> hdr.icmp_code)),
> },
> + [ITEM_ICMP_IDENT] = {
> + .name = "ident",
> + .help = "ICMP packet identifier",
> + .next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> + hdr.icmp_ident)),
> + },
> + [ITEM_ICMP_SEQ] = {
> + .name = "seq",
> + .help = "ICMP packet sequence number",
> + .next = NEXT(item_icmp, NEXT_ENTRY(UNSIGNED), item_param),
> + .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_icmp,
> + hdr.icmp_seq_nb)),
> + },
> [ITEM_UDP] = {
> .name = "udp",
> .help = "match UDP header",
>
next prev parent reply other threads:[~2020-09-22 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 10:06 [dpdk-dev] [RFC] " lizh
2020-09-08 12:56 ` Thomas Monjalon
2020-09-09 3:41 ` Li Zhang
2020-09-09 3:34 ` [dpdk-dev] [RFC v2 1/1] " Li Zhang
2020-09-22 15:38 ` Ferruh Yigit [this message]
2020-09-23 2:39 ` Li Zhang
2020-09-23 9:04 ` Ferruh Yigit
2020-09-30 15:30 ` Ferruh Yigit
2020-09-09 3:49 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3def4458-0cb1-835e-1006-463ce4878361@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).