From: Ruifeng Wang <Ruifeng.Wang@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Thomas Monjalon <thomas@monjalon.net>
Cc: Luca Boccassi <bluca@debian.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Marchand, David" <david.marchand@redhat.com>,
nd@arm.com
Subject: Re: DPDK Release Status Meeting 2023-11-23
Date: Tue, 28 Nov 2023 13:53:35 +0800 [thread overview]
Message-ID: <3e0031d6-1d56-44e2-a3af-c383b176463e@arm.com> (raw)
In-Reply-To: <20231127091630.2b83425c@hermes.local>
On 2023/11/28 1:16 AM, Stephen Hemminger wrote:
> On Mon, 27 Nov 2023 11:13:16 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> ish.
>>>>>
>>>>> Due to a relative bigger RTE_MAX_LCORE value on ARM, the unit test case
>>>>> would take a longer time to finish iterations.
>>>>> In one of my run, the case took about 100s.
>>>>
>>>> Right, but this test is part of the "fast suite", and more than a
>>>> minute is not exactly fast. So one of the following should ideally
>>>> happen:
>>>
>>> Agree.
>>>
>>>> 1) Test is moved out of the fast suite
>>>> 2) Test has its individual timeout sized appropriately so that it
>>>> never fails regardless of the environment
>>>> 3) Test is capped so that it doesn't grow with the number of cores
>>>> without limits
>>>
>>> I'm for option 3. The case should be kept in fast suite. Time taken
>>> should be capped.
>>
>> More than 1 second is a bit slow.
>> Please make the test really faster.
>
> What is the test trying to exercise? Can it be done in another way?
The time consuming part is non-EAL test. It creates non-EAL threads
until filling up RTE_MAX_LCORE.
This part can be a separate case outside of fast suite.
prev parent reply other threads:[~2023-11-28 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 8:53 Mcnamara, John
2023-11-26 1:55 ` Ruifeng Wang
2023-11-26 12:44 ` Luca Boccassi
2023-11-27 2:51 ` Ruifeng Wang
2023-11-27 10:13 ` Thomas Monjalon
2023-11-27 17:16 ` Stephen Hemminger
2023-11-28 5:53 ` Ruifeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0031d6-1d56-44e2-a3af-c383b176463e@arm.com \
--to=ruifeng.wang@arm.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).