From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
Steve Yang <stevex.yang@intel.com>, <dev@dpdk.org>
Cc: <Yuying.Zhang@intel.com>, <qiming.yang@intel.com>,
<qi.z.zhang@intel.com>
Subject: Re: [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display
Date: Thu, 3 Feb 2022 13:15:55 +0000 [thread overview]
Message-ID: <3e27a961-a944-f3ea-e3cb-81880455e300@intel.com> (raw)
In-Reply-To: <261cd7e4-a166-bf48-98e0-8bf6e257a7b4@intel.com>
On 2/2/2022 10:00 AM, Singh, Aman Deep wrote:
> Hi Steve
> The patch looks ok to me.
>
> On 1/20/2022 8:29 AM, Steve Yang wrote:
>> When the size of EEPROM exceeds the default thread stack size(8MB),
>> e.g.: 10Mb size, it will be cashed with stack overflow.
> Just spelling: 10Mb/10MB, cashed/crashed
> Can even rephrase, like: it will crash due to stack overflow
fixed while merging
>> Allocate the data of EPPROM information on the heap.
>>
>> Fixes: 6b67721dee2a ("app/testpmd: add EEPROM command")
>>
>> Signed-off-by: Steve Yang<stevex.yang@intel.com>
>
> Acked-by: Aman Singh <aman.deep.singh@intel.com>
>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-02-03 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 2:59 [PATCH 0/2] add module EEPROM ops for ice Steve Yang
2022-01-20 2:59 ` [PATCH 1/2] net/ice: " Steve Yang
2022-01-25 1:15 ` Zhang, Qi Z
2022-01-25 14:49 ` Ferruh Yigit
2022-01-26 0:53 ` Yang, SteveX
2022-01-20 2:59 ` [PATCH 2/2] app/testpmd: fix stack overflow for EEPROM display Steve Yang
2022-02-02 10:00 ` Singh, Aman Deep
2022-02-03 13:15 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e27a961-a944-f3ea-e3cb-81880455e300@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Yuying.Zhang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).