From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 0B6781B132; Fri, 21 Sep 2018 20:27:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 11:27:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71897842" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 11:27:03 -0700 To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org Cc: declan.doherty@intel.com, matan@mellanox.com, ehkinzie@gmail.com, Chas Williams , stable@dpdk.org References: <20180919154825.5183-1-3chas3@gmail.com> <20180920125226.11904-1-3chas3@gmail.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <3e28d3ab-13ed-63fe-be8e-e73d3467f04f@intel.com> Date: Fri, 21 Sep 2018 19:27:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920125226.11904-1-3chas3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix RX slave fairness X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2018 18:27:14 -0000 On 9/20/2018 1:52 PM, Chas Williams wrote: > From: Chas Williams > > Some PMDs, especially ones with vector receives, require a minimum number > of receive buffers in order to receive any packets. If the first slave > read leaves less than this number available, a read from the next slave > may return 0 implying that the slave doesn't have any packets which > results in skipping over that slave as the next active slave. > > To fix this, implement round robin for the slaves during receive that > is only advanced to the next slave at the end of each receive burst. > This is also done to provide some additional fairness in processing in > other bonding RX burst routines as well. > > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: stable@dpdk.org > > Signed-off-by: Chas Williams > Acked-by: Luca Boccassi > Acked-by: Matan Azrad Applied to dpdk-next-net/master, thanks.