From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73DF3A0548; Fri, 3 Jun 2022 00:54:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A20D41181; Fri, 3 Jun 2022 00:54:18 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) by mails.dpdk.org (Postfix) with ESMTP id 3D48A4021E for ; Fri, 3 Jun 2022 00:54:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0HaHQ/vRcZyirLq8fYBq/L9s4fUb9JZBqidHTBpTt+VRuFw/1tCgqSzV3avJAD9a5fW4Sy/sU6WmUYYlpibvnyxmwwWs9+YBBqkAFu9mmqgfRVP7Nd7Oo7Jkqnx1EREf5WFQ1VhPZ8luQiwbfu8tijhL3yUieI7dhtDq9rjQL5HtIwynK0JJj4D13jHQegaAl8xOrx5TtBRGxIZYwR70St9pQxrucxY3QMvCBIsCKRsF6gv/sQDdjQsx0dXzBcFKKZQNQzz+is4cM9bSou8EIKhGBegLyR50Dz7BfVcAjuaDMyiiT7SEQQv8Qrt6+GWQUhhUccYCjSzsBCaHUNFxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mC7YHOvVQQWLXbCWrsdK5i7kiFGKXqlw6qciIzI1gXs=; b=m+FhO2d9y2pcfAHSFoXy76BF0ac7oqOqNl7MZRMo4rMhvtDqvX5SxvKXrhEAKiUiZswCu3CCFaG8G/QSyVj2q/eTEjLgGVvv1eeYoDSjJKqp2fQ9WP95KAxIiCprYKtPXKLstCezXOS5Er/Zk+be9KI+K0xOJ01aR4dzLxVepgwV91oql/NDf1IV+szYJ6tfAw/e49keHdYk4lZP+njQXKQ36dY/2L3hWGwzD4mrnSowwrXJqriw0ZRteOEd8kDBd+msYM2GejE9tcCJfAw2e0woPDcLJ5loIFjZZ8cf6Yvjbo2bnLke8vkwTDGbtcX0iETRWyIvTXmneRo3RKMULQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=corigine.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mC7YHOvVQQWLXbCWrsdK5i7kiFGKXqlw6qciIzI1gXs=; b=eq63hCoz0gC0KhX45lBWQIZsJQGMDCxtUKLWEqHYosbKl4DozMLM+7qOMs4sFaD2wsOHYiFsm1crnR6nXBXLb+/xuEYJp667mkx0Y/sIL8MmyBpnEqHvo8pSWhHoj2cL+1/HpPAMOr8BE6RXSik5jpGmAKhOVFdImcVOKoFNDPk= Received: from DM3PR12CA0121.namprd12.prod.outlook.com (2603:10b6:0:51::17) by SN6PR02MB5454.namprd02.prod.outlook.com (2603:10b6:805:e6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 2 Jun 2022 22:54:11 +0000 Received: from DM3NAM02FT040.eop-nam02.prod.protection.outlook.com (2603:10b6:0:51:cafe::24) by DM3PR12CA0121.outlook.office365.com (2603:10b6:0:51::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13 via Frontend Transport; Thu, 2 Jun 2022 22:54:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT040.mail.protection.outlook.com (10.13.5.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5314.12 via Frontend Transport; Thu, 2 Jun 2022 22:54:10 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 2 Jun 2022 23:54:09 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 2 Jun 2022 23:54:09 +0100 Envelope-to: jin.liu@corigine.com, dev@dpdk.org, niklas.soderlund@corigine.com, na.wang@corigine.com, peng.zhang@corigine.com, chaoyong.he@corigine.com Received: from [10.71.116.16] (port=58389) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nwthg-0000L0-GY; Thu, 02 Jun 2022 23:54:09 +0100 Message-ID: <3e2be73f-9990-293e-a42e-273706eb4b3a@xilinx.com> Date: Thu, 2 Jun 2022 23:54:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 08/14] net/nfp: structure adjustment Content-Language: en-US To: Jin Liu , CC: , Diana Wang , Peng Zhang , Chaoyong He References: <20220602015304.710197-1-jin.liu@corigine.com> <20220602015304.710197-9-jin.liu@corigine.com> From: Ferruh Yigit In-Reply-To: <20220602015304.710197-9-jin.liu@corigine.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e320ee65-f762-48b6-436c-08da44eacea6 X-MS-TrafficTypeDiagnostic: SN6PR02MB5454:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HbDCiLkiuNRb9O31yL0XOe3r9WLXWax0otJyjlG3rRv4yYLZlC3gMGucPrhT13CJwn8Z8ok2flvTZjxtSgRkdgECdDIK4J9hs5hlCmqVwPnDe+HkCcw20UK4Q/tvHH5HAHs3Imo/M8O6kz0IsmV8908m/bglNDKByrFEcaVlIuREUOPFntSOUG0//VaZwXOM6CAz6wWix1L1EtOm8CcnZEwZJ0oULFWPYZPafU7TVUaTMce3u+OgWk/Dg2MZjUU6W7QkHcKoWX+PPFjdrdHSqha4vwlXZFV+NQhFas1T0Ocse7G9M8d77LIgfNMYfomz1GlwaMO45rQYafVozR9/e9BaYjeURyWp1t6O4lK0D+SJyWxurci7BTNwRGxX9O8InDUZ4G5S1+TshvYWgl4Y08HeOnWe8e3nVYupLm6KgD2G+3rEL1O7AlngkpvfS6BFPk1TCrWOThgu7++AiudqBDna/PFiApwKaqF8ubAycV7Lbb+jOfoNYn/Ex4VP1Ph/AlC70/f2nFalejlUbKm/uSHZisebZXPdWpIjMxjfaQySRUsXFif/QtkY5xxzdUvhsm1b+cXXq4XdLh0O9O+H2Unl4DfPi2rfR7wbfY213/Nu05cyBlHQpq/IJMrGOi5MKcC+xvGxrFuWjXRXwFpIEB+EGOuGoxgxmb3DVOpNSSzq+S9izKhGJ+WSDthFsT6aOTIjY/Aks2X3nARU0vSrcRSaWlu2rPNiN0jMQODQYfc= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(53546011)(44832011)(2906002)(4326008)(8676002)(316002)(5660300002)(36860700001)(70586007)(70206006)(356005)(2616005)(31686004)(508600001)(8936002)(31696002)(82310400005)(110136005)(426003)(9786002)(40460700003)(336012)(4744005)(54906003)(47076005)(186003)(26005)(7636003)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 22:54:10.4197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e320ee65-f762-48b6-436c-08da44eacea6 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT040.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5454 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/2/2022 2:52 AM, Jin Liu wrote: > Add and modify the nfp PMD struct and macro that will be used by NFDK > firmware. > > Signed-off-by: Jin Liu > Signed-off-by: Diana Wang > Signed-off-by: Peng Zhang > Signed-off-by: Chaoyong He > Signed-off-by: Niklas Söderlund <...> > @@ -114,9 +166,14 @@ struct nfp_net_txq { > * For each descriptor keep a reference to the mbuf and > * DMA address used until completion is signalled. > */ > - struct { > - struct rte_mbuf *mbuf; > - } *txbufs; > + union { > + struct { > + struct rte_mbuf *mbuf; > + } *txbufs; > + struct { > + struct rte_mbuf *mbuf; > + } *ktxbufs; What is the point of this union? Both structs are same.