From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AFF1B11F5 for ; Wed, 30 Aug 2017 00:27:25 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 15:27:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,446,1498546800"; d="scan'208";a="1189549579" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.233.81.8]) ([10.233.81.8]) by fmsmga001.fm.intel.com with ESMTP; 29 Aug 2017 15:27:24 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-6-git-send-email-jianfeng.tan@intel.com> <20170829125423.GN8124@bidouze.vm.6wind.com> Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, yliu@fridaylinux.org, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com From: "Tan, Jianfeng" Message-ID: <3e3c1612-b7c4-1961-0913-29d72d94a650@intel.com> Date: Tue, 29 Aug 2017 15:27:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170829125423.GN8124@bidouze.vm.6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 05/12] bus/vdev: change log type from EAL to PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 22:27:26 -0000 On 8/29/2017 5:54 AM, Gaëtan Rivet wrote: > On Fri, Aug 25, 2017 at 09:40:45AM +0000, Jianfeng Tan wrote: >> Signed-off-by: Jianfeng Tan >> --- >> drivers/bus/vdev/vdev.c | 10 ++++++---- >> drivers/bus/vdev/vdev_logs.h | 40 ++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 46 insertions(+), 4 deletions(-) >> create mode 100644 drivers/bus/vdev/vdev_logs.h [...] >> + >> +#ifndef _VDEV_LOGS_H_ >> +#define _VDEV_LOGS_H_ >> + >> +#define VDEV_LOG(level, fmt, args...) \ >> + RTE_LOG(level, PMD, "%s(): " fmt "\n", __func__, ##args) > With the multiplication of bus implementations, wouldn't it be interesting > to introduce an RTE_LOGTYPE_BUS? Interesting! Let me try to do that in the next version. Thanks, Jianfeng >> + >> +#endif /* _VDEV_LOGS_H_ */ >> -- >> 2.7.4 >>