From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH 0/3] eal: mark API's as stable
Date: Fri, 6 Sep 2024 10:34:07 +0100 [thread overview]
Message-ID: <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> (raw)
In-Reply-To: <CAJFAV8x1E4mcLwoHUhB1C=R5wjXq0aY1TRXPjwUhH1oj8qGu_Q@mail.gmail.com>
On 9/5/2024 8:58 AM, David Marchand wrote:
> On Wed, Sep 4, 2024 at 8:10 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>>
>> The API's in ethtool from before 23.11 should be marked stable.
>
> EAL* ?
>
>> Should probably include the trace api's but that is more complex change.
>
> On the trace API itself it should be ok.
> The problem is with the tracepoint variables themselves, and I don't
> think we should mark them stable.
>
We cleaned tracepoint variables from ethdev map file, why they exist for
'eal'?
I can see .map file has bunch of "__rte_eal_trace_generic_*", I think
they exists to support 'rte_eal_trace_generic_*()' APIs which can be
called from other libraries.
Do we really need them?
Why not whoever calls them directly call 'rte_trace_point_emit_*' instead?
As these rte_eal_trace_generic_*()' not used at all, I assume this is
what done already.
@Jerin,
what do think to remove 'rte_eal_trace_generic_*()' APIs, so trace
always keeps local to library, and don't bloat the eal .map file?
next prev parent reply other threads:[~2024-09-06 9:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 18:08 Stephen Hemminger
2024-09-04 18:08 ` [PATCH 1/3] eal: make rte_cpu_get_intrinsics_support stable Stephen Hemminger
2024-09-04 18:08 ` [PATCH 2/3] eal: mark rte_lcore_register_usage_cb stable Stephen Hemminger
2024-09-04 18:08 ` [PATCH 3/3] eal: mark rte_memzone_max_get/set stable Stephen Hemminger
2024-09-05 6:07 ` [PATCH 0/3] eal: mark API's as stable Morten Brørup
2024-09-05 7:58 ` David Marchand
2024-09-05 8:55 ` Morten Brørup
2024-09-05 9:03 ` David Marchand
2024-09-05 9:44 ` Morten Brørup
2024-09-05 14:01 ` Jerin Jacob
2024-09-05 14:18 ` Morten Brørup
2024-09-08 23:58 ` Stephen Hemminger
2024-09-06 8:54 ` Ferruh Yigit
2024-09-06 10:04 ` Morten Brørup
2024-09-06 14:12 ` Ferruh Yigit
2024-09-06 14:42 ` Morten Brørup
2024-09-09 4:48 ` Jerin Jacob
2024-09-06 9:34 ` Ferruh Yigit [this message]
2024-09-06 9:48 ` David Marchand
2024-09-06 11:00 ` Ferruh Yigit
2024-09-06 13:11 ` Jerin Jacob
2024-09-06 14:03 ` Ferruh Yigit
2024-09-09 4:46 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com \
--to=ferruh.yigit@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).