From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Rajesh Mudimadugula <rmudimadugul@marvell.com>, dev@dpdk.org
Cc: chenbox@nvidia.com
Subject: Re: [PATCH 1/2] vhost: fix cipher data length
Date: Fri, 16 May 2025 16:13:40 +0200 [thread overview]
Message-ID: <3e60e751-7057-4230-956b-050c63ed0e7e@redhat.com> (raw)
In-Reply-To: <20250403122234.3508100-1-rmudimadugul@marvell.com>
On 4/3/25 2:22 PM, Rajesh Mudimadugula wrote:
> This patch fixes cipher data length, in the event of algorithm
> chaining. When enqueuing crypto op to vhost backend
> cipher.data.length is set correctly which is in
> virtqueue_crypto_sym_pkt_header_arrange(). This field is computed
> and assigned wrongly instead of using passed value. This is
> rectified and using correct cipher data length in vhost crypto.
>
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
>
> Signed-off-by: Rajesh Mudimadugula <rmudimadugul@marvell.com>
> ---
> lib/vhost/vhost_crypto.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/vhost/vhost_crypto.c b/lib/vhost/vhost_crypto.c
> index 3c6c5dc114..ddcd93738b 100644
> --- a/lib/vhost/vhost_crypto.c
> +++ b/lib/vhost/vhost_crypto.c
> @@ -1358,8 +1358,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op,
> op->sess_type = RTE_CRYPTO_OP_WITH_SESSION;
>
> op->sym->cipher.data.offset = chain->para.cipher_start_src_offset;
> - op->sym->cipher.data.length = chain->para.src_data_len -
> - chain->para.cipher_start_src_offset;
> + op->sym->cipher.data.length = chain->para.len_to_cipher;
>
> op->sym->auth.data.offset = chain->para.hash_start_src_offset;
> op->sym->auth.data.length = chain->para.len_to_hash;
Applied to next-virtio/for-net-next.
Thanks,
Maxime
prev parent reply other threads:[~2025-05-16 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 12:22 Rajesh Mudimadugula
2025-04-10 5:12 ` [EXTERNAL] " Akhil Goyal
2025-05-16 14:13 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e60e751-7057-4230-956b-050c63ed0e7e@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=rmudimadugul@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).