From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94020A0C57; Mon, 1 Nov 2021 09:59:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2585B40E28; Mon, 1 Nov 2021 09:59:39 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 3982540DF6 for ; Mon, 1 Nov 2021 09:59:37 +0100 (CET) Received: from [192.168.1.71] (unknown [188.170.83.209]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7B4887F6F5; Mon, 1 Nov 2021 11:59:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7B4887F6F5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1635757176; bh=KcG91DgVkL3m3a5syBaAV/+w5Mf93SgP1rGunwv8l6U=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=TTxM79ABCW/qUE4Yd9y6eYx2+20SVeIz5kzXH3UIAeqC1Fj+fn4UpwPeIBeZPMqsB pW9gQALDUsyrKonBIEdptX9q6Btat3pal7zNAzHLJuRCPesMfsUno85COF9FdfJHCV SI1h0fQ5ZhQM6Prd9YS8gsbEc5/HrmLd/GYcxvOo= To: "Xia, Chenbo" , Vijay Srivastava , "dev@dpdk.org" Cc: "maxime.coquelin@redhat.com" , Vijay Kumar Srivastava References: <20210706164418.32615-1-vsrivast@xilinx.com> <20211029144645.30295-1-vsrivast@xilinx.com> <20211029144645.30295-2-vsrivast@xilinx.com> From: Andrew Rybchenko Message-ID: <3e963f9a-ed91-cd6a-41c2-7c221a5c1c4f@oktetlabs.ru> Date: Mon, 1 Nov 2021 11:59:35 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chenbo, Thanks for review. Few questions from me below on your review notes. Andrew. On 11/1/21 11:30 AM, Xia, Chenbo wrote: > Hi Vijay, > >> -----Original Message----- >> From: Vijay Srivastava >> Sent: Friday, October 29, 2021 10:47 PM >> To: dev@dpdk.org >> Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; >> andrew.rybchenko@oktetlabs.ru; Vijay Kumar Srivastava >> Subject: [PATCH v3 01/10] vdpa/sfc: introduce Xilinx vDPA driver >> >> From: Vijay Kumar Srivastava >> >> Add new vDPA PMD to support vDPA operations of Xilinx devices. >> This patch implements probe and remove functions. >> >> Signed-off-by: Vijay Kumar Srivastava >> Acked-by: Andrew Rybchenko > > Note that your patch is not rebased on the latest commit. Reviewers > may have trouble to review your patch. > [snip] >> + sva->vfio_group_fd = >> + rte_vfio_container_group_bind(sva->vfio_container_fd, > > DPDK allows up to 100 chars per line. Please check all code that do not > need new lines. It will make the code look better. I'm sorry, but as far as I know permissive to have up to 100 chars does not enforce to stretch all lines. Or am I missing something in coding style? IMHO, it is still *allowed* to avoid lines longer than 80 chars. [snip]