DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <pbhagavatula@marvell.com>, <jerinj@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function
Date: Wed, 2 Oct 2019 16:37:15 +0300	[thread overview]
Message-ID: <3e9d9131-93c4-60b4-44b4-7f553071990b@solarflare.com> (raw)
In-Reply-To: <20191002034716.6842-2-pbhagavatula@marvell.com>

Hi,

looks good, just few comments below.

Many thanks for working on it,
Andrew.

On 10/2/19 6:47 AM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Add `rte_eth_dev_set_supported_ptypes` function that will allow the
> application to inform the PMD the packet types it is interested in.
> Based on the ptypes set PMDs can optimize their Rx path.
>
> -If application doesn’t want any ptype information it can call
> `rte_eth_dev_set_supported_ptypes(ethdev_id, RTE_PTYPE_UNKNOWN, NULL, 0)`
> and PMD may skip packet type processing and set rte_mbuf::packet_type to
> RTE_PTYPE_UNKNOWN.
>
> -If application doesn’t call `rte_eth_dev_set_supported_ptypes` PMD can
> return `rte_mbuf::packet_type` with `rte_eth_dev_get_supported_ptypes`.
>
> -If application is interested only in L2/L3 layer, it can inform the PMD
> to update `rte_mbuf::packet_type` with L2/L3 ptype by calling
> `rte_eth_dev_set_supported_ptypes(ethdev_id,
> 		RTE_PTYPE_L2_MASK | RTE_PTYPE_L3_MASK, NULL, 0)`.
>
> Suggested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

[snip]

> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index 17d183e1f..b1588fe7a 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -2602,6 +2602,56 @@ rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
>   	return j;
>   }
>   
> +int
> +rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
> +				 uint32_t *set_ptypes, unsigned int num)
> +{
> +	unsigned int i, j;
> +	struct rte_eth_dev *dev;
> +	const uint32_t *all_ptypes;
> +
> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> +	dev = &rte_eth_devices[port_id];
> +	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_supported_ptypes_get, 0);
> +	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_supported_ptypes_set, 0);

When 0 is returned above, we should set set_ptypes. So, below
check num vs set_types should be done before callbacks check and
I think it is OK to do
       set_ptypes[0] = RTE_PTYPE_UNKNOWN;
just after the check. It will allow to simplify code below and will
make it set correctly even if 0 returned because of no callbacks.

> +
> +	if (num > 0 && set_ptypes == NULL)
> +		return -EINVAL;
> +
> +	if (ptype_mask == 0) {
> +		if (num > 0)
> +			set_ptypes[0] = RTE_PTYPE_UNKNOWN;
> +
> +		return (*dev->dev_ops->dev_supported_ptypes_set)(dev,
> +				ptype_mask);
> +	}
> +
> +	all_ptypes = (*dev->dev_ops->dev_supported_ptypes_get)(dev);
> +	if (all_ptypes == NULL) {
> +		if (num > 0)
> +			set_ptypes[0] = RTE_PTYPE_UNKNOWN;
> +
> +		return 0;
> +	}
> +
> +	for (i = 0, j = 0; set_ptypes != NULL &&
> +				(all_ptypes[i] != RTE_PTYPE_UNKNOWN); ++i) {
> +		if (ptype_mask & all_ptypes[i]) {
> +			if (j < num - 1) {
> +				set_ptypes[j] = all_ptypes[i];
> +				j++;
> +				continue;
> +			}
> +			break;

I'd like to repeat my question about insufficient space to return
set_ptypes. Do we need to signal it somehow? If no, it should be
explained why in the comments here.

> +		}
> +	}
> +
> +	if (set_ptypes != NULL)
> +		set_ptypes[j] = RTE_PTYPE_UNKNOWN;
> +
> +	return (*dev->dev_ops->dev_supported_ptypes_set)(dev, ptype_mask);
> +}
> +
>   void
>   rte_eth_macaddr_get(uint16_t port_id, struct rte_ether_addr *mac_addr)
>   {
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index d9871782e..c577a9172 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -2431,6 +2431,42 @@ int rte_eth_dev_fw_version_get(uint16_t port_id,
>    */
>   int rte_eth_dev_get_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
>   				     uint32_t *ptypes, int num);
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice.
> + *
> + * Inform Ethernet device of the packet types classification in which
> + * the recipient is interested.
> + *
> + * Application can use this function to set only specific ptypes that it's
> + * interested. This information can be used by the PMD to optimize Rx path.
> + *
> + * The function accepts an array `set_ptypes` allocated by the caller to
> + * store the packet types set by the driver, the last element of the array
> + * is set to RTE_PTYPE_UNKNOWN. The size of the `set_ptype` array should be
> + * `rte_eth_dev_get_supported_ptypes() + 1` else it might only be filled
> + * partially.
> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + * @param ptype_mask
> + *   The ptype family that application is interested in.
> + * @param set_ptypes
> + *   An array pointer to store set packet types, allocated by caller. The
> + *   function marks the end of array with RTE_PTYPE_UNKNOWN.
> + * @param num
> + *   Size of the array pointed by param ptypes.
> + *   Should be rte_eth_dev_get_supported_ptypes() + 1 to accommodate the
> + *   set ptypes.
> + * @return
> + *   - (0) if Success.
> + *   - (-ENODEV) if *port_id* invalid.
> + *   - (-EINVAL) if *ptype_mask* is invalid (or) set_ptypes is NULL and
> + *     num > 0.
> + */
> +__rte_experimental
> +int rte_eth_dev_set_supported_ptypes(uint16_t port_id, uint32_t ptype_mask,
> +				     uint32_t *set_ptypes, unsigned int num);
>   
>   /**
>    * Retrieve the MTU of an Ethernet device.
> diff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h
> index 2922d5b7c..93bc34480 100644
> --- a/lib/librte_ethdev/rte_ethdev_core.h
> +++ b/lib/librte_ethdev/rte_ethdev_core.h
> @@ -110,6 +110,10 @@ typedef void (*eth_dev_infos_get_t)(struct rte_eth_dev *dev,
>   typedef const uint32_t *(*eth_dev_supported_ptypes_get_t)(struct rte_eth_dev *dev);
>   /**< @internal Get supported ptypes of an Ethernet device. */
>   
> +typedef uint32_t (*eth_dev_supported_ptypes_set_t)(struct rte_eth_dev *dev,
> +					      uint32_t ptype_mask);
> +/**< @internal Inform device about packet types in which the recipient is interested. */
> +

Please, take a look at promiscuous mode callback and let's put
more verbose description here which better document interface
to drivers. I think ptyep_mask description should refer to corresponding
defines to be used.

[snip]


  reply	other threads:[~2019-10-02 13:37 UTC|newest]

Thread overview: 246+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 20:47 [dpdk-dev] [PATCH v2 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 1/7] ethdev: add set ptype function pbhagavatula
2019-08-23  9:44   ` Andrew Rybchenko
2019-10-01 14:54   ` Jerin Jacob
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-08-23  1:19   ` Stephen Hemminger
2019-08-27 13:44     ` Andrew Rybchenko
2019-08-23  9:49   ` Andrew Rybchenko
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 3/7] ethdev: add flow action type " pbhagavatula
2019-08-23 10:00   ` Andrew Rybchenko
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 14:43   ` Jerin Jacob
2019-10-01 15:40   ` Ajit Khaparde
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-08-23 10:03   ` Andrew Rybchenko
2019-10-01 14:48   ` Jerin Jacob
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-08-21 20:47 ` [dpdk-dev] [PATCH v2 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-08-23 10:10   ` Andrew Rybchenko
2019-09-29 21:19 ` [dpdk-dev] [PATCH v3 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 1/7] ethdev: add set ptype function pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 3/7] ethdev: add flow action type " pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-09-29 21:19   ` [dpdk-dev] [PATCH v3 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-09-30 17:47     ` Aaron Conole
2019-10-01  5:02       ` Pavan Nikhilesh Bhagavatula
2019-10-01  6:34   ` [dpdk-dev] [PATCH v4 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01  7:04       ` Andrew Rybchenko
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01  6:34     ` [dpdk-dev] [PATCH v4 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-01  6:41     ` [dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01  7:10         ` Andrew Rybchenko
2019-10-01 11:50         ` Hemant Agrawal
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01  7:11         ` Andrew Rybchenko
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01  6:41       ` [dpdk-dev] [PATCH v5 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-01 18:52       ` [dpdk-dev] [PATCH v6 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 1/7] ethdev: add set ptype function pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 3/7] ethdev: add flow action type " pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-01 18:52         ` [dpdk-dev] [PATCH v6 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-02  3:47         ` [dpdk-dev] [PATCH v5 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function pbhagavatula
2019-10-02 13:37             ` Andrew Rybchenko [this message]
2019-10-02 13:41               ` Andrew Rybchenko
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 3/7] ethdev: add flow action type " pbhagavatula
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-02  9:52             ` Jerin Jacob
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-02  3:47           ` [dpdk-dev] [PATCH v7 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-02 21:36           ` [dpdk-dev] [PATCH v8 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 1/7] ethdev: add set ptype function pbhagavatula
2019-10-03  7:40               ` Andrew Rybchenko
2019-10-03 17:15                 ` Pavan Nikhilesh Bhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 3/7] ethdev: add flow action type " pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-02 21:36             ` [dpdk-dev] [PATCH v8 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-07  6:51             ` [dpdk-dev] [PATCH v9 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 1/7] ethdev: add set ptype function pbhagavatula
2019-10-08 14:48                 ` Andrew Rybchenko
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 3/7] ethdev: add flow action type " pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-07  6:51               ` [dpdk-dev] [PATCH v9 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-09 15:33               ` [dpdk-dev] [PATCH v10 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 1/7] ethdev: add set ptype function pbhagavatula
2019-10-10  8:46                   ` Andrew Rybchenko
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 3/7] ethdev: add flow action type " pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-09 15:33                 ` [dpdk-dev] [PATCH v10 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-10 10:51                 ` [dpdk-dev] [PATCH v11 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 1/7] ethdev: add set ptype function pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 3/7] ethdev: add flow action type " pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-10 10:51                   ` [dpdk-dev] [PATCH v11 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-17 12:02                   ` [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 1/7] ethdev: add set ptype function pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 3/7] ethdev: add flow action type " pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 5/7] drivers/net: update Rx flow flag and mark capabilities pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 6/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-17 12:02                     ` [dpdk-dev] [PATCH v12 7/7] examples: disable Rx packet type parsing pbhagavatula
2019-10-17 17:43                     ` [dpdk-dev] [PATCH v12 0/7] ethdev: add new Rx offload flags Ferruh Yigit
2019-10-18  7:32                       ` Andrew Rybchenko
2019-10-18  9:42                         ` Ferruh Yigit
2019-10-18 10:31                           ` Andrew Rybchenko
2019-10-21 15:06                             ` Ferruh Yigit
2019-10-25 14:33                     ` [dpdk-dev] [PATCH v13 0/6] " pbhagavatula
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 1/6] ethdev: add set ptype function pbhagavatula
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 2/6] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 3/6] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-25 14:56                         ` Andrew Rybchenko
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 4/6] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 5/6] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-25 14:33                       ` [dpdk-dev] [PATCH v13 6/6] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-29  5:03                       ` [dpdk-dev] [PATCH v14 0/6] ethdev: add new Rx offload flags pbhagavatula
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 1/7] ethdev: add set ptype function pbhagavatula
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-29  7:13                           ` Andrew Rybchenko
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 3/7] ethdev: log offloads that can't be disabled by PMD pbhagavatula
2019-10-29  7:05                           ` Andrew Rybchenko
2019-10-29  8:33                             ` Pavan Nikhilesh Bhagavatula
2019-10-29  8:42                               ` Andrew Rybchenko
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-29  7:21                           ` Andrew Rybchenko
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 6/7] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-29  5:03                         ` [dpdk-dev] [PATCH v14 7/7] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-29 15:37                         ` [dpdk-dev] [PATCH v15 0/7] ethdev: add new Rx offload flags pbhagavatula
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 1/7] ethdev: add set ptype function pbhagavatula
2019-10-31 13:39                             ` Thomas Monjalon
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 2/7] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-10-31 13:43                             ` Thomas Monjalon
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 3/7] ethdev: add validation to offloads set by PMD pbhagavatula
2019-10-29 16:53                             ` Andrew Rybchenko
2019-10-29 17:25                               ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-10-31 13:45                               ` [dpdk-dev] " Thomas Monjalon
2019-10-31 13:58                             ` Thomas Monjalon
2019-10-31 16:44                               ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-11-01 22:50                                 ` Thomas Monjalon
2019-10-31 15:13                             ` [dpdk-dev] " Matan Azrad
2019-10-31 15:18                               ` Pavan Nikhilesh Bhagavatula
2019-10-31 15:50                                 ` Matan Azrad
2019-10-31 16:33                                   ` Pavan Nikhilesh Bhagavatula
2019-11-01 11:04                                     ` Andrew Rybchenko
2019-11-03  6:57                                       ` Matan Azrad
2019-11-03 12:12                                         ` Andrew Rybchenko
2019-11-03 15:16                                           ` Matan Azrad
2019-11-05 12:48                                             ` Andrew Rybchenko
2019-11-05 14:05                                               ` Matan Azrad
2019-11-05 14:37                                                 ` Andrew Rybchenko
2019-11-06  6:58                                                   ` Matan Azrad
2019-11-06  8:12                                                     ` Andrew Rybchenko
2019-11-07  6:56                                                       ` Matan Azrad
2019-11-08 10:12                                                         ` Andrew Rybchenko
2019-11-08 10:29                                                           ` Matan Azrad
2019-11-08 11:24                                                             ` Andrew Rybchenko
2019-11-08 11:48                                                               ` Matan Azrad
2019-11-08 12:09                                                                 ` Andrew Rybchenko
2019-11-08 12:59                                                                   ` Thomas Monjalon
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 4/7] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-10-31 14:03                             ` Thomas Monjalon
2019-10-31 16:51                               ` Pavan Nikhilesh Bhagavatula
2019-11-01 11:11                                 ` Andrew Rybchenko
2019-11-01 22:22                                   ` Thomas Monjalon
2019-11-01 17:49                             ` Liron Himi
2019-11-03 12:06                               ` Andrew Rybchenko
2019-11-03 14:06                                 ` [dpdk-dev] [EXT] " Liron Himi
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 5/7] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-10-31 14:05                             ` Thomas Monjalon
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 6/7] examples/l2fwd: disable ptype parsing pbhagavatula
2019-10-29 15:37                           ` [dpdk-dev] [PATCH v15 7/7] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-10-31 10:33                             ` Iremonger, Bernard
2019-11-06 18:13                               ` Pavan Nikhilesh Bhagavatula
2019-11-06 19:17                           ` [dpdk-dev] [PATCH v16 0/8] ethdev: add new Rx offload flags pbhagavatula
2019-11-06 19:17                             ` [dpdk-dev] [PATCH v16 1/8] ethdev: add set ptype function pbhagavatula
2019-11-07 18:28                               ` Ferruh Yigit
2019-11-08  9:05                                 ` Andrew Rybchenko
2019-11-08  9:52                                   ` Ferruh Yigit
2019-11-08 10:24                                     ` Andrew Rybchenko
2019-11-08 11:05                                       ` Ferruh Yigit
2019-11-08 11:40                                         ` Andrew Rybchenko
2019-11-06 19:17                             ` [dpdk-dev] [PATCH v16 2/8] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-11-07 17:24                               ` Ferruh Yigit
2019-11-10 14:43                                 ` Pavan Nikhilesh Bhagavatula
2019-11-06 19:17                             ` [dpdk-dev] [PATCH v16 3/8] ethdev: add validation to offloads set by PMD pbhagavatula
2019-11-07 16:51                               ` Ferruh Yigit
2019-11-06 19:17                             ` [dpdk-dev] [PATCH v16 4/8] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-11-07 16:48                               ` Ferruh Yigit
2019-11-07 17:22                               ` Ferruh Yigit
2019-11-08  8:48                                 ` Andrew Rybchenko
2019-11-14 14:01                                   ` Ferruh Yigit
2019-11-06 19:17                             ` [dpdk-dev] [PATCH v16 5/8] examples/eventdev_pipeline: split port init sequence pbhagavatula
2019-11-06 19:18                             ` [dpdk-dev] [PATCH v16 6/8] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-11-06 19:18                             ` [dpdk-dev] [PATCH v16 7/8] examples/l2fwd: disable ptype parsing pbhagavatula
2019-11-07 17:59                               ` Ferruh Yigit
2019-11-07 18:30                               ` Ferruh Yigit
2019-11-06 19:18                             ` [dpdk-dev] [PATCH v16 8/8] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-11-07 11:57                               ` Iremonger, Bernard
2019-11-07 12:27                                 ` Iremonger, Bernard
2019-11-07 14:36                                   ` Pavan Nikhilesh Bhagavatula
2019-11-07 15:00                                     ` Iremonger, Bernard
2019-11-07 18:40                               ` Ferruh Yigit
2019-11-07 18:55                                 ` Jerin Jacob
2019-11-07 19:40                                   ` Ferruh Yigit
2019-11-08  4:13                                     ` Jerin Jacob
2019-11-08 13:54                                     ` Ananyev, Konstantin
2019-11-08 15:01                                       ` Jerin Jacob
2019-11-11  4:56                                         ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2019-11-11  5:02                                           ` Jerin Jacob
2019-11-11 10:44                                             ` Ferruh Yigit
2019-11-11 13:19                             ` [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags pbhagavatula
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 01/10] ethdev: add set ptype function pbhagavatula
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 02/10] ethdev: add mbuf RSS update as an offload pbhagavatula
2019-11-13 18:04                                 ` Ferruh Yigit
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 03/10] ethdev: add validation to offloads set by PMD pbhagavatula
2019-11-13 18:10                                 ` Ferruh Yigit
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 04/10] drivers/net: update Rx RSS hash offload capabilities pbhagavatula
2019-11-11 15:05                                 ` Ferruh Yigit
2019-11-11 15:10                                   ` Pavan Nikhilesh Bhagavatula
2019-11-13 18:02                                 ` Ferruh Yigit
2019-11-14 12:52                                   ` Ferruh Yigit
2019-11-14 12:57                                   ` Jerin Jacob
2019-11-14 13:24                                     ` Andrew Rybchenko
2019-11-14 13:59                                       ` Ferruh Yigit
2019-11-14 14:14                                         ` Ferruh Yigit
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 05/10] examples/eventdev_pipeline: split port init sequence pbhagavatula
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 06/10] examples/eventdev_pipeline: add new Rx RSS hash offload pbhagavatula
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 07/10] examples/l2fwd: disable ptype parsing pbhagavatula
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 08/10] app/testpmd: add command to set supported ptype mask pbhagavatula
2019-11-11 14:51                                 ` Ferruh Yigit
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 09/10] app/testpmd: disable packet type parsing by default pbhagavatula
2019-11-11 14:54                                 ` Ferruh Yigit
2019-11-11 13:19                               ` [dpdk-dev] [PATCH v17 10/10] app/testpmd: add RSS hash offload to port Rx offload cmd pbhagavatula
2019-11-11 15:45                               ` [dpdk-dev] [PATCH v17 00/10] ethdev: add new Rx offload flags Ferruh Yigit
2019-10-02 14:06 [dpdk-dev] [PATCH v7 1/7] ethdev: add set ptype function Pavan Nikhilesh Bhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e9d9131-93c4-60b4-44b4-7f553071990b@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=pbhagavatula@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).