From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2FCAE45592;
	Fri,  5 Jul 2024 08:06:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0493C42EFE;
	Fri,  5 Jul 2024 08:06:44 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id EB90B4029C
 for <dev@dpdk.org>; Fri,  5 Jul 2024 08:06:42 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.105])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4WFjb11j89z1T4xp;
 Fri,  5 Jul 2024 14:02:05 +0800 (CST)
Received: from kwepemf500004.china.huawei.com (unknown [7.202.181.242])
 by mail.maildlp.com (Postfix) with ESMTPS id E343E14011A;
 Fri,  5 Jul 2024 14:06:40 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemf500004.china.huawei.com (7.202.181.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.2.1544.11; Fri, 5 Jul 2024 14:06:40 +0800
Message-ID: <3ea2a775-99e3-7fc1-3277-ccbf83ec332f@huawei.com>
Date: Fri, 5 Jul 2024 14:06:39 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 0/6] refine argparse library
To: Chengwen Feng <fengchengwen@huawei.com>, <thomas@monjalon.net>,
 <david.marchand@redhat.com>
CC: <dev@dpdk.org>
References: <20240220131502.47510-1-fengchengwen@huawei.com>
 <20240318111838.16991-1-fengchengwen@huawei.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <20240318111838.16991-1-fengchengwen@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To
 kwepemf500004.china.huawei.com (7.202.181.242)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


For the patchset,
Acked-by: Jie Hai <haijie1@huawei.com>

On 2024/3/18 19:18, Chengwen Feng wrote:
> I found a couple of issues when I revisited the argparse_autotest
> output, so got this patchset.
> 
> Chengwen Feng (6):
>    argparse: refine error message
>    argparse: remove dead code
>    argparse: replace flag enum with marco
>    argparse: fix argument flags operate as uint32 type
>    test/argparse: refine testcases
>    argparse: fix doc don't display two hyphens
> ---
> v4: address Thomas's comment on 4/6 commit:
> - remove unused macros TEST_ARGPARSE_FLAG_HAS_ARG_BITMASK and
>    TEST_ARGPARSE_FLAG_VAL_TYPE_BITMASK.
> v3:
> - address Thomas's comment on 4/6 comit.
> - add commit: fix doc don't display two hyphens.
> v2: address David Marchand's comment:
> - replace flag enum with marco.
> - replace flag's hardcode with macro in test_argparse.c.
> 
>   app/test/test_argparse.c               | 65 +++++++++++---------
>   doc/guides/prog_guide/argparse_lib.rst | 47 +++++++-------
>   lib/argparse/rte_argparse.c            | 61 +++++++++---------
>   lib/argparse/rte_argparse.h            | 85 ++++++++++++--------------
>   4 files changed, 127 insertions(+), 131 deletions(-)
>