* [dpdk-dev] [PATCH] ethdev: fix device capability to string translation
@ 2021-11-09 9:00 Dmitry Kozlyuk
2021-11-09 11:56 ` Ali Alnubani
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Kozlyuk @ 2021-11-09 9:00 UTC (permalink / raw)
To: dev
Cc: Ali Alnubani, Xueming Li, Thomas Monjalon, Ferruh Yigit,
Andrew Rybchenko
Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
to rte_eth_dev_capability_name(), missed when adding the capabilities.
Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on restart")
Reported-by: Ali Alnubani <alialnu@nvidia.com>
Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Acked-by: Xueming Li <xuemingl@nvidia.com>
---
P.S. I don't know a good way to catch such errors in the future
except by a unit test, but adding a new suite for ethdev
seems worthy of its own patch (if needed at all).
lib/ethdev/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 8e679e4003..a1d475a292 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -171,6 +171,8 @@ static const struct {
{RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP, "RUNTIME_RX_QUEUE_SETUP"},
{RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP, "RUNTIME_TX_QUEUE_SETUP"},
{RTE_ETH_DEV_CAPA_RXQ_SHARE, "RXQ_SHARE"},
+ {RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP, "FLOW_RULE_KEEP"},
+ {RTE_ETH_DEV_CAPA_FLOW_SHARED_OBJECT_KEEP, "FLOW_SHARED_OBJECT_KEEP"},
};
/**
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix device capability to string translation
2021-11-09 9:00 [dpdk-dev] [PATCH] ethdev: fix device capability to string translation Dmitry Kozlyuk
@ 2021-11-09 11:56 ` Ali Alnubani
2021-11-09 18:43 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ali Alnubani @ 2021-11-09 11:56 UTC (permalink / raw)
To: Dmitry Kozlyuk, dev
Cc: Xueming(Steven) Li, NBU-Contact-Thomas Monjalon, Ferruh Yigit,
Andrew Rybchenko
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 9, 2021 11:01 AM
> To: dev@dpdk.org
> Cc: Ali Alnubani <alialnu@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH] ethdev: fix device capability to string translation
>
> Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
> to rte_eth_dev_capability_name(), missed when adding the capabilities.
>
> Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
> Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on
> restart")
>
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Xueming Li <xuemingl@nvidia.com>
> ---
> P.S. I don't know a good way to catch such errors in the future
> except by a unit test, but adding a new suite for ethdev
> seems worthy of its own patch (if needed at all).
>
Tested-by: Ali Alnubani <alialnu@nvidia.com>
Thanks,
Ali
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: fix device capability to string translation
2021-11-09 11:56 ` Ali Alnubani
@ 2021-11-09 18:43 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2021-11-09 18:43 UTC (permalink / raw)
To: Ali Alnubani, Dmitry Kozlyuk, dev
Cc: Xueming(Steven) Li, NBU-Contact-Thomas Monjalon, Andrew Rybchenko
On 11/9/2021 11:56 AM, Ali Alnubani wrote:
>> -----Original Message-----
>> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Sent: Tuesday, November 9, 2021 11:01 AM
>> To: dev@dpdk.org
>> Cc: Ali Alnubani <alialnu@nvidia.com>; Xueming(Steven) Li
>> <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon
>> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
>> Rybchenko <andrew.rybchenko@oktetlabs.ru>
>> Subject: [PATCH] ethdev: fix device capability to string translation
>>
>> Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
>> to rte_eth_dev_capability_name(), missed when adding the capabilities.
>>
>> Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
>> Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on
>> restart")
>>
>> Reported-by: Ali Alnubani <alialnu@nvidia.com>
>> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Acked-by: Xueming Li <xuemingl@nvidia.com>
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-09 18:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-09 9:00 [dpdk-dev] [PATCH] ethdev: fix device capability to string translation Dmitry Kozlyuk
2021-11-09 11:56 ` Ali Alnubani
2021-11-09 18:43 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).