From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 926121150 for ; Wed, 1 Feb 2017 19:18:14 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 01 Feb 2017 10:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="1120784600" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga002.fm.intel.com with ESMTP; 01 Feb 2017 10:18:12 -0800 To: "Ananyev, Konstantin" , "Lu, Wenzhuo" , "dev@dpdk.org" References: <1485311962-62335-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB9772583F10FFA1@irsmsx105.ger.corp.intel.com> <410cf75d-0ceb-d372-778f-bfa19392443b@intel.com> <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <3eb36489-4388-973e-3160-cec06714fac0@intel.com> Date: Wed, 1 Feb 2017 18:18:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB9772583F110053@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Feb 2017 18:18:15 -0000 On 2/1/2017 6:10 PM, Ananyev, Konstantin wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, February 1, 2017 5:40 PM >> To: Ananyev, Konstantin ; Lu, Wenzhuo ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get >> >> On 2/1/2017 4:24 PM, Ananyev, Konstantin wrote: >>> Hi Wenzhuo, >>> >>>> -----Original Message----- >>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu >>>> Sent: Wednesday, January 25, 2017 2:39 AM >>>> To: dev@dpdk.org >>>> Cc: Lu, Wenzhuo >>>> Subject: [dpdk-dev] [PATCH] net/ixgbe: clean up rte_eth_dev_info_get >>>> >>>> It'not appropriate to call rte_eth_dev_info_get in PMD, >>>> as rte_eth_dev_info_get need to get info from PMD. >>>> Remove rte_eth_dev_info_get from PMD code and get the >>>> info directly. >>>> >>>> Signed-off-by: Wenzhuo Lu >>>> --- >>>> drivers/net/ixgbe/ixgbe_ethdev.c | 144 ++++++++++++++++++--------------------- >>>> 1 file changed, 68 insertions(+), 76 deletions(-) >>>> >>>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >>>> index 64ce55a..f14a68b 100644 >>>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >>>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >>>> @@ -4401,17 +4401,17 @@ static int ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >>>> int rar_entry; >>>> uint8_t *new_mac = (uint8_t *)(mac_addr); >>>> struct rte_eth_dev *dev; >>>> - struct rte_eth_dev_info dev_info; >>>> + struct rte_pci_device *pci_dev; >>>> >>>> RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); >>>> >>>> dev = &rte_eth_devices[port]; >>>> - rte_eth_dev_info_get(port, &dev_info); >>>> + pci_dev = IXGBE_DEV_TO_PCI(dev); >>>> >>>> - if (is_ixgbe_pmd(dev_info.driver_name) != 0) >>>> + if (is_ixgbe_pmd(dev->data->drv_name)) >>>> return -ENOTSUP; >>> >>> I wonder why do we need now that it is really an ixgbe device all over the place? >> >> This device specific API, so it is missing merits of abstraction layer, >> application can these APIs with any port_id, API should be protected for it. > > Ah ok, my bad - didn't realize from the patch that it affects only device specific API :) > Would It be too much hassle to move these functions into a separate file (rte_ixgbe_pmd.c or so)? Not sure about the effort it requires, but I second that. > Konstantin > >> >>> Konstantin >>> >