From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4F9481B22F for ; Tue, 10 Oct 2017 07:34:04 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2017 22:34:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,503,1500966000"; d="scan'208";a="908410718" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.254.114.24]) ([10.254.114.24]) by FMSMGA003.fm.intel.com with ESMTP; 09 Oct 2017 22:34:01 -0700 To: David Harton , thomas@monjalon.net, ajit.khaparde@broadcom.com, johndale@cisco.com, konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jing.d.chen@intel.com, adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com, alejandro.lucero@netronome.com, hemant.agrawal@nxp.com, rasesh.mody@cavium.com, harish.patil@cavium.com, skhare@vmware.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com, allain.legacy@windriver.com Cc: dev@dpdk.org References: <20170825134717.18376-1-dharton@cisco.com> <20170901023628.21308-1-dharton@cisco.com> From: Ferruh Yigit Message-ID: <3ec460b4-b0fd-c9c9-6b9a-dd1beffd5da1@intel.com> Date: Tue, 10 Oct 2017 06:34:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20170901023628.21308-1-dharton@cisco.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 05:34:04 -0000 On 9/1/2017 3:36 AM, David Harton wrote: > Some devices may not support or fail setting VLAN offload > configuration based on dynamic circurmstances so the > vlan_offload_set_t vector is modified to return an int so > the caller can determine success or not. > > rte_eth_dev_set_vlan_offload is updated to return the > value provided by the vector when called along with restoring > the original offload configs on failure. > > Existing vlan_offload_set_t vectors are modified to return > an int. Majority of cases return 0 but a few that actually > can fail now return their failure codes. > > Finally, a vlan_offload_set_t vector is added to virtio > to facilitate dynamically turning VLAN strip on or off. > > Signed-off-by: David Harton Hi David, This patch conflicts against latest version, would you mind rebasing it on top of latest next-net? Thanks, ferruh