From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1CE85271 for ; Tue, 18 Jul 2017 14:32:30 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 05:32:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="126442638" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.81]) ([10.255.134.81]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2017 05:32:22 -0700 To: Pascal Mazon , Raslan Darawsheh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stephen@networkplumber.org, thomas@monjalon.net References: <1499674423-4235-1-git-send-email-rasland@mellanox.com> <1500282020-23171-1-git-send-email-rasland@mellanox.com> <96a4f0b5-16c9-3f01-5eb5-848c1475b304@6wind.com> From: Ferruh Yigit Message-ID: <3eca6c74-416a-de88-5cbf-4e55888ea1b0@intel.com> Date: Tue, 18 Jul 2017 13:32:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <96a4f0b5-16c9-3f01-5eb5-848c1475b304@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] net/tap: remove Linux version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 12:32:31 -0000 <...> > On 07/17/2017 11:00 AM, Raslan Darawsheh wrote: >> Remove checks of Linux kernel version >> in order to support kernel with backported features. >> >> the expected behavior with a kernel that doesn't support flower >> and other bits is the following: >> -flow validate can return successfully >> -flow create using the same rule fails. >> >> Using the "remote" feature without kernel flower does not fail silently. >> The TAP instance is not initialized if the requested parameters cannot >> be satisfied. >> >> it has been tested on an old kernel without required support: >> >> PMD: Kernel refused TC filter rule creation (2): No such file or directory >> PMD: tap0 failed to create implicit rules. >> PMD: Can't set up remote feature: No such file of directory(2) >> PMD: TAP Unable to initialize net_tap0 >> >> Signed-off-by: Raslan Darawsheh > Acked-by: Pascal Mazon Applied to dpdk-next-net/master, thanks.