From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2041243F17; Wed, 1 May 2024 17:56:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A08CE402A7; Wed, 1 May 2024 17:56:51 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by mails.dpdk.org (Postfix) with ESMTP id 82AD64021E for ; Wed, 1 May 2024 17:56:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OIjhYWeIuWRBmOrpYMrDiWpdOSrGa+OEN9Tc1lr43VOHudrhUXPyqeyhWgRx3njB7VoWCOi5NduscVt7v48LIvdqZfJIBI0Urd4T6G/NKWKiQcTXIL1ONeNKTclFYz1aHfL/ziZLlRJI8KQc2CAKDlElEL40Revxip7kVXWy4a6+rApgQVmeqMUfr97X54hZ6StW5QfRFk4/Md88xOCGF3Q5Uyqgs7B6+8CiQz4Aq9YomqekokKFdnM12lOAI69ggqlWrzCYhM4wiiny5R/zdg4cGVkp0mew5u4ikgUECCDM3xymb/Bn5NbmW11ybdVeuDt8rUehw790xgzaCq6g1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9cHSXbs0rA5HBRV/bqOjLENRjEkMDHFEnrsoN4cA72U=; b=amEE1xG3kFc6umlAYjwUiEvVMD9+9sUkV1ezGu1AIkx/59irehkfAgnoqJsTA2eoW9q56hSuCPD6xU4wWYjsLiduKctD6RZW5DsuSzDgSsqQ79SaIuFN0L3kjWU7l/bpCoxqUvvorREoVW3g3UV6lwoOMEFRb0ef1BdXjbJ/MpAbskXnSheU4rIn8EObC9rgh8iivP+UeDdiVdBi4ituUbQe+qnWk4Sh9x5Oo1TvtMYnxRTzqi2ef9RYmYiddqOWcYUEQOUPnBREp/03hDNMNnu1GDbMxjSpdrO8BCRaLneV54gTRNe6JChVX86DIfQxQyS7bmTl39vJjULkKI936w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9cHSXbs0rA5HBRV/bqOjLENRjEkMDHFEnrsoN4cA72U=; b=F0l5nW6+7BPoFj65ycsCBmGk3PaLiMYkbaDyhTeCZDkyv3NaMdCxoA0zyWXEG6PsIYB8Yhg/bkgMLuMxVk+MFX6Wtd2g3TRZys60ZTHyopURVR2m48IaqB0hjsyPkEWgLv8DLLT0fbyOSat0i5353Rop1GJzu0d5oagEn5kUN5q7weDSFkXbF3T9BQ+f+tncr9gGH3YgRyllMRcKx7j59+Cw6i6Np3wMel5yF7CA+XmeGUG+bVsVN/KJHkqK0IS8yVYKkdl34aEc+CTtEJOViWBK9hciCbQoLMCpuH7MsaMfs5qs4waKxJonb0ADSmcTXBP6RZS3/zILFID0y7hXFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) by SA3PR12MB7878.namprd12.prod.outlook.com (2603:10b6:806:31e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Wed, 1 May 2024 15:56:44 +0000 Received: from IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::abca:c0e2:1a95:d6ab]) by IA1PR12MB6332.namprd12.prod.outlook.com ([fe80::abca:c0e2:1a95:d6ab%5]) with mapi id 15.20.7472.045; Wed, 1 May 2024 15:56:42 +0000 Date: Wed, 1 May 2024 18:56:37 +0300 (IDT) From: "Etelson, Gregory" To: Stephen Hemminger cc: Bruce Richardson , dev@dpdk.org, =?ISO-8859-15?B?oA==?= , rasland@nvidia.com, alialnu@nvidia.com Subject: Re: [PATCH] cmdline: configure input buffer size In-Reply-To: <20240501074238.0033d275@hermes.local> Message-ID: <3ee37b9c-25f-cf53-5b3-63b736327766@nvidia.com> References: <20240501052659.231457-1-getelson@nvidia.com> <96d1ac1-b2cf-f6db-1e24-aead628a9d16@nvidia.com> <20240501074238.0033d275@hermes.local> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: TLZP290CA0014.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:9::13) To IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6332:EE_|SA3PR12MB7878:EE_ X-MS-Office365-Filtering-Correlation-Id: 185ede23-90bc-42cf-f82d-08dc69f74b62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|366007|376005|1800799015; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?lfCV2lyEX8P+6v05BqOBQmAIuAfIll43QB1Whd4wNDqmZpNaY3BuPv8zYRTA?= =?us-ascii?Q?hfTUe/892OK3cDJY1IxwBDEuvSKMDZn9o24N/wb56edKcQJEqcfY0gws56Zz?= =?us-ascii?Q?99MAhUEu3o/dzWGx+NtT56qoQm76+2FhIS0sv5a25fe/RYbgt5QlUpqaZt7f?= =?us-ascii?Q?zBh+ZIqQr8z+zO5vgb0Dnyg20EZjizE7P2vvjFVnslCPYT7bAZjudMgg/Z6F?= =?us-ascii?Q?mKrKtXSwmv5xR5Fnld88gW+PadHv5N5DUpoOY0mOaeavfzdNHotQXiNLB7Ph?= =?us-ascii?Q?N26wPUOjDLibL3TlGXMxuGZar5WmrsbogmbUuKZwjAKOfJcDBpXcHAGiUFWI?= =?us-ascii?Q?ZhYEE16FP+Lty/rMTZbvjH3UyijUD+6UNdcvR+fk6iD6jjmHli+9Z2JGO1VP?= =?us-ascii?Q?1JlBlQJg8YPYdsQrQgTd/QgErtnW1+WfAtyfO7GN6I/haYaD6WzRIfuvdST4?= =?us-ascii?Q?WyONjmX2lxuIHbhHQKRUUW37XBi5nOCx02ruxiV8eaL1Ebi6ayU+1F6lWOR1?= =?us-ascii?Q?iMn+yaAxPHoUqj+nbxeQl8VfLwACtSkUzp5YGGmmSuSlevec+h6YzwrHgyw5?= =?us-ascii?Q?OJiG3DxBTeF5+0MjvoGI1bvkTsLkXRT1s3uv4G1gG860gTaZ8h87v0AnLh1e?= =?us-ascii?Q?NLDwWLTXByaxTtJU2Ws5n8AT1kxbU7BAdoarImFWEgVcpkVPEZakIzqhZBTb?= =?us-ascii?Q?xcr9rjKvY2UioO5xZPJbu79qxLHJ6EDQrXSxJK9Wqt38gcn6vNKWpZff6fse?= =?us-ascii?Q?TIR7Eu5Z1gJvIPVQMTP49yc4tvrCpX1PwL3ytEeePzQz97wNqd1cXIPVfjzw?= =?us-ascii?Q?uMdSAvXrDxEFwyY/iyXl+Bj4PxBy/u/6xTd6uKk74VP1kIiuk2+amuBm8/s/?= =?us-ascii?Q?N5ILrXNPTfhVdq43veAKlD++GmJkNgSgrHH2sq9f/Dg+PLRmBL6Pv0TfouNb?= =?us-ascii?Q?fKlfGStffLO2jTbeIMid5iYcD83m3xI2qAe0VNPcRyrz/kikB+eEiB2KlxVj?= =?us-ascii?Q?SZjss8xIWNefW2j+U4rjhYtdGC3vxQkRd1G0/8rQ79fJmVeD4Xy2nf9etSmN?= =?us-ascii?Q?c77yzWDgJ9s/siJvY9m9c/Zxx2FWmD7uypimWtxfUlDeVn6Cfv/MPfZQ74Mk?= =?us-ascii?Q?zrXVC8dZ7j1WmcCVknBwFO8OsPlSWtfllrxePxxyYXeOQHbEW0LPKeD/HCrt?= =?us-ascii?Q?ldkU+xFslFLzN5312LH5NX0BWXIVnilAvq4G/tzHbfJ9TxpKxiH6/N6Pkscw?= =?us-ascii?Q?BJkQr94VtQNjBb0DEwFyAxN3KJ13pebNodzgxRR5Sg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:IA1PR12MB6332.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ToPPB8SuM9bTJf9Pc3G8vFUHuetNqkFw0qdhVs9qJGkJRHeVfT2AG5dFM4iw?= =?us-ascii?Q?556/421hW7oj2bXAdECwofOHmC9AjJIK8AFXJ7ClvxmDEMzFCl5/LyRKuaii?= =?us-ascii?Q?kRIpnRfHSQZZ2tN1D6DqK+awqlDjGVbwQEKaIoS4wV4EsioV7SwKk3zG/jwg?= =?us-ascii?Q?u/zc8iHQhE3lJp1C1VRMxxcU087RcyWzwvKe9MFc6S5mMgWsJhd8ADCdjpFw?= =?us-ascii?Q?NYnNXHV9OR7J5X18G0Ogu1BhwJizeOvvEI4n8jQkGTWDZsXvmkSHn1WYWGAU?= =?us-ascii?Q?r+tHac74XL5S+Vn9P5K+5MiMWB3i7S4IH+uXc4kqBAOhMC27T57qJ/tu7wCe?= =?us-ascii?Q?Bw5/mbUO7z0jcW8bAEbcAr+nvXyC6ueHCf4V720FGknmHMsQjevMFTfXYdQB?= =?us-ascii?Q?uXoE98Dw3KwmhbfqpLlNhvdBV8F09rcKZ4PEv1Wt3kO0pR+h9SND3msaAR+y?= =?us-ascii?Q?g4E7gj2Pypf4M8lELqlmN+cwc9rcPxyK2ZXn1SD3wEpBh9j7AATlB3Q2oV5H?= =?us-ascii?Q?ZLXtV+wUa2lELLA4X9eCAkViy8G0OExFRWAXlcZgbH8BhVEUeS3NrDQsHnMI?= =?us-ascii?Q?u9IcIVt2FbW8rIhp0GEK96ZV6KWSocErIWTQVMKIxKTDyTjRxzgvzr+rwpEw?= =?us-ascii?Q?wtRC4BQxFMwTHEBHrKdtlMWjlni8jvE1o54IsSq8JkdC9187Q05dF/S89QlD?= =?us-ascii?Q?H+g2OsJsEgKJVC/Qr7+AK0jN/PGns7cBtXUBpR29ZD1cJHsy8UnKrElghr9C?= =?us-ascii?Q?RpOxFgWt8zasrzlCG32ievnIXFQDKQJzMHgJtCgI6VVN67eDsG6Jvx024R+4?= =?us-ascii?Q?ugjO2XokcLyhIIOdZvrQV7306aOLZqvs6BQLs/9qIvK24X8Kx57MyO3HMntZ?= =?us-ascii?Q?owvBS9twgRrm7pjRS4S7V5bscJruuKtN+e2hMEa5ob+1U0xMzVttxuymtfTK?= =?us-ascii?Q?P7vU9QqgyI84NDmVL51qgWcIyLfjc160GdyvV1ONkVf6jq1196jGiGonq3A/?= =?us-ascii?Q?IeqAm/fj5j7lIvqOMApnM5iP9D1p69cgTZWj4ya1gb19bPmip1qFeVG6MZtC?= =?us-ascii?Q?CqSf+FqipeTFRnpysq8W88FX/DiNMcMJzzp+iWgJVCnG3BfY79tjQEPrb2Yr?= =?us-ascii?Q?QGxZQUdOZcWOSZnFvj+T6vvjMtja5bVlXpYjQUqMW3yuU82XGF85bvIO2mow?= =?us-ascii?Q?B0GFG4ztJWgjlhUuINcy+ibA+IZz3lKsBMbv8FQ8g+nQQ9xVZgVEex5786Yz?= =?us-ascii?Q?9ZxOJZEY3dQKD1mObqizAzTmmCYjeN6mckut88SocbcoSvYMPplJsC6S+gbZ?= =?us-ascii?Q?V3zM9rzGzbJ3A8tb3+xeDA7xguf0U+EIYf5o6Z3rdIZlpf4Ju2J5X8uUw+RZ?= =?us-ascii?Q?eroARQphByii3qVODAOnynaIRxV+uapnNB1mspoSKaFAom1OKYex43ie0Rgz?= =?us-ascii?Q?JfwX26NLr+9fuAS88L+b3T3YYuG1SFxA35dm7cgdo6EBxdP2Kfk0UcnXkM76?= =?us-ascii?Q?6hMShbXGgbT575PKdTgy6CeKuoPm/660olVqNJ4RBi8bwlOzDN4wk4JgIJRo?= =?us-ascii?Q?G23AlK5nG8RqNK7HkiJAAO0ORAeqmVP0y6R8896W?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 185ede23-90bc-42cf-f82d-08dc69f74b62 X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6332.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 May 2024 15:56:42.4207 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B/p5iGT4Tdds0H8Sk9o0ia49KqxEfOnBlAsLQWD5uMAkLciCjrUPKsIAcDfAHWoh1tTxxlIJcQKLOqfxCEIA2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7878 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Stephen, >>> Basic question, what would be the impact of increasing the default from 512 >>> to 1k or 2k? Do we get a large memory footprint increase, or is it just an >>> extra 1 or 2k of memory used? >>> >>> /Bruce >>> >> >> Increasing the RDLINE_BUF_SIZE size will also increase application memory usage. >> However, that memory increase was required, because application could not fit >> it's command line into the default buffer. >> >> Applications that can run with the default RDLINE_BUF_SIZE are not affected by >> that patch. >> >> Regards, >> Gregory > > > The buffer is transient so should have little impact. > Why not just use LINE_MAX from limits.h? > The LINE_MAX value will be enough even for the template API testpmd commands. If there will be no objections, I'll set LINE_MAX as the new RDLINE_BUF_SIZE. Regards, Gregory