From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEC0CA0C4B; Thu, 14 Oct 2021 18:46:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B643A40041; Thu, 14 Oct 2021 18:46:49 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2C26C4003C for ; Thu, 14 Oct 2021 18:46:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="228008734" X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="228008734" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 09:46:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,372,1624345200"; d="scan'208";a="487509841" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2021 09:46:38 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 09:46:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 09:46:37 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 09:46:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A3UPIgeDUQO6mjwASm/KAK9JK+92wW0OR8NTm2d/jjdzfuR0n9WUYWWn/2l8HimzANMw3/UoYwRvYgFAj5TEODCAGvp8wltgbnOnp6djoRiWXKcHfPuhAdG8Wu0rDQ754pgl4Iaz0NwQCIHA8/aAlJ1w9xIRmrihcYQQxCGFlMPug9ndiJ7L5+R1ZgKCdtlYanPuVly46KUpIQW8YCpBnVJyQAEZldguyQyzDkqBfbdYLWVyVE6oXDonC0XKjDwTT2/UzUHvWn+VmNQD7yYLNWoI6HJuUfiNebzcK67OWFeRM+JKYf+3FxBYeN+xDpeOx1i/82dS6AN5XGkMyUm5Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/kVKmBvrFG6GAgUjLPvKcfPyc2reuLFLQFyUOCNAP7c=; b=AufzwEZDccHJ2JWfq/k3apya2O/k6GrV5bsw3Matw/92766H30s2KDhWrXihOxRHXOoo2zhSTFsjHY4JGyawc0P1BPqJqQhXtUpZXQSpjWAvhLK6e9b6KthFTxZ/jdpp3OkKfZPHX8uJKNULBJuT6hrVm4Vfazj+J2xGtMCRAHNXPWcGj+Rh8j8imXO/Hm1F+hZudo1GPGYwGpuXg6WuMfBblHOA6VzUme9LOPPg1bDT7X2Mh0fJaCHt4vHMmAFk384b7Ub3s1wAprUKt2GhmfwW8ytqnLEZE+z2y/vcxBwMwlcexcjh48OMsBkiB6ZBUVPahQi/ncD4rxafv+uPOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/kVKmBvrFG6GAgUjLPvKcfPyc2reuLFLQFyUOCNAP7c=; b=gDP+a65EccMMBM+GMcqFeHKgChIri+8lBVCzRIFXRXSbAmvIKiLk+6ApER1CRBItQo3Sj3TSi/azAte3NZjdoCoNXx6x4d7l+5oLuJVpAbcLyk4ZCh6b6ZXe44dJH3XCJ8sUjxb0wrsZd8gZCtcISc99GoJt1zGTGK63+ANGQnc= Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) by PH0PR11MB5174.namprd11.prod.outlook.com (2603:10b6:510:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Thu, 14 Oct 2021 16:46:36 +0000 Received: from PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::4c6a:b2b:c561:4c85]) by PH0PR11MB5013.namprd11.prod.outlook.com ([fe80::4c6a:b2b:c561:4c85%8]) with mapi id 15.20.4587.026; Thu, 14 Oct 2021 16:46:36 +0000 To: Honnappa Nagarahalli , Stephen Hemminger CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "yipeng1.wang@intel.com" , Dharmik Thakkar , nd References: <20211013213858.16200-1-honnappa.nagarahalli@arm.com> <20211013154158.280d5db8@hermes.local> From: "Medvedkin, Vladimir" Message-ID: <3eeb7653-0511-5da0-6617-c406140fb95d@intel.com> Date: Thu, 14 Oct 2021 18:46:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::12) To PH0PR11MB5013.namprd11.prod.outlook.com (2603:10b6:510:30::21) MIME-Version: 1.0 Received: from [192.198.151.52] (192.198.151.52) by DU2P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16 via Frontend Transport; Thu, 14 Oct 2021 16:46:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fca2592c-27fb-4564-d54f-08d98f322f91 X-MS-TrafficTypeDiagnostic: PH0PR11MB5174: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ldp6ZcaoINaMDXidDhG7xqieO9hC01uD2JXeyCBEwlj15Ib/bLEkGu0zyJT/cS+SSkyGAnHY3Nw2yxSihTP03hTGvffkzI+Q2y4OhGYQw4LR+vWjN5eyuax2NM4apHbWmoRPiIszdANBnyHSXgy218saCCmjp8K7QB1ZBe6To6snH3UXa6RfGaguVKglLc9ML+3fjqLHr4eFtfrQcp9SMOXuzTgO+UlZ/PDXFFpitJiEvNPo9Ha/M5s6JH5zQDqqCCfBPbEK2+rGzsD7gGR+CHyyUW33joqwIU/HLFOL0037tk88StMAQfFYtYPHfeF4cPks1qiK2FICovZd0RQaqgAYqk016EXhASy5T1ksuZCwU1JPJzU2g+Vem/vDT8OcDGv0lQF9ve3f7OMMKyHJpToZK9d8Ir9kj2Xww3mPr6mcV1+Q9S3T675elyKGjgluP3doPUdTrahzyp1WZAd+3Goj1a9krXvQ/niZk3yERXZtN1Ll/KUE4HUZ1ZJlohydOa8K1hqjUa4sIioaniQzbaxIpZcmNF8PDHhAq51kAhn7PHgiQttFr8z/pExEPx2RRcE3DYAi+2eNnsOK7Q6Pe3oSgX/YJ1fZB5VrNHPNAqYhfekfNFs0fEh7D9qxQb7pXj12dxM8bN9Ul3DVuLsY3cdF7YI7oaxdhg9QwEAe2TH5Mc/SjNu4v/az55iG2qM/FxG3UJJBYXOepDyDxoiZq4DsJpGfpIrRC5e1zN+Xn5XcLQztAoL+Xol6fFwn154NJT4/+msP+DM7NkoeA57NKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5013.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(6666004)(38100700002)(53546011)(26005)(4326008)(31686004)(6486002)(5660300002)(956004)(2906002)(31696002)(8936002)(186003)(2616005)(110136005)(83380400001)(86362001)(16576012)(36756003)(82960400001)(316002)(66556008)(66946007)(54906003)(508600001)(6706004)(66476007)(3940600001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3B6RlFzYUlpZUUvUEVCMzJUT3NHcyt4d3B3RWtSMEl3WjI0bkFqUGZDQXk4?= =?utf-8?B?bEplSlpBVit2dUdqUHV2SjYyNWswaVlwMjRTSENCVFUrOVl1UjRZNDN1V2w4?= =?utf-8?B?NVF0NEVaeS9icXNVYy9CVG1xeHU3RG5oeE1Xd1k1Q3U1RVpibExxRFptaXpT?= =?utf-8?B?OUpQbS91ZVdDSDk5U3hGUGFVd0VJSGkzL2VST1EwUDVMelBuZi83UE15ME9R?= =?utf-8?B?akF2ZVdNc2F0dHQyd3M1MWMxd0NPSmdVc2ZTN3U5TC9qclBrR3hnU1Y1VUdQ?= =?utf-8?B?YUlSaEVVU1A3NUVjWDM4ZHNVdmpRQW1QeGppSVNQOHdhcnFqUlR2WlZYaktn?= =?utf-8?B?M2NSNG96aUJDeDFPemx2ckV6KzRsbzlSVUpwUmNwODJqZnVwZ0VHZEM4VVpl?= =?utf-8?B?a0VSMmI0bGVESWFqZWEvd2dTai91YUZjY3BYaVNsZ1FEN2s1N244RnI0U25Y?= =?utf-8?B?MUlxMWwyM1g0UTAzZ2lDc3pOQmMzc2szdk12RnkyS1h3dGE5aC9PRWJqOC9y?= =?utf-8?B?THNVT1h1eFJxYlRoU1FNTG5VLzhLNVRlcjlRV252WmNZWHpuaVBMakFXeElu?= =?utf-8?B?QnM5MEV4bTFUTmJhaE1PYXNoRzJxMGlqTExMY09SQno5YkpHRlBYU2lsakJO?= =?utf-8?B?NG92Q3pGQ2h5a2tTTG9aeXhUK3VTaFZRaDFpMDBOS2hDYXZjbFRwV0RBV090?= =?utf-8?B?Mzh6Q3h3ZWUxb1JoaU1aNmhuK0kyV0JhVkN2NStQOXA4Z0JsT2RQQWRaNWtF?= =?utf-8?B?R1lDclNNYnY0VDkrcXVYNlZFY1FsK0J3ek5WZGNOSTl5Y2wwc0NWVU9IOUJP?= =?utf-8?B?VkgwTXkydkY4eU1DMEdHL0EyOW5MdGljK2VjTlpCUGc1TlpkUXpVYnpuQ1do?= =?utf-8?B?Q3dLRTZRbDNEaDFnaXFaZmJWbnJpZCtDMmNEN0Q4ck5EdFJEVEFNOThHYnls?= =?utf-8?B?Nk9STUs1ZmFZNVhxazYreGE5QlgwU2drSnYwaEZ6cUIvVW56bkRobTEwd3dC?= =?utf-8?B?dHFYVm5CcGhRdW5GOWxkc0UrempEWkpqVGU1TU5IWUx4b1RSak83RlVUNTdK?= =?utf-8?B?cnlnUzNtaGZUUkdTeFl4WHVROW8rWkZUT09IMWNiTWdpNGZaQWcxVFZ3OUZo?= =?utf-8?B?U09JbmtZdlZKdTd4Z251eXBkL0RiWTBoVlhQcXVPUUV1TURrZi81TVZzaDRY?= =?utf-8?B?NWxjS0xZdWw2SDc0VGJ6WU1HcDFJakRPTk14OFUvV01tUnJyWDQ4djhpL2tD?= =?utf-8?B?RWhiVjZIanBiRHYrcFg2MkFDUHhIMnh3dThZSzBESXpQcUtiUUZheEl0K3l6?= =?utf-8?B?aVFXZjRjaENyeUJwd3BWVHBWR2c3ejZDdWttZ3k3Zlc0clVlNUxrdVdaY08z?= =?utf-8?B?U0h3VUtjTWg0TGwyM3VqY0ZIVU9IenB4ekkwYkRsdkJ6SDNIWnhpbkdicXl5?= =?utf-8?B?NTMyNTE1aHhmS2UzUXNkN2FROUZSZ2pKZEVIblJ3ZnV2SEZYc2t1OFRvTitP?= =?utf-8?B?UDFMVkdkS2M5VlJqb2FGcUszb1BhQWY3cmorWUZnVW5ESExSV2NxSWx2RlA3?= =?utf-8?B?bk5Pa0U4WHJWREtWV3hacEdQRW9Dek5vbWZsSSs0WCs0Z2NzcDF4WXF5S2Jo?= =?utf-8?B?Yk53OHAyWkpqRE1TRWRvekZ1N3JGMGRvR3RNaG5mbjJkZFc1aUw3c3RTa051?= =?utf-8?B?VWpFbnlvaDlaUDFXMjU2VFRBbWdvLzRId2d4eGR4RjVwME5RbkpaNisvOG9I?= =?utf-8?Q?zdZnhi7T5TZwXzyuaxBnlBHbt544wV0yWiVhvoa?= X-MS-Exchange-CrossTenant-Network-Message-Id: fca2592c-27fb-4564-d54f-08d98f322f91 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5013.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2021 16:46:35.9924 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o1tvrxtPdLmZRVh8m2oiq9Amt8PBD629zhX9CPwgILKL7qsg00hPmPO6pO+Y9d2YfAL3USxGKn3ZQ8q7Pq6DYRCJG8ns7GESWBQX8jxwFbI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5174 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] hash: promote APIs to stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, On 14/10/2021 02:19, Honnappa Nagarahalli wrote: > > >> >> On Wed, 13 Oct 2021 16:38:58 -0500 >> Honnappa Nagarahalli wrote: >> >>> --- a/lib/hash/rte_hash.h >>> +++ b/lib/hash/rte_hash.h >>> @@ -430,7 +430,6 @@ rte_hash_get_key_with_position(const struct >> rte_hash *h, const int32_t position, >>> * - 0 if freed successfully >>> * - -EINVAL if the parameters are invalid. >>> */ >>> -__rte_experimental >>> int >>> rte_hash_free_key_with_position(const struct rte_hash *h, >>> const int32_t position); >> >> >> Need to remove @warning EXPERIMENTAL in comment. > Agreed > >> >> >> What about all the other experimental functions in here? >> It looks like all of them should be promoted. > I just changed the symbol that was reported by the tool. > rte_thash_*** were added on 4/19/2021. Vladimir, are you ok with promoting them? > I think it is too early to make this API stable. > Yipeng, if you are fine, I can promote rte_hash_lookup_with_hash_bulk, rte_hash_lookup_with_hash_bulk_data and rte_hash_max_key_id. These are around more than a year. > -- Regards, Vladimir