DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, cheng1.jiang@intel.com, chenbo.xia@intel.com,
	zhoumin@loongson.cn, david.marchand@redhat.com,
	thomas@monjalon.net, stable@dpdk.org
Subject: Re: [PATCH v3] vhost: fix build issues with GCC 12
Date: Thu, 6 Oct 2022 09:51:29 +0200	[thread overview]
Message-ID: <3ef7068d-5e05-4a4d-653c-43b1b31dd869@redhat.com> (raw)
In-Reply-To: <20221005170143.6235a939@hermes.local>

Hi Stephen,

On 10/6/22 02:01, Stephen Hemminger wrote:
> On Wed,  5 Oct 2022 22:35:24 +0200
> Maxime Coquelin <maxime.coquelin@redhat.com> wrote:
> 
>> In practice, it would never happen since 'pkt->pkt_len' is
>> unlikely to be close to UINT32_MAX, but let's just change
>> 'size' to uint64_t to make the compiler happy without
>> having to add runtime checks.
> 
> 
> Would the standard typedef size_t work since that is what sizeof() returns.
> 

I'm not sure it would not create issues on 32 bits architectures build
given size_t is 32bits in this case if I'm not mistaken, as it adds
something to a u32, so it could wrap to 0.


  reply	other threads:[~2022-10-06  7:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 15:11 [PATCH v2] vhost: fix compilation issue in async path Maxime Coquelin
2022-10-05 15:36 ` Maxime Coquelin
2022-10-05 16:34   ` David Marchand
2022-10-05 20:35 ` [PATCH v3] vhost: fix build issues with GCC 12 Maxime Coquelin
2022-10-06  0:01   ` Stephen Hemminger
2022-10-06  7:51     ` Maxime Coquelin [this message]
2022-10-06  8:22       ` [EXT] " Amit Prakash Shukla
2022-10-06  9:05         ` Maxime Coquelin
2022-10-06 10:21   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ef7068d-5e05-4a4d-653c-43b1b31dd869@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=zhoumin@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).