DPDK patches and discussions
 help / color / mirror / Atom feed
From: fengchengwen <fengchengwen@huawei.com>
To: Mingjin Ye <mingjinx.ye@intel.com>, <dev@dpdk.org>,
	Stephen Hemminger <stephen@networkplumber.org>
Cc: <stable@dpdk.org>, Aman Singh <aman.deep.singh@intel.com>
Subject: Re: [PATCH 2/2] app/testpmd: fix the IPv6 extension offset
Date: Tue, 18 Nov 2025 08:22:17 +0800	[thread overview]
Message-ID: <3f13c88a-5120-4852-942c-adde6fe0941d@huawei.com> (raw)
In-Reply-To: <20251105024724.830304-3-mingjinx.ye@intel.com>

On 11/5/2025 10:47 AM, Mingjin Ye wrote:
> The skip ipv6 extension must be offset after the IPv6 header.
> 
> Fixes: 76730c7b9b5a ("app/testpmd: use packet type parsing API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  app/test-pmd/csumonly.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
> index d355dbd8c0..4b24bde190 100644
> --- a/app/test-pmd/csumonly.c
> +++ b/app/test-pmd/csumonly.c
> @@ -559,6 +559,7 @@ parse_l4_proto(const struct rte_mbuf *m, uint32_t off, uint32_t ptype)
>  
>  		if ((ptype & RTE_PTYPE_INNER_L3_MASK) ==
>  				RTE_PTYPE_INNER_L3_IPV6_EXT) {
> +			off += sizeof(struct rte_ipv6_hdr);
>  			ret = rte_net_skip_ip6_ext(ip6h->proto, m, &off, &frag);

As patch [1/2] said, this logic has problem, consider following case:

  ether + ipv6-with-option + tcp

and enable TSO offload.

It will not do TSO really, because the ptype is 0x1C1 which the INNER_L3 was not set,
then the parse_l4_proc could not identify is ipv6-with-option, it can't identify this
packet is TCP, then it will don't do TCP on this packet.

>  			if (ret < 0)
>  				return 0;


      reply	other threads:[~2025-11-18  0:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05  2:47 [PATCH 0/2] L4 protocol retrieval from L3 header Mingjin Ye
2025-11-05  2:47 ` [PATCH 1/2] app/testpmd: revert " Mingjin Ye
2025-11-10  9:56   ` fengchengwen
2025-11-12  9:01     ` Ye, MingjinX
2025-11-13 12:20       ` fengchengwen
2025-11-17  8:07         ` fengchengwen
2025-11-18  0:16   ` fengchengwen
2025-11-05  2:47 ` [PATCH 2/2] app/testpmd: fix the IPv6 extension offset Mingjin Ye
2025-11-18  0:22   ` fengchengwen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f13c88a-5120-4852-942c-adde6fe0941d@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=aman.deep.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=mingjinx.ye@intel.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).