DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/hns3: remove roh devices
@ 2024-10-26  6:38 Jie Hai
  2024-10-31  5:47 ` Ferruh Yigit
  2024-10-31  6:30 ` Jie Hai
  0 siblings, 2 replies; 4+ messages in thread
From: Jie Hai @ 2024-10-26  6:38 UTC (permalink / raw)
  To: dev, thomas, ferruh.yigit, Yisen Zhuang
  Cc: lihuisong, fengchengwen, haijie1, huangdengdui

From: Dengdui Huang <huangdengdui@huawei.com>

The devices added in commit 3f1436d7006c ("net/hns3: support new device")
is no longer available, so revert it.

Fixes: 3f1436d7006c ("net/hns3: support new device")
Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
---
 drivers/net/hns3/hns3_cmd.c    | 4 +---
 drivers/net/hns3/hns3_ethdev.c | 2 --
 drivers/net/hns3/hns3_ethdev.h | 2 --
 3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c
index 3c5fdbef8fc9..146444e2fa99 100644
--- a/drivers/net/hns3/hns3_cmd.c
+++ b/drivers/net/hns3/hns3_cmd.c
@@ -545,9 +545,7 @@ hns3_set_dcb_capability(struct hns3_hw *hw)
 	if (device_id == HNS3_DEV_ID_25GE_RDMA ||
 	    device_id == HNS3_DEV_ID_50GE_RDMA ||
 	    device_id == HNS3_DEV_ID_100G_RDMA_MACSEC ||
-	    device_id == HNS3_DEV_ID_200G_RDMA ||
-	    device_id == HNS3_DEV_ID_100G_ROH ||
-	    device_id == HNS3_DEV_ID_200G_ROH)
+	    device_id == HNS3_DEV_ID_200G_RDMA)
 		hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_DCB_B, 1);
 }
 
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 8b43d731acae..649392eb0e61 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -6651,8 +6651,6 @@ static const struct rte_pci_id pci_id_hns3_map[] = {
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_50GE_RDMA) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_RDMA_MACSEC) },
 	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_RDMA) },
-	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_ROH) },
-	{ RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_ROH) },
 	{ .vendor_id = 0, }, /* sentinel */
 };
 
diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
index 799b61038a06..7824503bb89f 100644
--- a/drivers/net/hns3/hns3_ethdev.h
+++ b/drivers/net/hns3/hns3_ethdev.h
@@ -28,9 +28,7 @@
 #define HNS3_DEV_ID_25GE_RDMA			0xA222
 #define HNS3_DEV_ID_50GE_RDMA			0xA224
 #define HNS3_DEV_ID_100G_RDMA_MACSEC		0xA226
-#define HNS3_DEV_ID_100G_ROH	                0xA227
 #define HNS3_DEV_ID_200G_RDMA			0xA228
-#define HNS3_DEV_ID_200G_ROH	                0xA22C
 #define HNS3_DEV_ID_100G_VF			0xA22E
 #define HNS3_DEV_ID_100G_RDMA_PFC_VF		0xA22F
 
-- 
2.22.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net/hns3: remove roh devices
  2024-10-26  6:38 [PATCH] net/hns3: remove roh devices Jie Hai
@ 2024-10-31  5:47 ` Ferruh Yigit
  2024-10-31  6:30 ` Jie Hai
  1 sibling, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2024-10-31  5:47 UTC (permalink / raw)
  To: Jie Hai, dev, thomas, Yisen Zhuang; +Cc: lihuisong, fengchengwen, huangdengdui

On 10/26/2024 7:38 AM, Jie Hai wrote:
> From: Dengdui Huang <huangdengdui@huawei.com>
> 
> The devices added in commit 3f1436d7006c ("net/hns3: support new device")
> is no longer available, so revert it.
> 
> Fixes: 3f1436d7006c ("net/hns3: support new device")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>

Hi Jie, Can you please ack the patch to proceed?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net/hns3: remove roh devices
  2024-10-26  6:38 [PATCH] net/hns3: remove roh devices Jie Hai
  2024-10-31  5:47 ` Ferruh Yigit
@ 2024-10-31  6:30 ` Jie Hai
  2024-10-31 23:31   ` Ferruh Yigit
  1 sibling, 1 reply; 4+ messages in thread
From: Jie Hai @ 2024-10-31  6:30 UTC (permalink / raw)
  To: dev, thomas, ferruh.yigit, Yisen Zhuang
  Cc: lihuisong, fengchengwen, huangdengdui

On 2024/10/26 14:38, Jie Hai wrote:
> From: Dengdui Huang <huangdengdui@huawei.com>
> 
> The devices added in commit 3f1436d7006c ("net/hns3: support new device")
> is no longer available, so revert it.
> 
> Fixes: 3f1436d7006c ("net/hns3: support new device")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
> ---
>   drivers/net/hns3/hns3_cmd.c    | 4 +---
>   drivers/net/hns3/hns3_ethdev.c | 2 --
>   drivers/net/hns3/hns3_ethdev.h | 2 --
>   3 files changed, 1 insertion(+), 7 deletions(-)
> 
Acked-by: Jie Hai <haijie1@huawei.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net/hns3: remove roh devices
  2024-10-31  6:30 ` Jie Hai
@ 2024-10-31 23:31   ` Ferruh Yigit
  0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2024-10-31 23:31 UTC (permalink / raw)
  To: Jie Hai, dev, thomas, Yisen Zhuang; +Cc: lihuisong, fengchengwen, huangdengdui

On 10/31/2024 6:30 AM, Jie Hai wrote:
> On 2024/10/26 14:38, Jie Hai wrote:
>> From: Dengdui Huang <huangdengdui@huawei.com>
>>
>> The devices added in commit 3f1436d7006c ("net/hns3: support new device")
>> is no longer available, so revert it.
>>
>> Fixes: 3f1436d7006c ("net/hns3: support new device")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>> ---
>>   drivers/net/hns3/hns3_cmd.c    | 4 +---
>>   drivers/net/hns3/hns3_ethdev.c | 2 --
>>   drivers/net/hns3/hns3_ethdev.h | 2 --
>>   3 files changed, 1 insertion(+), 7 deletions(-)
>>
> Acked-by: Jie Hai <haijie1@huawei.com>
>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-31 23:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-26  6:38 [PATCH] net/hns3: remove roh devices Jie Hai
2024-10-31  5:47 ` Ferruh Yigit
2024-10-31  6:30 ` Jie Hai
2024-10-31 23:31   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).