From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75F38A0C4D; Wed, 13 Oct 2021 10:51:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C47B41162; Wed, 13 Oct 2021 10:51:05 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2E78D40150 for ; Wed, 13 Oct 2021 10:51:03 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="227341804" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="227341804" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 01:51:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="526922481" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga008.fm.intel.com with ESMTP; 13 Oct 2021 01:51:01 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 01:51:01 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 01:51:00 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 01:51:00 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 01:50:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHGt7udHTdXT/RWltLOfl8apGO0gx8kVQBWnMTxlYrUm8P2pOuq+UX2jBL+phpev+yGoEP64aSI0R4DtnT7ZIUsRP9I3Rb8XIwwPDbj+zaNknpIZjwR6CZuRJB0GvBLj7yJpZsjVOIOoNtkAIY/DN75o9FvOgOerv+lLEoJzvQd3fp5KbqnjBKN8WuV1Jhw6SGCax23OWuAelfs6nya2ODMcmgTo1TbCBUNpURC49O4HD6E7Gt4OXed1rXQRVb2CdOLmKn3sMC1wjMe/ej4upTenGOoxtEfL1q/yIdYRNFdms3SK2aLGbC/DnUlgtACp1EQn3Eu2NFSVexhvcQ+pQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ceJ/JoLtkyn9PrtAmN8Q9dOyQzIDEq1qANZjIbHXEC0=; b=QWuRn5HK7wN0aS4iDgE0VerZ0WPpCbukGavja47lcVneHNsZZQ0H37d+s+NZ15ooeWTzDhUKmldd1x695HaTVjGmNZwX2gas+PUDLNaNy4YQ45QGw8lKDdzlGd/0PHZHhjTlhNNYuUF4T2Cu9/flkF3+19xMZUpcxh/f9Ubxkngp/ajnpaLFBBFsqLx+HWznSI4wGIl3BoSBfZYBri3bAElxmeWVlMeYH5x5BcPd0jQB29CMnwJ3Yz9KhCSAwd2cQYlgC5PHzSHIlLUcoWXTRXpEJ2HctWmUqJ0gSORPS6twFOv15eRhlElyMJMhJCgjPTwX4UD/QRr5MwrurawXBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ceJ/JoLtkyn9PrtAmN8Q9dOyQzIDEq1qANZjIbHXEC0=; b=phiTUxXhNKb93bAdT1OBK5+gQlaEjr775b/5DZbogVy32frM2sQTZSUNIpK3X3Yvq28rh+t2NQIUuKjkm25HGvkgZ4IIpBn9Haqv/aiSO44eUET89O3fLsoZgJ8Ga9EnYwfeQPAjr3ofEnyMVWxbkUXklIX6tfvjWRjzwgf8+Do= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4823.namprd11.prod.outlook.com (2603:10b6:510:43::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14; Wed, 13 Oct 2021 08:50:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4587.030; Wed, 13 Oct 2021 08:50:07 +0000 Message-ID: <3f29634d-5e90-8a47-cfbc-b674e0d6a953@intel.com> Date: Wed, 13 Oct 2021 09:50:01 +0100 Content-Language: en-US To: "Wang, Jie1X" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "Li, Xiaoyun" , "Yang, SteveX" References: <20211011180111.99281-1-jie1x.wang@intel.com> <20211012025417.134866-1-jie1x.wang@intel.com> <20211012025417.134866-3-jie1x.wang@intel.com> <21c7813a-fd86-df06-84e4-d3a79425a16a@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P250CA0022.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P250CA0022.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 08:50:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d653f7ef-fa9c-4b43-d211-08d98e2674d6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4823: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0DmaLWZvcdamVNEh6Nfb7QCkyCskArVfncE3OgEmQaVtdvhE+PV7Z7e8kqVCze2QxXrFe6N5z/J3RTJpW/dY0x0Kz0Fwpw75zP6wvQHm3linxrc4YTEdWmhsHfd4BWwns1Soba7xujKG+OL/SvA/okY1GgVQXlHlBiwsROJQS+0vdO2eLAAi7t6ij6gDPuYgpLuCFcc4QR2TBGIhjzfgLO7BAghr3Mbm8Ewws43i+t1i/15rOCgu+6O5khs8i7+8dXHIgxCk9fmmVeKjL9n1IMpX1UVO5v+WIdIFFbZNJzivyAFF8rXzuL2UXg1oxuG9BEvxsAZng0bg94k+NTudhWc/dnU/G8DJXz21wIZzgkj8H7lYhic32OFIl09A+Oo6hxzz8ZC521rMSO8zvDsVlfFMJBh3iW5osDiYcZ11+VW3rS7PR0vMy4XcgR0I4AIQiSqqK3uLGhRrt4vjNfQEawcyzIvsxZIFwrgw5dMl6Draq+AGjJuL9jvgsWtqVsJTSDtmrFFqv/noQdyvKFaDmthhrEKx0ZgNNPdoZTiFqmTF6eoJj72ktB5Q7vddpF/mVW1LSlUZv+gbjgXCpMnhfuA93zE+FbaDX3JeVEA7EOuxfkCjqCNEc7dJaKAOTXeiC1fNq+NFUGP3WyYirU0HSrd0uAL/uGqad/JXqp35RonPYml1u5hpw78RW1QJrtYSmj0OU8hQKAXSQN8pCzNrxE2xxlK9g5TSm8npWQ6648FlkXepI4z0yee8ArBBVJ2FqjWJy4NCR6eBjE+plrrr23fKX4obeDlkHe+fcYlRzAo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(31696002)(38100700002)(86362001)(83380400001)(36756003)(956004)(2616005)(6666004)(31686004)(82960400001)(16576012)(316002)(107886003)(186003)(54906003)(966005)(44832011)(110136005)(8676002)(66946007)(508600001)(26005)(66556008)(66476007)(53546011)(5660300002)(6486002)(2906002)(8936002)(4326008)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXZSUG9VR1hvYWhnbE80UXExMXpuSFdBT3JLYUY1b3BLZ3J4N3NDY3d6TVlo?= =?utf-8?B?RllkNVUvZERiMlU3c0ZtZWVxVkdiTnBLSzBOdWdPeGVzV2pQR05ZM0l4ZWV1?= =?utf-8?B?dWhVK1J3RWRpbXNOT0FYT0tVZEVKUlc0cUVaU0xXbTc1WENoVmsrTEtLQTNJ?= =?utf-8?B?V010dUpjZVpIemJlaFNyMGNMN0dPcmRBWmZROUIvMzdLcUNGbG1URzlOdlRQ?= =?utf-8?B?Z3Nxd3RZamtFT0laNnVXYWZFM2xyUVNuZXZDVElxZnFBUFgrQVI5OTA2NTlY?= =?utf-8?B?R21BNnZHWW1MNkJQajZsb1BjcnozSGowYTU0UmIvV0NDc0NPd1ZwQTlJWkl2?= =?utf-8?B?enpwSExsWm9CZ3lRdGZ5Y1puMm9NaHUrT3NSTVduejNRSElCSmptTTJJMmU2?= =?utf-8?B?OXBITlpGYURyZGlhMEdOR0IwVitEWnJjSjVkMWNXRlJ3ZmpBYkhYSDR0MEZj?= =?utf-8?B?c2xMbS9nV1g5eUk0ZElINHFlNDNXWU5Mbys2V3VFUnNyRENSU05yRnprbzVJ?= =?utf-8?B?dzRPR2x0aVRpTzNrcXpxUXBrb0NpYmxSVkd4V1c2UkdJSFlRUy9BSkRJVUsy?= =?utf-8?B?M3NyMXlSSmMxQ004V3BQVW5UN3Z2K0duRGxRdlYxd0ZtVm9WUVlUMzF3ZXpq?= =?utf-8?B?T1czaHhKclI5WTZGdm9YeEtyd3JBeUorakdWeFgzeE1ZOTlGZGMxOE9pclNs?= =?utf-8?B?c1VlRTRXNDVDckErQlIxVzVBa1BxcEEvdHNQY3hlNVJGRSs3d09BVzFHdWYw?= =?utf-8?B?bGM4cWdxMFdoK00zb0xPVkpUSnczTzlaVCtjb3IvL21lUEMxY3V4Nm85Y3Yy?= =?utf-8?B?dm03TFFHMzE4S3A5ZUdmMEhLMEo1S3l2Y0dwcDdkZkYzTnBjMEFxY25xR0Fw?= =?utf-8?B?RzhiMEd6bG40UC8rT2lLZlZSY3cxbHp2Wkc3a2tiMnZJQkdDVWdyVURoMmhi?= =?utf-8?B?MXEyNEJLcGxGNmphWEZTaTlvZWdQaU8zd1F4c2pOYVJEMHZqd2NZMyt2dU04?= =?utf-8?B?OWR5RzVGK2twcHhZMjEzUGxXUVBUSGRMcXpJQ2NZa1o0Smd3YnJUbmY5d0d5?= =?utf-8?B?aXAzMXRBR1Nna1FOOHBDWE5WTFBOSTNYYUQ5U0xkSkJsMStpRzRkLzh1aFUw?= =?utf-8?B?Y2FqUXgzeEdyUzhjbXRhL1RlTm93WXJCdm40NXR5ODg4VDh4M2dMS1JQT2M2?= =?utf-8?B?bHV5c1dTb0RJTnZoTldiZXdJbVl5cDU2bHNaSFJ0Y2RnTDZxMUdEMnNhWTNL?= =?utf-8?B?UUF2eUQ1d0ZXcHVGODdqdDZqV3JzR1dwaE9FWncxQnlXclRGL01oM2pJa0h6?= =?utf-8?B?TVRoQWxSRytkWmtUMUI5WHlOTTR0cW9ZS254dXlHMlg3OGZ6cjhWWEhyQ3pq?= =?utf-8?B?L29MU1JqazBxTFFlc0RiNk5lUERTL2R1YjdqU2FGRSs1U2tEWEYraVllY2o3?= =?utf-8?B?eEpkc0hhbHJMdzMzSlR4Y2JuaU9ET1BzeWtWbEdJZnIrTDlYOEp4b2hEZzVj?= =?utf-8?B?SGk5eVlVT1V3WGVtY1ozcG5VQTdkR1gzcE5XeUg2ZXljaU9ZVXNhOWJCTk9J?= =?utf-8?B?a29vM29DL0hFaml2cks3bm9ObFV6emNGZDdOc1RNVGJUV3pNYXJvcDZ0WGp6?= =?utf-8?B?TUYxRmxGM2x3MmM2cEEvVm9OcGdXQ0l4RDJKYjJZSjBzL01MSU43eWZITlUr?= =?utf-8?B?SUJtcllPdmtRakdXbXR4M05ET3lweGVmb1dVdnlFUVpOY3ZVQ2pFa1E0Nnpw?= =?utf-8?Q?xU7u6SAssrbJkIxPlGpQlU9R0v4jB+A0Yy9O8yL?= X-MS-Exchange-CrossTenant-Network-Message-Id: d653f7ef-fa9c-4b43-d211-08d98e2674d6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 08:50:07.2670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HwsXOsHypkL09JXDMGLsTSi5Xo7TlJzSvc0Tlf1Jj7iR7O3yxKCseilHMNx6sSpkJyHCnFoxjGTdtxxcY9ifrQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash offload X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 3:42 AM, Wang, Jie1X wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, October 12, 2021 10:38 PM >> To: Wang, Jie1X ; dev@dpdk.org >> Cc: thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun >> ; Yang, SteveX >> Subject: Re: [PATCH v12 2/2] app/testpmd: fix testpmd doesn't show RSS hash >> offload >> >> On 10/12/2021 3:54 AM, Jie Wang wrote: >>> The driver may change offloads info into dev->data->dev_conf in >>> dev_configure which may cause port->dev_conf and port->rx_conf contain >>> outdated values. >>> >>> This patch updates the offloads info if it changes to fix this issue. >>> >>> Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") >>> >>> Signed-off-by: Jie Wang >> >> Hi Jie, >> >> ci/intel-Testing is still reporting some errors [1] with this patch, did you able to >> investigate the reason of it? >> >> This error seems not seen in other patches, so that shouldn't be an infrastructure >> problem. >> >> >> [1] >> http://mails.dpdk.org/archives/test-report/2021-October/226766.html > > Hi Ferruh, > > When the dpdk runs the test_pf_tx_rx_queue test case, the port will be configured with rxq/txq to 1. This will cause the test to fail. > > In rte_eth_dev_configure, if rxq/txq is 1, dev_conf->rxmode.mq_mode is ETH_MQ_RX_NONE, and dev_conf->rxmode.offloads contains the DEV_RX_OFFLOAD_RSS_HASH value by default, which causes the program to report an error " Ethdev port_id=0 config invalid Rx mq_mode without RSS but RSS_HASH offload is requested". > > When the port needs to configure txq/txq to 1, first clear the RSS_HASH configuration of dev_conf->rxmode.offloads. > > And I have talked about this error with the tester a few days ago, and they will modify the test case. They will add a command (port config port_id rx_offload rss_hash off) before configuring txq/rxq to 1. > I see, but shouldn't this fail for all patches, why it is only failing for this set?