* [dpdk-dev] [PATCH] vhost: fix dirty page logging missing
@ 2019-11-04 11:15 Marvin Liu
2019-11-06 20:29 ` Maxime Coquelin
2019-11-06 21:00 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Marvin Liu @ 2019-11-04 11:15 UTC (permalink / raw)
To: maxime.coquelin, tiwei.bie, zhihong.wang, amorenoz; +Cc: dev, Marvin Liu
Packets data are directly copied when doing batch enqueue, add missed
dirty page logging after memory copy.
Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
Signed-off-by: Marvin Liu <yong.liu@intel.com>
---
lib/librte_vhost/virtio_net.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index eae7825f0..0c33af7b1 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -1107,6 +1107,10 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,
pkts[i]->pkt_len);
}
+ vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
+ vhost_log_cache_write_iova(dev, vq, descs[avail_idx + i].addr,
+ lens[i]);
+
vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
ids[i] = descs[avail_idx + i].id;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix dirty page logging missing
2019-11-04 11:15 [dpdk-dev] [PATCH] vhost: fix dirty page logging missing Marvin Liu
@ 2019-11-06 20:29 ` Maxime Coquelin
2019-11-06 21:00 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-11-06 20:29 UTC (permalink / raw)
To: Marvin Liu, tiwei.bie, zhihong.wang, amorenoz; +Cc: dev
On 11/4/19 12:15 PM, Marvin Liu wrote:
> Packets data are directly copied when doing batch enqueue, add missed
> dirty page logging after memory copy.
>
> Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index eae7825f0..0c33af7b1 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -1107,6 +1107,10 @@ virtio_dev_rx_batch_packed(struct virtio_net *dev,
> pkts[i]->pkt_len);
> }
>
> + vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
> + vhost_log_cache_write_iova(dev, vq, descs[avail_idx + i].addr,
> + lens[i]);
> +
> vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE)
> ids[i] = descs[avail_idx + i].id;
>
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] vhost: fix dirty page logging missing
2019-11-04 11:15 [dpdk-dev] [PATCH] vhost: fix dirty page logging missing Marvin Liu
2019-11-06 20:29 ` Maxime Coquelin
@ 2019-11-06 21:00 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2019-11-06 21:00 UTC (permalink / raw)
To: Marvin Liu, tiwei.bie, zhihong.wang, amorenoz; +Cc: dev
On 11/4/19 12:15 PM, Marvin Liu wrote:
> Packets data are directly copied when doing batch enqueue, add missed
> dirty page logging after memory copy.
>
> Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> ---
> lib/librte_vhost/virtio_net.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-06 21:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 11:15 [dpdk-dev] [PATCH] vhost: fix dirty page logging missing Marvin Liu
2019-11-06 20:29 ` Maxime Coquelin
2019-11-06 21:00 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).