From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E219A0527; Wed, 25 Nov 2020 11:58:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC28FC940; Wed, 25 Nov 2020 11:58:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id A577BC93E for ; Wed, 25 Nov 2020 11:57:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606301876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V/uBlJt8evpe20KTfXz5dqZvwMJKK7XGBzxooWdAdxo=; b=HbB56aNhv8CF7dEp0wbSMZZBOFFIG7JBAT1ixbO+B9xBLNsPejgTlpOLRubMpr8c3ceVdG Dl4sjAEuTuGbURLYyHZeE6PgHafCkcbtONWIbueD7k5OdlQuETFKNFw5OEvKTvI5ArwsvJ YoLNrM2Dm+U5Xe60SRwAq7dTVuDnBLk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-308-MPsbkPlzPEinkrZf6NFNVQ-1; Wed, 25 Nov 2020 05:57:53 -0500 X-MC-Unique: MPsbkPlzPEinkrZf6NFNVQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A3C81005E46; Wed, 25 Nov 2020 10:57:52 +0000 (UTC) Received: from [10.36.110.64] (unknown [10.36.110.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C140D60BE5; Wed, 25 Nov 2020 10:57:47 +0000 (UTC) To: Timothy Redaelli , Anatoly Burakov Cc: bruce.richardson@intel.com, dev@dpdk.org, stable@dpdk.org References: From: Maxime Coquelin Message-ID: <3fa7388d-4bcf-fd01-0aa4-cb9effee5a65@redhat.com> Date: Wed, 25 Nov 2020 11:57:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/24/20 4:14 PM, Timothy Redaelli wrote: > Currently eal only tries to find shared lib by looking for .so files, > but on Fedora, CentOS and RHEL the .so file is not installed by dpdk > package, but it's only installed by dpdk-devel package, since .so files > should not be necessary in order to run a program [1]. > > This series fix that by checking for .so.ABI_VERSION that should be > available on any linux distribution. > > [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Timothy Redaelli (2): > eal: fix shared lib mode detection > eal: fix loading of shared libs from driver plugin directories > > lib/librte_eal/common/eal_common_options.c | 9 ++++++--- > lib/librte_eal/common/meson.build | 2 ++ > 2 files changed, 8 insertions(+), 3 deletions(-) > Looks good to me. For the series: Acked-by: Maxime Coquelin Thanks, Maxime